Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8709881ybn; Tue, 1 Oct 2019 11:52:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzaIK5/cIr1gZx95pcxi1TBx9lFIp1oYeSsFL2T1OEpNo8Ly+K81MeCHWrmiBQGl/TrVotJ X-Received: by 2002:a17:906:b34c:: with SMTP id cd12mr25544118ejb.48.1569955930752; Tue, 01 Oct 2019 11:52:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569955930; cv=none; d=google.com; s=arc-20160816; b=d8nVthX3KX42seAFSXoYLSAh67oR9UMYL61hKWY4XwHGCqo31ln/Ud9jIHCEhdKM5L gzwoh2AAaIpLieb0KcCVLLL446RrP8hxwvwCLnzmnLiQE04ZDClETQo+EROGqohPhalM lIGKVuw+lgx3dUoQ7DYOGJYS71CoPZo+YgVEtrQogLuEso1SAXAtuy3RP6ipzQQ2sbgN pXPLm6zKeC3A6Cv6LtDWgJtSGKZt2w8Nq2Tb4kwIIkHFRk0vekb2eKmX5x2FIP1xnDsF Z2MDZhFgLryXc6osijBNE36vgckuUOT4J6QWNnl8wseitr5XvmEK5tQkWjlDmY4hR4LR sbwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=d2q2/eI3f+KKNzv67+ZmHwnkVrSs2HmZSlh62PiLYvM=; b=fEARv3AzYI8B8u+26T3FUrYtNTThD/NxkqQ5kv0M6rjp+w5pKWl80TtQAl8w0kn16x cATX1ybpwMAHGq/MP6vHWs7J5ra4sNJcORWhKvTcOdOay5ReZ1ANTMt3bg+ph7Vis5c5 mJhQOzTGA7kJU9IpT/Vf7txRoqmGlZsjR0vvE+sfDo5ww3Z7GXsaEzwoQMvmr83ajK0s ohz0dJ1Vfjxjh/ANukAO+X5komUrl2g+slya6DHet3xCKDb6XoICejJK8J1C0ABw3AfP EaU9K2zPWra3uUscY//wijK5aaPctIjMOp6gKErI2VcDy5YIF9cgevVbxZNI37dG+OJC vgNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ue5nWn+w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v27si9458173ejb.182.2019.10.01.11.51.45; Tue, 01 Oct 2019 11:52:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ue5nWn+w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726299AbfJASug (ORCPT + 99 others); Tue, 1 Oct 2019 14:50:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:37390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725844AbfJASug (ORCPT ); Tue, 1 Oct 2019 14:50:36 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF6E720B7C; Tue, 1 Oct 2019 18:50:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569955835; bh=bBRD8WZq+ebTWJFYFaHwjQ80HEj4uzX3OTv5GSo/iLs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ue5nWn+wxjQSubuW7+L5G5Uw07ukW2ZoykYzwdqrwGSvsQX/I69oxmXGATjK+fE7r Ddvp+xGqg3usvlqGgSHrdNNeDBdysrQPtpcemlg7Bcg+E7viDxeybbu+7wmRubIj8o tpXaIzWHw1DelKyHExqSnfqxACENUA/ZXH+xNZLY= Date: Tue, 1 Oct 2019 14:50:33 -0400 From: Sasha Levin To: Dexuan Cui Cc: KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Michael Kelley , "arnd@arndb.de" Subject: Re: [PATCH v3] Drivers: hv: vmbus: Fix harmless building warnings without CONFIG_PM_SLEEP Message-ID: <20191001185033.GG8171@sasha-vm> References: <1569436998-130708-1-git-send-email-decui@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1569436998-130708-1-git-send-email-decui@microsoft.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 25, 2019 at 06:43:57PM +0000, Dexuan Cui wrote: >If CONFIG_PM_SLEEP is not set, we can comment out these functions to avoid >the below warnings: > >drivers/hv/vmbus_drv.c:2208:12: warning: ‘vmbus_bus_resume’ defined but not used [-Wunused-function] >drivers/hv/vmbus_drv.c:2128:12: warning: ‘vmbus_bus_suspend’ defined but not used [-Wunused-function] >drivers/hv/vmbus_drv.c:937:12: warning: ‘vmbus_resume’ defined but not used [-Wunused-function] >drivers/hv/vmbus_drv.c:918:12: warning: ‘vmbus_suspend’ defined but not used [-Wunused-function] > >Fixes: 271b2224d42f ("Drivers: hv: vmbus: Implement suspend/resume for VSC drivers for hibernation") >Fixes: f53335e3289f ("Drivers: hv: vmbus: Suspend/resume the vmbus itself for hibernation") >Reported-by: Arnd Bergmann >Reviewed-by: Michael Kelley >Signed-off-by: Dexuan Cui I've queued this up for hyperv-fixes. >In v3: > Add Michael's Reviewed-by. > No other change. There's really no need to re-spin just to add tags :) -- Thanks, Sasha