Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190906153948.2160342-1-arnd@arndb.de> <alpine.DEB.2.21.1910011032500.20899@sstabellini-ThinkPad-T480s>
In-Reply-To: <alpine.DEB.2.21.1910011032500.20899@sstabellini-ThinkPad-T480s>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 1 Oct 2019 20:57:49 +0200
Message-ID: <CAK8P3a3Nhh1isvm--U8-s5F0bH1DHQ8pYR_+yB9xckhzyV=x3Q@mail.gmail.com>
Subject: Re: [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function
To:     Stefano Stabellini <sstabellini@kernel.org>
Cc:     Emil Velikov <emil.l.velikov@gmail.com>,
        Denis Efremov <efremov@linux.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Russell King <linux@armlinux.org.uk>,
        xen-devel <xen-devel@lists.xenproject.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Oct 1, 2019 at 7:38 PM Stefano Stabellini
<sstabellini@kernel.org> wrote:

> Thank you for the patch. HYPERVISOR_platform_op() is an inline function,
> the underlying function that should be exported is
> HYPERVISOR_platform_op_raw. So, instead of removing
> HYPERVISOR_platform_op, we should change it to
> HYPERVISOR_platform_op_raw.

Ok, that makes sense.

> For convenience, and for testing I cooked up a patch. Arnd, if you are
> happy with it (in the sense that it solves your problem) we'll check it
> in the xentip tree, unless you would like to get it in your tree?
>

Please merge it through your tree.

> @@ -437,7 +437,7 @@ EXPORT_SYMBOL_GPL(HYPERVISOR_memory_op);
>  EXPORT_SYMBOL_GPL(HYPERVISOR_physdev_op);
>  EXPORT_SYMBOL_GPL(HYPERVISOR_vcpu_op);
>  EXPORT_SYMBOL_GPL(HYPERVISOR_tmem_op);
> -EXPORT_SYMBOL_GPL(HYPERVISOR_platform_op);
> +EXPORT_SYMBOL_GPL(HYPERVISOR_platform_op_raw);
>  EXPORT_SYMBOL_GPL(HYPERVISOR_multicall);
>  EXPORT_SYMBOL_GPL(HYPERVISOR_vm_assist);
>  EXPORT_SYMBOL_GPL(HYPERVISOR_dm_op);

Note that there are obviously no callers from any loadable modules in the
kernel, all users are in built-in code at the moment. As an API definition
it still makes sense though.

      Arnd