Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp8776008ybn; Tue, 1 Oct 2019 12:42:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqx0f9vtSrtuws6V8ZWcacvjpCPhZbyzAINLuL17WiFZpPLWu1KoVLNcWGQhsiPBFL4uRBHn X-Received: by 2002:a17:906:d185:: with SMTP id c5mr25826933ejz.139.1569958942181; Tue, 01 Oct 2019 12:42:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569958942; cv=none; d=google.com; s=arc-20160816; b=eQhFesklKj0NUal+3a0gPmSzc2n6MZRJ0ouE+HtMIz7z+MGc650n5HMjgHUU4aKGPH bXVMO3LahvRWFhY/i1Ia7yiHYYePepWNRJboVoF62rVliRz2xpFEt84OBzd6B3ZxKNMj 3Vtgy8kc0mW/0rbE5TbdwRenQNuFBvO+tttqcniDzFKzTwrJWE+O6Ec3WEBiqq+4P+1G 14oUsarF48eg50xGjFVeHst/5lBE3aWxIyfvCBEDoA4p9PHYvqfnq/Y/wvisvT9GC0G4 IQB64LCYGFRE6pwS6H2l8y19etuPA5egHMrhGNFT9GaKBvC1XSc9P+G73WOF+mKdWdx7 KvBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=ywb+nsfPF+Z3DCZgk+yF3jv1PIj9PSL8oPWXw4QNmes=; b=kqV7gWxYg8WHch3X54iSEteYg/LkjXGKm3NssvA+WjxbuGwe1CORnJ/EMFplVrI2mI I0x2hVAJNs3hH1HdkJ3PqnsYeScfBCbtQQIKEE2yiI+0TxgGidkEAo1/5kL9ZJzWnugY e6HmYKFu3/WvqhvoTFeVhPCn4vQJpf24AA++ukNedFfKLozp1/zZS2hUh2ErP+qIC58j zaHablGr9wBqSaXxL933AlSsuPazsbZkwpIh6utBXcxNJjGCbxbC3Mtii+urIKBMKNCv kdqmSCCnGB7Ljne2oqnVvZpwyUL5Fg8Rln+ZYpZVe3umN14WjE/majXutLh5fuziq8yZ xf0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="B/V7puL/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g25si10096358edr.71.2019.10.01.12.41.57; Tue, 01 Oct 2019 12:42:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="B/V7puL/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726733AbfJATj0 (ORCPT + 99 others); Tue, 1 Oct 2019 15:39:26 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54440 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbfJATjZ (ORCPT ); Tue, 1 Oct 2019 15:39:25 -0400 Received: by mail-wm1-f67.google.com with SMTP id p7so4654387wmp.4; Tue, 01 Oct 2019 12:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ywb+nsfPF+Z3DCZgk+yF3jv1PIj9PSL8oPWXw4QNmes=; b=B/V7puL/nT3UONj3n3yunqqTShXwbzE/dZLJYxI+qcTTAuHYwnSyuPneVvUnf2pcPm jUJLV678kdpU6myJYnKqjKVwy0rAZqAIszBWcIJt8nXkudRU4VqGd/jzPjOaKFbZvev+ 73iY32BL7hiOYUUVXcohfmmUJulIAdlFLZk03HOTdBNDM4neBmRg4mSODSVsPgGkeazb bpCuX4oZ125uxg1cyanneLj0nHT5etHcaY09l+UHliqpWaVetLAZmAy5HDRbRmqzt56W /hpLRke/XvDKNPfOtDxjedp29FbuL8TEMYQMMFQeibXSQ/o/RnB8zxiIoZtm/cFMevd9 LiwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ywb+nsfPF+Z3DCZgk+yF3jv1PIj9PSL8oPWXw4QNmes=; b=o4m56y3e0DeottmlHRSv4cFEHkyPESBCbGT01IOl4yhJi3yoBLmS40LtdJcj5CogXh fb+6/xDXrLILeDHLuOTEH4U99rrF1SMWuHzJykLOQ05YwYcNDoUeJyX4ixX7/ukt38SP 8a7gD1VOG0OMWVrgfQgOld22HG75rDZBocfB092lmgyglLCjSpNMvM1YEpppaTuDqmqd nSO2AXRCi1NR1CEyf36DWvMyABG20l+2brCwfoCMMZCUea1k+OcPa/m2a9RLAqluIukS PHPydcD3mYrDo8VOwiz337gv30xf3eFjq0EujrbTWmJyfPRSz9Dr5AS3dUtHwvDqAgna D3hQ== X-Gm-Message-State: APjAAAU8l3BPg2bbcNmeSjxeXLxuggPtZrZ04sunQ9RDs2poBhAZlreG AU1iCtTaLDTRAvTv3eSSR7TEhbdo X-Received: by 2002:a1c:a853:: with SMTP id r80mr4951562wme.140.1569958762580; Tue, 01 Oct 2019 12:39:22 -0700 (PDT) Received: from [192.168.1.19] (bgt101.neoplus.adsl.tpnet.pl. [83.28.83.101]) by smtp.gmail.com with ESMTPSA id r9sm20653329wra.19.2019.10.01.12.39.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 12:39:22 -0700 (PDT) Subject: Re: [PATCH 5/5] leds: lm3601x: Convert class registration to device managed To: Dan Murphy , pavel@ucw.cz Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191001180439.8312-1-dmurphy@ti.com> <20191001180439.8312-5-dmurphy@ti.com> From: Jacek Anaszewski Openpgp: preference=signencrypt Autocrypt: addr=jacek.anaszewski@gmail.com; prefer-encrypt=mutual; keydata= mQINBFWjfaEBEADd66EQbd6yd8YjG0kbEDT2QIkx8C7BqMXR8AdmA1OMApbfSvEZFT1D/ECR eWFBS8XtApKQx1xAs1j5z70k3zebk2eeNs5ahxi6vM4Qh89vBM46biSKeeX5fLcv7asmGb/a FnHPAfQaKFyG/Bj9V+//ef67hpjJWR3s74C6LZCFLcbZM0z/wTH+baA5Jwcnqr4h/ygosvhP X3gkRzJLSFYekmEv+WHieeKXLrJdsUPUvPJTZtvi3ELUxHNOZwX2oRJStWpmL2QGMwPokRNQ 29GvnueQdQrIl2ylhul6TSrClMrKZqOajDFng7TLgvNfyVZE8WQwmrkTrdzBLfu3kScjE14Q Volq8OtQpTsw5570D4plVKh2ahlhrwXdneSot0STk9Dh1grEB/Jfw8dknvqkdjALUrrM45eF FM4FSMxIlNV8WxueHDss9vXRbCUxzGw37Ck9JWYo0EpcpcvwPf33yntYCbnt+RQRjv7vy3w5 osVwRR4hpbL/fWt1AnZ+RvbP4kYSptOCPQ+Pp1tCw16BOaPjtlqSTcrlD2fo2IbaB5D21SUa IsdZ/XkD+V2S9jCrN1yyK2iKgxtDoUkWiqlfRgH2Ep1tZtb4NLF/S0oCr7rNLO7WbqLZQh1q ShfZR16h7YW//1/NFwnyCVaG1CP/L/io719dPWgEd/sVSKT2TwARAQABtC1KYWNlayBBbmFz emV3c2tpIDxqYWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT6JAlgEEwEIAEICGwMHCwkIBwMC AQYVCAIJCgsDFgIBAh4BAheABQkJZgNMFiEEvx38ClaPBfeVdXCQvWpQHLeLfCYFAl05/9sC GQEACgkQvWpQHLeLfCarMQ/9FN/WqJdN2tf6xkP0RFyS4ft0sT04zkOCFfOMxs8mZ+KZoMU+ X3a+fEppDL7xgRFpHyGaEel7lSi1eqtzsqZ5JiHbDS1Ht1G8TtATb8q8id68qeSeW2mfzaLQ 98NPELGfUXFoUqUQkG5z2p92UrGF4Muj1vOIW93pwvE4uDpNsl+jriwHomLtjIUoZtIRjGfZ RCyUQI0vi5LYzXCebuzAjGD7Jh2YAp7fDGrv3qTq8sX+DUJ4H/+I8PiL+jXKkEeppqIhlBJJ l4WcgggMu3c2uljYDuqRYghte33BXyCPAocfO2/sN+yJRUTVuRFlOxUk4srz/W8SQDwOAwtK V7TzdyF1/jOGBxWwS13EjMb4u3XwPMzcPlEQNdIqz76NFmJ99xYEvgkAmFmRioxuBTRv8Fs1 c1jQ00WWJ5vezqY6lccdDroPalXWeFzfPjIhKbV3LAYTlqv0It75GW9+0TBhPqdTM15DrCVX B7Ues7UnD5FBtWwewTnwr+cu8te449VDMzN2I+a9YKJ1s6uZmzh5HnuKn6tAfGyQh8MujSOM lZrNHrRsIsLXOjeGVa84Qk/watEcOoyQ7d+YaVosU0OCZl0GldvbGp1z2u8cd2N/HJ7dAgFh Q7dtGXmdXpt2WKQvTvQXhIrCWVQErNYbDZDD2V0TZtlPBaZP4fkUDkvH+Sy5Ag0EVaN9oQEQ AMPNymBNoCWc13U6qOztXrIKBVsLGZXq/yOaR2n7gFbFACD0TU7XuH2UcnwvNR+uQFwSrRqa EczX2V6iIy2CITXKg5Yvg12yn09gTmafuoIyKoU16XvC3aZQQ2Bn3LO2sRP0j/NuMD9GlO37 pHCVRpI2DPxFE39TMm1PLbHnDG8+lZql+dpNwWw8dDaRgyXx2Le542CcTBT52VCeeWDtqd2M wOr4LioYlfGfAqmwcwucBdTEBUxklQaOR3VbJQx6ntI2oDOBlNGvjnVDzZe+iREd5l40l+Oj TaiWvBGXkv6OI+wx5TFPp+BM6ATU+6UzFRTUWbj+LqVA/JMqYHQp04Y4H5GtjbHCa8abRvBw IKEvpwTyWZlfXPtp8gRlNmxYn6gQlTyEZAWodXwE7CE+KxNnq7bPHeLvrSn8bLNK682PoTGr 0Y00bguYLfyvEwuDYek1/h9YSXtHaCR3CEj4LU1B561G1j7FVaeYbX9bKBAoy/GxAW8J5O1n mmw7FnkSHuwO/QDe0COoO0QZ620Cf9IBWYHW4m2M2yh5981lUaiMcNM2kPgsJFYloFo2XGn6 lWU9BrWjEoNDhHZtF+yaPEuwjZo6x/3E2Tu3E5Jj0VpVcE9U1Zq/fquDY79l2RJn5ENogOs5 +Pi0GjVpEYQVWfm0PTCxNPOzOzGR4QB3BNFvABEBAAGJAiUEGAEIAA8FAlWjfaECGwwFCQlm AYAACgkQvWpQHLeLfCZqGxAAlWBWVvjU6xj70GwengiqYZwmW1i8gfS4TNibQT/KRq0zkBnE wgKwXRbVoW38pYVuGa5x/JDQMJDrLAJ0wrCOS3XxbSHCWOl/k2ZD9OaxUeXq6N+OmGTzfrYv PUvWS1Hy04q9AD1dIaMNruZQmvnRfkOk2UDncDIg0166/NTHiYI09H5mpWGpHn/2aT6dmpVw uoM9/rHlF5s5qAAo95tZ0QW2BtIceG9/rbYlL57waSMPF49awvwLQX5RhWoF8mPS5LsBrXXK hmizIsn40tLbi2RtWjzDWgZYitqmmqijeCnDvISN4qJ/nCLO4DjiSGs59w5HR+l0nwePDhOC A4RYZqS1e2Clx1VSkDXFpL3egabcIsqK7CZ6a21r8lXVpo4RnMlQsmXZTnRx4SajFvX7PrRg /02C811fLfh2r5O5if8sKQ6BKKlHpuuioqfj/w9z3B0aQ71e4n1zNJBO1kcdznikPLAbr7jG gkBUXT1yJiwpTfRQr5y2Uo12IJsKxohnNFVYtK8X/R6S0deKPjrZWvAkllgIPcHjMi2Va8yw KTj/JgcpUO5KN906Pf7ywZISe7Kbcc/qnE0YjPPSqFOvoeZvHe6EZCMW9+xZsaipvlqpByQV UHnVg09K9YFvjUBsBPdC8ef6YwgfR9o6AnPmxl0oMUIXkCCC5c99fzJY/k+JAq0EGAEIACAW IQS/HfwKVo8F95V1cJC9alAct4t8JgUCWwqKhgIbAgCBCRC9alAct4t8JnYgBBkWCAAdFiEE FMMcSshOZf56bfAEYhBsURv0pdsFAlsKioYACgkQYhBsURv0pdvELgD/U+y3/hsz0bIjMQJY 0LLxM/rFY9Vz1L43+lQHXjL3MPsA/1lNm5sailsY7aFBVJxAzTa8ZAGWBdVaGo6KCvimDB8G 7joP/jx+oGOmdRogs7mG//H+w9DTnBfPpnfkeiiokGYo/+huWO5V0Ac9tTqZeFc//t/YuYJn wWvS0Rx+KL0fT3eh9BQo47uF4yDiZIiWLNh4Agpup1MUSVsz4MjD0lW6ghtnLcGlIgoVHW0v tPW1m9jATYyJSOG/MC1iDrcYcp9uVYn5tKfkEeQNspuG6iSfS0q3tajPKnT1nJxMTxVOD2RW EIGfaV9Scrou92VD/eC+/8INRsiWS93j3hOKIAV5XRNINFqtzkagPYAP8r6wksjSjh01fSTB p5zxjfsIwWDDzDrqgzwv83CvrLXRV3OlG1DNUDYA52qJr47paH5QMWmHW5TNuoBX8qb6RW/H M3DzPgT+l+r1pPjMPfvL1t7civZUoPuNzoyFpQRj6TvWi2bGGMQKryeYksXG2zi2+avMFnLe lOxGdUZ7jn1SJ6Abba5WL3VrXCP+TUE6bZLgfw8kYa8QSXP3ysyeMI0topHFntBZ8a0KXBNs qqFCBWmTHXfwsfW0VgBmRtPO7eXVBybjJ1VXKR2RZxwSq/GoNXh/yrRXQxbcpZ+QP3/Tttsb FdKciZ4u3ts+5UwYra0BRuvb51RiZR2wRNnUeBnXWagJVTlG7RHBO/2jJOE6wrcdCMjs0Iiw PNWmiVoZA930TvHA5UeGENxdGqo2MvMdRJ54YaIR Message-ID: <66354452-f6f9-416d-0955-63914cb32746@gmail.com> Date: Tue, 1 Oct 2019 21:39:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191001180439.8312-5-dmurphy@ti.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, Thank you for the patch. On 10/1/19 8:04 PM, Dan Murphy wrote: > Convert LED flash class registration to device managed class > registration API. > > Signed-off-by: Dan Murphy > --- > drivers/leds/leds-lm3601x.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/leds/leds-lm3601x.c b/drivers/leds/leds-lm3601x.c > index b02972f1a341..a68e4f97739c 100644 > --- a/drivers/leds/leds-lm3601x.c > +++ b/drivers/leds/leds-lm3601x.c > @@ -350,8 +350,7 @@ static int lm3601x_register_leds(struct lm3601x_led *led, > init_data.devicename = led->client->name; > init_data.default_label = (led->led_mode == LM3601X_LED_TORCH) ? > "torch" : "infrared"; > - > - return led_classdev_flash_register_ext(&led->client->dev, > + return devm_led_classdev_flash_register_ext(&led->client->dev, > &led->fled_cdev, &init_data); You need to remove led_classdev_flash_unregister(&led->fled_cdev) from lm3601x_remove() to complete this improvement. -- Best regards, Jacek Anaszewski