Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp418887ybn; Tue, 1 Oct 2019 23:46:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqzkD3bC+Eoer1fFnUIp13gIsTKq88nrXGmBguoRc6TEpBaIpMliRLV2cjgE3thpISjepoZQ X-Received: by 2002:aa7:cb46:: with SMTP id w6mr2250181edt.238.1569998789397; Tue, 01 Oct 2019 23:46:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569998789; cv=none; d=google.com; s=arc-20160816; b=VlCeGwNhZ8kk1dCVHlx7SJptrO8VwHFQ5MXzaU4hGjdfhNxlXgRItBJjgzhSZfjM3t p5O8dOXtdlIrya5LVbovDY3ASxXD0cyMHJgIFgUirTI9vAogyYP4FYQeC98tmovX6/nK EVaQ9wyVxhWmCQV/HuKwnRuSxG9RQOK00NzbDmWj7OLvIoE/5bGKxWtCxBDjBmHOZWyB Dh66PBsKHMU8V7jljFdO/2EAZM0P2ilYc9eyq+IfATE2ukKlWczgiyLPx9J1nkirsqPw LNGt/kDf2GUOGvFINx/NUUMcmUPb1m/MeGx3kaDPMo0ca9kM8F9w/3bdVY9ooAyIuenL p0WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-transfer-encoding :content-disposition:mime-version:message-id:subject:cc:to:from:date :dkim-signature; bh=swe25t+lxOEruvSVv2ts6lHoxHEk7rNBAWMV8cWmjOc=; b=xC+lKPWhi1l0PITSfshYDgzn97UOYE9Dt3bJ/bEuyhkNnYWksd7zEvvUwib4B4ux+k +l8S6l3O5jMjkY2eVsU4IejDNo4zG5IK+EfLgqTiExNaE0DRb0IRZ9T/+3mPaS51S7TJ O2iSSkMEp+H8FAPpIAGASNUiXfAJRqDTsU8anNn+atARfZAEvV7TMwZEv21UqoZl5rUV TxY3U51b4ac5eJCMrDRn5YvNWMptqqG2cawxFeoLOrLpO/VWc9NRaOYca9dEzYmnatw7 Kum6qQmK9yy0m+XlnKOL0jaGYSnKgAcfN1PyWTqc7eRv89gvoWjUNPzJ2JF7nmXsxMFZ tMNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HBqzpDZY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k1si10066898ejj.174.2019.10.01.23.46.05; Tue, 01 Oct 2019 23:46:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HBqzpDZY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726902AbfJBFSG (ORCPT + 99 others); Wed, 2 Oct 2019 01:18:06 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33350 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbfJBFSG (ORCPT ); Wed, 2 Oct 2019 01:18:06 -0400 Received: by mail-pf1-f193.google.com with SMTP id q10so9717272pfl.0 for ; Tue, 01 Oct 2019 22:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:user-agent; bh=swe25t+lxOEruvSVv2ts6lHoxHEk7rNBAWMV8cWmjOc=; b=HBqzpDZYcZjgpRunc6y7IF170eXNXKl5Ah2zEIFOrmB+v84x5h9heqxCGMrLY14bPA p9LLfOakNoGxZKVJdj/F+/ZAtyw/IwcdRW5HT8dslzClmxCXnuDQhXjEILUiw9Z6x+ea ucuoSHQ/xGLko3fbtGk9BWC6e103EHwk14EPFI+57U8jFYqa/8D8INeK6FW39VAm0D9G D3osVnpOVbveO4DQmS7dpi4oo1v3PtYls+unfAKKYwqP+yj2P7v9QXpThYoTVhi/WFdW na2seGZoK0FH0+i5rPn4EKewzrUgJ9e9b31mau6rSixIaPFVzAkMB2MiUQtsS/gqB6PO /kvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:user-agent; bh=swe25t+lxOEruvSVv2ts6lHoxHEk7rNBAWMV8cWmjOc=; b=U2DA28Wh5yjVXDQy1NGXkn/MArQKI9EUggq34i5gHcwSYbIDYdqm/zlmeCLgf3M9T/ Xhl8O5Mb37taX2pxrR4s3S/Nbv1psbRrlEMDCQdG0MX58jTZDcQC4y5fwJlzzbkyWGVY 3T5MKzgzB8gjxnFSTVki5mFEoMF2mh/BW1WcPaLN15je4y7G5dpiFGexRQ6crovxbgX5 Ttg909q8R7deEYt+oBLStxHfAAGZuKUWvtfePcdDyXcZApGysyaA8lqVxjAdF1T4IKET v4HPRxD0f6xS73A+e2o7om4njxvnDXZgQ3Bzxk46tK5OCuwlU/a83aAH4VxESYgqrUdl wOFw== X-Gm-Message-State: APjAAAW3gxObm71SQVXMCSsjeDLMeUVp+KVM+dKOprdvK8HYc8Q70ZhG QIW1ybp2TkFVYQGVK3WL6PMVgh4pgJhv8Q== X-Received: by 2002:aa7:81cb:: with SMTP id c11mr2438922pfn.251.1569993485244; Tue, 01 Oct 2019 22:18:05 -0700 (PDT) Received: from LGEARND20B15 ([27.122.242.75]) by smtp.gmail.com with ESMTPSA id z13sm18228362pfg.172.2019.10.01.22.18.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Oct 2019 22:18:04 -0700 (PDT) Date: Wed, 2 Oct 2019 14:17:59 +0900 From: Austin Kim To: alexander.deucher@amd.com, evan.quan@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, airlied@linux.ie, daniel@ffwll.ch Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, austindh.kim@gmail.com Subject: [PATCH] drm/amdgpu: Drop unused variable and statement Message-ID: <20191002051759.GA161133@LGEARND20B15> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Even though 'smu8_smu' is declared, it is not used after below statement. smu8_smu = hwmgr->smu_backend; So 'unused variable' could be safely removed to stop warning message as below: drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu8_smumgr.c:180:22: warning: variable ‘smu8_smu’ set but not used [-Wunused-but-set-variable] struct smu8_smumgr *smu8_smu; ^ Signed-off-by: Austin Kim --- drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c index 4728aa2..7dca04a 100644 --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c @@ -177,12 +177,10 @@ static int smu8_load_mec_firmware(struct pp_hwmgr *hwmgr) uint32_t tmp; int ret = 0; struct cgs_firmware_info info = {0}; - struct smu8_smumgr *smu8_smu; if (hwmgr == NULL || hwmgr->device == NULL) return -EINVAL; - smu8_smu = hwmgr->smu_backend; ret = cgs_get_firmware_info(hwmgr->device, CGS_UCODE_ID_CP_MEC, &info); -- 2.6.2