Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp421807ybn; Tue, 1 Oct 2019 23:50:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqzHwGf281EU5UEYhBeItrEyZMIih9mP1kO9BGQLUMhsY+oyCpWHAA2uRS4/9gBH3TBCjYWj X-Received: by 2002:aa7:c743:: with SMTP id c3mr2137685eds.241.1569999013500; Tue, 01 Oct 2019 23:50:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569999013; cv=none; d=google.com; s=arc-20160816; b=apBMc/6CbRNh/dhwOqo++toVmd5wAC9JH1bElaUiuhRvWzhaSFwOMKaji+yx2QETYN osO/7faG4LVsLheDEPFtwcqTWx5wu12QGWCG8nAPEI2zcXKc/2UMjH9DTLPlM4n+usa1 7E3b/rxWSuGISNO/1uoR/HRPZ75spBkglvxKIqd9NRqqM2OZWnromAQnDumCgcfVOBLV qvGMgTi46VU8qIt+vwGxANtQ9JEzdv7iSkT/W/gb0np3MEuE+RmxzQ8JgxPCjYCvkeTU DQfvDa/nnvLlB6y5B0M80uyrbnnvRkVFbdO7SR3x8/EDMChTTXzFDtWoo/ej93GHX5YE K3mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=5AcZEITR50EqYwQF+Thz3U0N2SH4PgzQ+ow4rmj91Wg=; b=skZFe2d8eeTslkdirBMFJy8xUvrr4H+2gO1ItN6G9bdLn6hAV8BdCZ0pK5DNOd4g0E BP7fSXPmIWqyMY+9XJFiLZ4Y5i0MNQZMsFMsT1aMnRdB+hWXmWlT9WnnOku6cxQp7XrN u4C2l9J7hO163owD74du+Q5kZGv8YXz9b5QrbclBUmrHTJ9qx8gccU8EhzaVSjvp2xYm 3VHhAZ38vET6rZjcvCTz4PqS0p012MY8JR9im1cg73zKeo16GcAitIMSlmeuHpX6jtR2 /do+zr9+XrE+yAqU/+sIF/z/cq+8k+GyH/7U2f2XKNF6Lx4fbvbi1AwCTxkq86oYmy/g bUvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ysoft.com header.s=20160406-ysoft-com header.b=lsWbrPuL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=ysoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i5si11783282edj.107.2019.10.01.23.49.49; Tue, 01 Oct 2019 23:50:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ysoft.com header.s=20160406-ysoft-com header.b=lsWbrPuL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=ysoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727156AbfJBFcp (ORCPT + 99 others); Wed, 2 Oct 2019 01:32:45 -0400 Received: from uho.ysoft.cz ([81.19.3.130]:60034 "EHLO uho.ysoft.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727073AbfJBFco (ORCPT ); Wed, 2 Oct 2019 01:32:44 -0400 Received: from [10.1.8.111] (unknown [10.1.8.111]) by uho.ysoft.cz (Postfix) with ESMTP id 5B75DA211B; Wed, 2 Oct 2019 07:32:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=20160406-ysoft-com; t=1569994362; bh=5AcZEITR50EqYwQF+Thz3U0N2SH4PgzQ+ow4rmj91Wg=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=lsWbrPuLkR+N3vdIIaYAxfZVN32AeZZgTP8UbRtHXtoBUrJgnFuYMEy2S9OUTso8T 1z4bXsDQH6i4vGDDSf7ezji3fpLHRJtCjO4fOXpEYRDdFnBj6poSxwYp8A+Tws6ygP hQoYmypLsF0vX47CW19QH+//T2ypw15vsac5cLuo= Subject: Re: [PATCH] input: touchscreen: imx6ul_tsc: Use 'dev' instead of dereferencing it repeatedly To: Dmitry Torokhov , Anson Huang Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, swboyd@chromium.org, mojha@codeaurora.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com References: <1569315731-2387-1-git-send-email-Anson.Huang@nxp.com> <20190930230806.GX237523@dtor-ws> From: =?UTF-8?B?TWljaGFsIFZva8OhxI0=?= Message-ID: Date: Wed, 2 Oct 2019 07:32:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190930230806.GX237523@dtor-ws> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01. 10. 19 1:08, Dmitry Torokhov wrote: > On Tue, Sep 24, 2019 at 05:02:11PM +0800, Anson Huang wrote: >> Add helper variable dev = &pdev->dev to simply the code. > > Do we get any code savings from this? I noticed Anson submitted similar patches into various other subsystems. Here [1] is a very detailed response from David Laight shedding some light on this topic. [1] https://lkml.org/lkml/2019/9/24/151 >> >> Signed-off-by: Anson Huang >> --- >> drivers/input/touchscreen/imx6ul_tsc.c | 37 +++++++++++++++++----------------- >> 1 file changed, 19 insertions(+), 18 deletions(-)