Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp438246ybn; Wed, 2 Oct 2019 00:09:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpAuxQR+aLlIGuZQkK3MlbGXi9XTRtXYddqKFD0q+8K9GbAQPPaVfpemn1zPj+O1tm31Oz X-Received: by 2002:a17:906:82d3:: with SMTP id a19mr1701008ejy.151.1570000141012; Wed, 02 Oct 2019 00:09:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570000141; cv=none; d=google.com; s=arc-20160816; b=swFFjJQqLNSjzVG6ZsVQqRR+NNEKV/1/lGZZdEaaSK4JULPosryqVvNoQcqP6vg5sY dtYCavihqcMnD6s8BmILH1PjlQ+9++tutmsSXVewTCg6B37p09QlxLYIat3Ia2tBOHgf vNFvyvDXG6uYXX8dCp8K422U0t8FGhyMpXFHXzX/+oz0oIbk5LMBostMCSwYOlcVCB10 rUU2GC6JrCt8EoniQyvTXy3DHeq0aPgCCxWmEf88f+6tXj0kUB4sa6I3r+uGzMZrqSEY giXVVRxgzu8EAb5eLzouBFFO+qR6i3mPEwwxgivP5alMCOZdAzZKjxU8s5DXLVZ3rMei +XTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=TTszmpSpMPlVv5NO5j52vopWvFhJ/hDvGIs1sInZeE0=; b=i2/0/Mc8iGXetsVTkaxq8Zc3s8C++gieK7QbLWY6Pc2hM4rA6O43BmZU2hWt84GwCs kC3H48cD4cNwQE9eW5Kj7CIRaDyKXWDQxNVLhUgdZVRT2zu9qwP59i6kzM4Nc6YMipa4 +D42h2FeFtYNK5E3t/Ee11ykNK13y8Lkk+biTKLAtto7rVTcJEN0BT34tKwgg7rExCpA /H27bNjLuIy2rzCZ9IFVoPf7mG3RPVUW6RGmy3Wlmvq/nXPYOYCYzM/iq6BM71acXdZm LUHRi/5lTQnSDN/cmsh8beXtqD37I0vrBuyea4id4kGySqezhEW7SwjD5av+zsW1M9uf r29g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WNwU+kt9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v31si10797558edm.402.2019.10.02.00.08.37; Wed, 02 Oct 2019 00:09:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WNwU+kt9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726138AbfJBG2Z (ORCPT + 99 others); Wed, 2 Oct 2019 02:28:25 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:41233 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfJBG2Z (ORCPT ); Wed, 2 Oct 2019 02:28:25 -0400 Received: by mail-lf1-f68.google.com with SMTP id r2so11766335lfn.8 for ; Tue, 01 Oct 2019 23:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TTszmpSpMPlVv5NO5j52vopWvFhJ/hDvGIs1sInZeE0=; b=WNwU+kt9M0gQO+bZUFeCQ2Uy2rYvSmCZlOXfGwcN9Ken31ATJxZchpQslOXJXpvCp/ m/1ISDxuTA5dgvkKN8PAmHX0P7+EMq52GMV/QjsKpuIAsIuYlPhRXylBNiZ3DJswaVqY ZhXagFuEmGNISZGuRh0PlQlNSgkd2XLcnf5ETgfm/wviUq+MaFZ9ee/WxFEKmde/jfsc imQSWngBTadQ0kAhR38khptmuHTo7QdUiI59o2l7rI5kF/HJjxz2eX8EoGxx2Z1sU3lY JFMkx4eZS44bE14qZGWpCnBpOyMk5QFzC4dMEFZsDDqt4SNSQ3Ju4nYtt/NPXQRVuupp s1pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TTszmpSpMPlVv5NO5j52vopWvFhJ/hDvGIs1sInZeE0=; b=q01K0CjGNv56HVtUrbPEGLnPSBIiMM5pkqzPL5cZ26/tSYx8Xumb05wgkZqf6cULIq yIqqSJnlsvYVRe9qOmxexfxf7BNsR1ghbFwYe3AOT6kj4FenycDK2/WTBngVygYBZ638 Rz9rGWMATiO8i48BAbMZSnqqixQUkAAeOabIo8IHVTsNN+/ng396H87XGQ5MuJtD4aKq rKl63NiWCMPnYRWo9fcACyO5LmYS7ocuO4Irjj0Lk7redAUGm3IOpM1D0r3weeJzJfeo qLTYfwYdsRCWbVadBC1WyGQV7rPiJvtvWjp35n6+1MPokOtGMLWUIkiYw4WO7m0zmwFK iTyQ== X-Gm-Message-State: APjAAAWM6qaSvXo2iZYerTr0WwCjPYs5xJkaTdnjBDA6K6q0yR3TihNf iZAhWIINF5Hdp8dMB7LQcasTiPd+gF/7nq9Cuh5TNw== X-Received: by 2002:ac2:554e:: with SMTP id l14mr1208452lfk.32.1569997703468; Tue, 01 Oct 2019 23:28:23 -0700 (PDT) MIME-Version: 1.0 References: <1568878421-12301-1-git-send-email-vincent.guittot@linaro.org> <1568878421-12301-4-git-send-email-vincent.guittot@linaro.org> In-Reply-To: From: Vincent Guittot Date: Wed, 2 Oct 2019 08:28:11 +0200 Message-ID: Subject: Re: [PATCH v3 03/10] sched/fair: remove meaningless imbalance calculation To: Valentin Schneider Cc: linux-kernel , Ingo Molnar , Peter Zijlstra , Phil Auld , Srikar Dronamraju , Quentin Perret , Dietmar Eggemann , Morten Rasmussen , Hillf Danton Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Oct 2019 at 19:12, Valentin Schneider wrote: > > On 19/09/2019 08:33, Vincent Guittot wrote: > > clean up load_balance and remove meaningless calculation and fields before > > adding new algorithm. > > > > Signed-off-by: Vincent Guittot > > We'll probably want to squash the removal of fix_small_imbalance() in the > actual rework (patch 04) to not make this a regression bisect honeypot. Yes that's the plan. Peter asked to split the patch to ease the review > Other than that: > > Reviewed-by: Valentin Schneider