Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 02 Oct 2019 09:13:04 +0200
Message-ID: <20191002091304.Horde.44CFpqD3KN1HHZOT0U8wSQ7@messagerie.si.c-s.fr>
From:   Christophe Leroy <christophe.leroy@c-s.fr>
To:     Daniel Axtens <dja@axtens.net>
Cc:     gor@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
        dvyukov@google.com, mark.rutland@arm.com,
        linux-kernel@vger.kernel.org, luto@kernel.org, glider@google.com,
        aryabinin@virtuozzo.com, x86@kernel.org, linux-mm@kvack.org,
        kasan-dev@googlegroups.com, Uladzislau Rezki <urezki@gmail.com>
Subject: Re: [PATCH v8 1/5] kasan: support backing vmalloc space with real
 shadow memory
References: <20191001065834.8880-1-dja@axtens.net>
 <20191001065834.8880-2-dja@axtens.net> <20191001101707.GA21929@pc636>
 <87zhik2b5x.fsf@dja-thinkpad.axtens.net>
In-Reply-To: <87zhik2b5x.fsf@dja-thinkpad.axtens.net>
User-Agent: Internet Messaging Program (IMP) H5 (6.2.3)
Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes
MIME-Version: 1.0
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Daniel Axtens <dja@axtens.net> a écrit :

> Hi,
>
>>>  	/*
>>>  	 * Find a place in the tree where VA potentially will be
>>>  	 * inserted, unless it is merged with its sibling/siblings.
>>> @@ -741,6 +752,10 @@ merge_or_add_vmap_area(struct vmap_area *va,
>>>  		if (sibling->va_end == va->va_start) {
>>>  			sibling->va_end = va->va_end;
>>>
>>> +			kasan_release_vmalloc(orig_start, orig_end,
>>> +					      sibling->va_start,
>>> +					      sibling->va_end);
>>> +
>> The same.
>
> The call to kasan_release_vmalloc() is a static inline no-op if
> CONFIG_KASAN_VMALLOC is not defined, which I thought was the preferred
> way to do things rather than sprinkling the code with ifdefs?
>
> The complier should be smart enough to eliminate all the
> orig_state/orig_end stuff at compile time because it can see that it's
> not used, so there's no cost in the binary.
>


Daniel,

You are entirely right in your way to do i, that's fully in line with  
Linux kernel codying style  
https://www.kernel.org/doc/html/latest/process/coding-style.html#conditional-compilation

Christophe