Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp534212ybn; Wed, 2 Oct 2019 02:03:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqy4QTN3YgjVj1LJOoNUvHulrlw1wZ31f1Mr9BlJCJspRZi6rQCc8+lsAabcDU6uGpfc6wU6 X-Received: by 2002:aa7:dc4b:: with SMTP id g11mr2623124edu.70.1570007021101; Wed, 02 Oct 2019 02:03:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570007021; cv=none; d=google.com; s=arc-20160816; b=hJpSfpcznWNz0A9nX8gRgQMcOarl7wMhYLUT7GktLZo4Om7O/xRKigPC7dOVRWpbAA P8xNNb9i22W79H0Fam038dcicnaY2tjE+ZL3ABpN6gcVnm+ToKasrpHuCCXa8fmyFG+P wdbJGnM2jWQ+2iKyfME6ufGuEXzkCZTRbQXCdVIWYo6XXRZq2Lp7JCGxrfTraAB6Sbkr OWVykQ8NN2F6gq2hsPwq3aiO7xF1QUC6p2dBkacB5KK9LE9APW7W5o2+BMseuYMdHHfV kxsC0lRAe6t8z8rv8sBTAft4ZCn37SScJsZZ5zUVS8TyojNlLNH30/U95RdmY222FrYc OI3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=h1uYJR5smr90y2B3nzOAlW8s7WIFeZI1eKydk2jcP/0=; b=BT19EU9ozOItLCLHxE1LxJomOaW2VTdW2u9hsahJiUv0Vy+kkdYSuYuoyr+N9PfaaG V9KEtjgvOi4NCSRUl6/qMElqALzvgwJgvSxph3XE8UZZkaH8W7yuMwUa24+j+Sjisiwo 4Ew1AJUtRLSOWlm69I0aKfs1fPhFuhp82UtIwL6a4ywM/CDB/8iB6Vn41fhvs3QM6c7f ZIn4A//z2mRms8IjcQCx3fsdHgO0J+YRhRYXt2w5YOMEYEUh1wFnOkXx9peayKEIiqqO iMj9ZifHIIIbh10fgI3D2696lzYPOaGxhsvkbU5yYZhPg2gn5ZIYmyfYOX0aMZYKYrG5 1y0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5si11936257ede.126.2019.10.02.02.03.17; Wed, 02 Oct 2019 02:03:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727283AbfJBI4C (ORCPT + 99 others); Wed, 2 Oct 2019 04:56:02 -0400 Received: from mx2.suse.de ([195.135.220.15]:47214 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726672AbfJBI4A (ORCPT ); Wed, 2 Oct 2019 04:56:00 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B2104ABF4; Wed, 2 Oct 2019 08:55:57 +0000 (UTC) Date: Wed, 2 Oct 2019 10:55:54 +0200 From: Petr Mladek To: Linus Torvalds Cc: Kefeng Wang , Arnd Bergmann , Andy Whitcroft , "David S. Miller" , Sergey Senozhatsky , Peter Zijlstra , Daniel Borkmann , AlexeiStarovoitov , Andrew Morton , GregKroah-Hartman , Joe Perches , Arnaldo Carvalho de Melo , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/32] Kill pr_warning in the whole linux code Message-ID: <20191002085554.ddvx6yx6nx7tdeey@pathway.suse.cz> References: <20190920062544.180997-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190920062544.180997-1-wangkefeng.wang@huawei.com> User-Agent: NeoMutt/20170912 (1.9.0) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus, On Fri 2019-09-20 14:25:12, Kefeng Wang wrote: > There are pr_warning and pr_warng to show WARNING level message, > most of the code using pr_warn, number based on next-20190919, > > pr_warn: 5189 pr_warning: 546 (tools: 398, others: 148) The ratio is 10:1 in favor of pr_warn(). It would make sense to remove the pr_warning(). Would you accept pull request with these 32 simple patches for rc2, please? Alternative is to run a simple sed. But it is not trivial to fix indentation of the related lines. Best Regards, Petr