Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp714409ybn; Wed, 2 Oct 2019 05:09:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqyOkj6dwcZ92jCGipEaEiXuUsaN+KjS+4DicSsO5xviOg1772J7fOUAPWUIXTeRW4hcda2s X-Received: by 2002:a50:baab:: with SMTP id x40mr3436823ede.60.1570018177622; Wed, 02 Oct 2019 05:09:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570018177; cv=none; d=google.com; s=arc-20160816; b=UrNfLVwCvF4RNQLRxy1+q3VTX5Nv+UfqVJOdyAzCNyf0HHkN8Y1fN5OwC6f7WGXZau UDFYzHfkor2RS4Wyyb8IF4zGfF9HZjTungU0dROVIiK80qdHmL9WGqgs/xLKp1zeU4oo GTyfWlXQwoC1lPge50QLi/Ay+yHpdcL8YQaCLpYDSfHoJ4h1W54Fn4D26yz0yNVYGG3D fUoKAq6xE2em3WmxeKjLIcTagpjhLgigwE8tb6IAfNqyFjGMdSaT1IIPnnprtb8KvPQb zmq5oFYgIjyyWpydF0BiTS6WOjOq9FiFdOC3MUeoaYV0eI2j5FJJppP1wWOLOpnI3d5/ I69A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OTtxUEjlO9HcUPpiugCSBkopkvyXz2JCDw8OEY6QwX8=; b=oGxQtJPDAs1dlb1IPCuW75gmjX5w59plnZqRXjq03dxiYpyEJVK/ies40pBu7XgBM7 gRs68z35Pc13eu3YWd8EJbtcfcBs8k0PyLh4EjCStwp4MHQi3AprJrhRyk0dfeikmCiy B1QpUjo9CkC/TvABlR9Au9vDn9zeMQCx1fS3jTuMmml85FytSbmWNHvaEc4gt5gFepTX 9uiHGW1IVuAObr+U0SOlVQvKMCU88xEy65KmVeInctQN8myRsqc5Qezej2MILXASCSfE 3sGXHQkPzeNAIjYC24pI677UceGYfJVNhW3msFqO7DW1yxS7pmgvJF4Oe1d2oEsYiHr7 M+Rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Dop77VND; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x8si12617358edd.282.2019.10.02.05.09.13; Wed, 02 Oct 2019 05:09:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Dop77VND; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727961AbfJBKgq (ORCPT + 99 others); Wed, 2 Oct 2019 06:36:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:58968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbfJBKgp (ORCPT ); Wed, 2 Oct 2019 06:36:45 -0400 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8DBAC218DE; Wed, 2 Oct 2019 10:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570012605; bh=OTtxUEjlO9HcUPpiugCSBkopkvyXz2JCDw8OEY6QwX8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dop77VND9yEdv1ixP06TuVIV/36nU/gRS6iesokjS2CL7ZPgJdrbgDpvt2Aoxzgu2 d5u137d5vOTMdKWAjM2hICqZFYPs7zzfRGPDLEKyrpW0K9Z2k28AGKCwWGyw0Bwo42 t1VdFm3KNA9hZoIoMuUDxnLyR/+3oztIWtrtXmsE= Date: Wed, 2 Oct 2019 12:36:42 +0200 From: Maxime Ripard To: Icenowy Zheng Cc: Chen-Yu Tsai , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH 0/3] drm/sun4i: dsi: misc timing fixes Message-ID: <20191002103642.jlbs44v4kwnxhrge@gilmour> References: <20191001080253.6135-1-icenowy@aosc.io> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6keczcenlhnwont6" Content-Disposition: inline In-Reply-To: <20191001080253.6135-1-icenowy@aosc.io> User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6keczcenlhnwont6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Tue, Oct 01, 2019 at 04:02:50PM +0800, Icenowy Zheng wrote: > This patchset fixes some portion of timing calculation in sun6i_mipi_dsi > driver according to the BSP driver. > > Two of the patches are reverting, one is fixing some misread of the BSP > source code, another is fixing a wrong refactor that actually breaks the > formula. > > The other non-reverting patch is fixing a porch error which is usually > seen in the original driver commit. Most of porch errors are then fixed, > but this one gets ignored. > > By applying these patches, several DSI panels are tested to be driven > properly by the timing provided by the vendor, including the LCD panel > of PinePhone "Don't Be Evil" DevKit, the final PinePhone panel and the > panel on PineTab. Without these patches they need dirty timing hacks to > work. Thanks for going after that issue. Can you provide references to the BSP on the various patches? Ideally, having the panel drivers, and the panel datasheet would help. Thanks! Maxime PS: where can we get one of those devices? --6keczcenlhnwont6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXZR9ugAKCRDj7w1vZxhR xY0/AQC5eQr1MF2JwZuR7J6/60HoAsW6kKoOVaBBWurj6iMNTAD+JwOOdlDSQqrT fievw3+uVVe3O0xnWQxGHYInw9LB6g4= =q4a2 -----END PGP SIGNATURE----- --6keczcenlhnwont6--