Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191002051759.GA161133@LGEARND20B15>
In-Reply-To: <20191002051759.GA161133@LGEARND20B15>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Wed, 2 Oct 2019 09:39:28 -0400
Message-ID: <CADnq5_OsUSP0OXWfB4=XfLuHmDMtPDyWY7EwbMPGEbz3+mi=SQ@mail.gmail.com>
Subject: Re: [PATCH] drm/amdgpu: Drop unused variable and statement
To:     Austin Kim <austindh.kim@gmail.com>
Cc:     "Deucher, Alexander" <alexander.deucher@amd.com>,
        "Quan, Evan" <evan.quan@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        Chunming Zhou <David1.Zhou@amd.com>,
        Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Oct 2, 2019 at 3:19 AM Austin Kim <austindh.kim@gmail.com> wrote:
>
> Even though 'smu8_smu' is declared, it is not used after below statement.
>
>    smu8_smu =3D hwmgr->smu_backend;
>
> So 'unused variable' could be safely removed
> to stop warning message as below:
>
>    drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu8_smumgr.c:180:22:
>    warning: variable =E2=80=98smu8_smu=E2=80=99 set but not used
>    [-Wunused-but-set-variable]
>
>    struct smu8_smumgr *smu8_smu;
>              ^
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c b/drivers=
/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c
> index 4728aa2..7dca04a 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu8_smumgr.c
> @@ -177,12 +177,10 @@ static int smu8_load_mec_firmware(struct pp_hwmgr *=
hwmgr)
>         uint32_t tmp;
>         int ret =3D 0;
>         struct cgs_firmware_info info =3D {0};
> -       struct smu8_smumgr *smu8_smu;
>
>         if (hwmgr =3D=3D NULL || hwmgr->device =3D=3D NULL)
>                 return -EINVAL;
>
> -       smu8_smu =3D hwmgr->smu_backend;
>         ret =3D cgs_get_firmware_info(hwmgr->device,
>                                                 CGS_UCODE_ID_CP_MEC, &inf=
o);
>
> --
> 2.6.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx