Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v7 1/5] leds: populate the device's of_node when possible
To:     Jacek Anaszewski <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
        <robh+dt@kernel.org>, <mark.rutland@arm.com>,
        <lee.jones@linaro.org>, <daniel.thompson@linaro.org>
CC:     <dmurphy@ti.com>, <linux-leds@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        <tomi.valkeinen@ti.com>
References: <20190918145730.22805-1-jjhiblot@ti.com>
 <20190918145730.22805-2-jjhiblot@ti.com>
 <f543e757-e000-6de4-694b-e75f388e5908@gmail.com>
From:   Jean-Jacques Hiblot <jjhiblot@ti.com>
Message-ID: <e9588e03-20d4-7e6d-e514-0b79dae12cce@ti.com>
Date:   Wed, 2 Oct 2019 15:58:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <f543e757-e000-6de4-694b-e75f388e5908@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jacek,

On 24/09/2019 23:03, Jacek Anaszewski wrote:
> Hi Jean,
>
> Thank you for rebasing the set
>
> On 9/18/19 4:57 PM, Jean-Jacques Hiblot wrote:
>> If initialization data is available and its fwnode is actually a of_node,
>> store this information in the led device's structure. This will allow the
>> device to use or provide OF-based API such (devm_xxx).
>>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>> ---
>>   drivers/leds/led-class.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
>> index 647b1263c579..c2167b66b61f 100644
>> --- a/drivers/leds/led-class.c
>> +++ b/drivers/leds/led-class.c
>> @@ -276,8 +276,11 @@ int led_classdev_register_ext(struct device *parent,
>>   		mutex_unlock(&led_cdev->led_access);
>>   		return PTR_ERR(led_cdev->dev);
>>   	}
>> -	if (init_data && init_data->fwnode)
>> +	if (init_data && init_data->fwnode) {
>>   		led_cdev->dev->fwnode = init_data->fwnode;
>> +		if (is_of_node(init_data->fwnode))
>> +			led_cdev->dev->of_node = to_of_node(init_data->fwnode);
> It would be step backwards. You can do the conversion in the place of
> use i.e. in devm_led_get().

Could be done. But it would break another use case I have. I'm also 
working on the regulator support and for this one, of_node needs to be 
populated.

Is there a problem populating of_node if the LED is indeed described in 
the DT ?

JJ

>
>> +	}
>>   
>>   	if (ret)
>>   		dev_warn(parent, "Led %s renamed to %s due to name collision",
>>