Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp837551ybn; Wed, 2 Oct 2019 07:01:16 -0700 (PDT) X-Google-Smtp-Source: APXvYqxBS7NA55RkqhWXynesnZP2S/5JZZR4bqDd4UDL6fPTQDfZYurEgO35kd5UOv3wGDmxYkaR X-Received: by 2002:a05:6402:16d5:: with SMTP id r21mr3885765edx.71.1570024876616; Wed, 02 Oct 2019 07:01:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570024876; cv=none; d=google.com; s=arc-20160816; b=NqBDgEuufXv97iJmsX1XXoy/Nhg52iyHaPQ3Xklx4aUocKirjpG7uu/jDZPyHAOdil GVNG1bbR04I+tUcNvBrSsM4bceGoF/AXkhbzUHHc7Qid6zfhSb7sSIoALDrJkPa7l44n 6TaXJKTAL+k35lQmxYJwfDdonAls2ubHgnjEG7qGkL5eOBS6ILsIMfUi9J8is5Vs2HMf 9LqxJhOIfpHRzD5C4BPwBjoYKfPhqd141XWsOxtFAlPrpXtuq/DZfYJciDaZChDRCxnk 22nI/PX4VH3ZcuKpQafLygJQVXQUUFHnjNUQOTLl90WV+UCGdb8Ny6YOK3aHyQ5tSyA8 rp7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:cc:to:from:subject; bh=u0uIwAsbiVrBeg3HCywPRXsrhDTZFb4omoZoiA4nZos=; b=gix+xi9ICoXLzlTjdohDxfPxyPdWNaNklDYM8cErkmoN+3Yn6YcnhboFMTIaU/0eSs GaMNQ+zClN4BK2bj6f5ukXdhklrcwIDxcCzF+hT011jUA5gTQr1v2EBYMD6lEPPwoBGc ePEhykinmps1HeXDLeB/t7TtdubZoNqzLOSD9CQBMJyOeDrpS59Qqq6tOzoM2QyLw1wZ tRToOveH3uRvte37DBFBgnhHFqbLKgxKjzZpfMJqTiUpvXV+nFUnK7wGQb5moQYhy0hT bobSVRjmFTvXzNOY62tF6dsK+KrFKgebSYHHIHIXpP6fWuAIKDZJ1NOhwc5HI+36J4cY X8zA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v3si11284050edc.404.2019.10.02.07.00.50; Wed, 02 Oct 2019 07:01:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726214AbfJBOA2 (ORCPT + 99 others); Wed, 2 Oct 2019 10:00:28 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:57480 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726087AbfJBOA2 (ORCPT ); Wed, 2 Oct 2019 10:00:28 -0400 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x92Dvicp126173 for ; Wed, 2 Oct 2019 10:00:27 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2vcvcxsyqn-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 02 Oct 2019 10:00:27 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Oct 2019 15:00:25 +0100 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 2 Oct 2019 15:00:22 +0100 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x92E0Lx824183122 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Oct 2019 14:00:21 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 48A62A4067; Wed, 2 Oct 2019 14:00:21 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D0B2DA4054; Wed, 2 Oct 2019 14:00:19 +0000 (GMT) Received: from localhost.localdomain (unknown [9.80.234.231]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 2 Oct 2019 14:00:19 +0000 (GMT) Subject: Re: [PATCH] KEYS: asym_tpm: Switch to get_random_bytes() From: Mimi Zohar To: Jarkko Sakkinen , linux-integrity@vger.kernel.org Cc: stable@vger.kernel.org, David Howells , Herbert Xu , "David S. Miller" , "open list:ASYMMETRIC KEYS" , "open list:CRYPTO API" , open list Date: Wed, 02 Oct 2019 10:00:19 -0400 In-Reply-To: <20190926171601.30404-1-jarkko.sakkinen@linux.intel.com> References: <20190926171601.30404-1-jarkko.sakkinen@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5 (3.20.5-1.fc24) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19100214-0012-0000-0000-000003535F73 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19100214-0013-0000-0000-0000218E6336 Message-Id: <1570024819.4999.119.camel@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-10-02_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=607 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910020135 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-09-26 at 20:16 +0300, Jarkko Sakkinen wrote: > Only the kernel random pool should be used for generating random numbers. > TPM contributes to that pool among the other sources of entropy. In here it > is not, agreed, absolutely critical because TPM is what is trusted anyway > but in order to remove tpm_get_random() we need to first remove all the > call sites. At what point during boot is the kernel random pool available?  Does this imply that you're planning on changing trusted keys as well? Mimi