Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 02 Oct 2019 11:08:41 -0400 (EDT)
Message-Id: <20191002.110841.1635125794151710562.davem@davemloft.net>
To:     valex@mellanox.com
Cc:     mkubecek@suse.cz, saeedm@mellanox.com, leon@kernel.org,
        bp@alien8.de, stephen@networkplumber.org, netdev@vger.kernel.org,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] mlx5: avoid 64-bit division in
 dr_icm_pool_mr_create()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <57dc9ea7-e925-e8e8-af71-35326bb5c673@mellanox.com>
References: <20191002121241.D74DAE04C7@unicorn.suse.cz>
        <57dc9ea7-e925-e8e8-af71-35326bb5c673@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Alex Vesker <valex@mellanox.com>
Date: Wed, 2 Oct 2019 14:58:44 +0000

> On 10/2/2019 3:12 PM, Michal Kubecek wrote:
>> Recently added code introduces 64-bit division in dr_icm_pool_mr_create()
>> so that build on 32-bit architectures fails with
>>
>>    ERROR: "__umoddi3" [drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.ko] undefined!
>>
>> As the divisor is always a power of 2, we can use bitwise operation
>> instead.
>>
>> Fixes: 29cf8febd185 ("net/mlx5: DR, ICM pool memory allocator")
>> Reported-by: Borislav Petkov <bp@alien8.de>
>> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
 ...
> Align diff is power of 2,? looks good to me.
> Thanks for fixing it Michal.

I'll just apply this directly, thanks everyone.