Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp990804ybn; Wed, 2 Oct 2019 09:13:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqxMLy5a53CRSE1cKwOZjVkaShwoMEnUjCfpOo0cR+usgzvzGPvA6n/Skmo6GnhU7chxSkvS X-Received: by 2002:a17:906:c787:: with SMTP id cw7mr3778532ejb.34.1570032789984; Wed, 02 Oct 2019 09:13:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570032789; cv=none; d=google.com; s=arc-20160816; b=h42EeEVTVjf1ZaRm8HzTmon1VpwQCHsAqxoryxtoVdkuPzRd9w82Bk9tXK2ILrDnSM aCiHkwTp6jcyL7omssRBRNiDSGY4gJY7gY2l4wAFbE064cK+3XVgqGrBVmyEXPyQ0XRo Uc+DKjg64ZcUDdvdPLb1D8ALmL2n0XczUnIKhrmOMcTG0fw82iO0lW09SKSYt3kmgulm HIl6QRxdmAJwZ80XCKn8vZu+2AQQY2vLvTXPijV2yZ4aRrVcuEy8g//H9/nuC5Hns1QC /LUz9CKqa6R0oTc/UN3y0k14icZB29JJpo7n5+0PPmvk69gu7WWKlkDnaOiDc3fouysR Vz2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:user-agent:in-reply-to:mime-version :references:mail-followup-to:reply-to:message-id:subject:to:from :date:dkim-signature; bh=Xrk/iom6SacGfDF1/MM+LslI1lE/sTa+RHmkn0pm1oc=; b=08E7hxddTdC/rYP33A/wbuBFVJlN9DyYnFz0nIFo5ELS0WIniCIE9m/nLmPr8ObWX/ 46bJooPhvVJNtkR4nCWA2/Qs9coIvz/RMHQHTbX9SBWqJbyYYNnI/5w6qkpnsOAuIARP h5/PPzR4DzcbY0+uYekq+PGJEGI8RiX27KPqccRT6PoL3WjubInv1NsvDMCocIEHYigm B4ZDx9/j91DQFzghy8KtaiYvQyhDcAXNZ8pzYDW2M+MhEQ2Faln3TwbRKJ48r7qBv6WP UMSNA6IejgcAGalUzJTFDn+iRH9AcoAQkZqjBn88I3Ars0HM5gFZ35igpaXOmXANFOP1 TSeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=azTJwomv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h12si11399729edq.437.2019.10.02.09.12.45; Wed, 02 Oct 2019 09:13:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=azTJwomv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbfJBPmM (ORCPT + 99 others); Wed, 2 Oct 2019 11:42:12 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:44058 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727333AbfJBPmM (ORCPT ); Wed, 2 Oct 2019 11:42:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570030930; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xrk/iom6SacGfDF1/MM+LslI1lE/sTa+RHmkn0pm1oc=; b=azTJwomv9/VoNcjy9Ik5K5aNeL7f45TW9cTOZ33dkbTg0mwDozxFS9Cvnyx0zdpu2v21eZ KrtVlPgG9snCFLQwzJnlhys1Giwsbh2omvcmt0QkZji9qJE09KWrRsz6kH64gRR69CnfVc xCE8DGcypsFoGmh/n22DJR4EV/jrNcQ= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-250-WDuhs8NSPsyU-pJqW2ATlA-1; Wed, 02 Oct 2019 11:42:08 -0400 Received: by mail-io1-f71.google.com with SMTP id o11so45204932iop.12 for ; Wed, 02 Oct 2019 08:42:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:reply-to :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=GNjCC8zynseCVOGAnnSac3El4WfDC7ObgvHi4C+tII0=; b=SVb8GQKlFLvN+iVc8gBMfU/ytGxn0FSq2wC8uIvZB7BeYUWMXR+TC6HuPIVjOTf4bN msgIE2GmIy12/Gx0E0TumwkYD4VaO0cyZmymlDBVhheLgtSekC0NPRkcdf3bGoT7BCVI xBUJYItTt5CAhAV4EIttg7Y+KYkgGFYgn+97orKUuuVjhA3rukAY5R5x5tbr0JKOnAus z/FX+X37qj6WwO5yLTClO/+8Be5TSQrXE0ISPiWxIeRQYmcU1LIsCkvCVq342HGACaN8 13znexOMhw2+mKxw3zrBW2KQGE3r5V+ICm8Taod5cSWGRvDt2YIc9RGPMMCjrVUXQHnV 3wfw== X-Gm-Message-State: APjAAAWd4ahrttQ7kkfwvNy1T90QvPvgcMAIF6beM2pPFWkjJ8YAL3pR Bmm7HOAgxVwwPzZPq2AnfDxAb7n3f1dS6qSC8UeXHYnF1e5VNMo7fl200muJpBxbYkx/W+YhzU4 h1atGSpom8cpDKRmGqOQ3xcmz X-Received: by 2002:a92:8f19:: with SMTP id j25mr4502262ild.302.1570030928109; Wed, 02 Oct 2019 08:42:08 -0700 (PDT) X-Received: by 2002:a92:8f19:: with SMTP id j25mr4502246ild.302.1570030927921; Wed, 02 Oct 2019 08:42:07 -0700 (PDT) Received: from localhost (ip70-163-223-149.ph.ph.cox.net. [70.163.223.149]) by smtp.gmail.com with ESMTPSA id q3sm8208287ioi.68.2019.10.02.08.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2019 08:42:07 -0700 (PDT) Date: Wed, 2 Oct 2019 08:42:04 -0700 From: Jerry Snitselaar To: Sasha Levin , Greg KH , Jarkko Sakkinen , linux-stabley@vger.kernel.org, Vadim Sukhomlinov , stable@vger.kernel.org, Douglas Anderson , Peter Huewe , Jason Gunthorpe , "open list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations Message-ID: <20191002154204.me4lzgx2l4r6zkpy@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Sasha Levin , Greg KH , Jarkko Sakkinen , linux-stabley@vger.kernel.org, Vadim Sukhomlinov , stable@vger.kernel.org, Douglas Anderson , Peter Huewe , Jason Gunthorpe , "open list:TPM DEVICE DRIVER" , open list References: <20191002131445.7793-1-jarkko.sakkinen@linux.intel.com> <20191002131445.7793-4-jarkko.sakkinen@linux.intel.com> <20191002135758.GA1738718@kroah.com> <20191002151751.GP17454@sasha-vm> <20191002153123.wcguist4okoxckis@cantor> MIME-Version: 1.0 In-Reply-To: <20191002153123.wcguist4okoxckis@cantor> User-Agent: NeoMutt/20180716 X-MC-Unique: WDuhs8NSPsyU-pJqW2ATlA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed Oct 02 19, Jerry Snitselaar wrote: >On Wed Oct 02 19, Sasha Levin wrote: >>On Wed, Oct 02, 2019 at 03:57:58PM +0200, Greg KH wrote: >>>On Wed, Oct 02, 2019 at 04:14:44PM +0300, Jarkko Sakkinen wrote: >>>>From: Vadim Sukhomlinov >>>> >>>>commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream >>>> >>>>TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disablin= g >>>>future TPM operations. TPM 1.2 behavior was different, future TPM >>>>operations weren't disabled, causing rare issues. This patch ensures >>>>that future TPM operations are disabled. >>>> >>>>Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.") >>>>Cc: stable@vger.kernel.org >>>>Signed-off-by: Vadim Sukhomlinov >>>>[dianders: resolved merge conflicts with mainline] >>>>Signed-off-by: Douglas Anderson >>>>Reviewed-by: Jarkko Sakkinen >>>>Signed-off-by: Jarkko Sakkinen >>>>--- >>>>drivers/char/tpm/tpm-chip.c | 5 +++-- >>>>1 file changed, 3 insertions(+), 2 deletions(-) >>> >>>What kernel version(s) is this for? >> >>It would go to 4.19, we've recently reverted an incorrect backport of >>this patch. >> >>Jarkko, why is this patch 3/3? We haven't seen the first two on the >>mailing list, do we need anything besides this patch? >> >>-- >>Thanks, >>Sasha > >It looks like there was a problem mailing the earlier patchset, and patche= s 1 and 2 >weren't cc'd to stable, but patch 3 was. Is linux-stabley@vger.kernel.org a valid address?