Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp998502ybn; Wed, 2 Oct 2019 09:19:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqzuWvp16ChV8hE3/TOVy1H8YfoT7bdws6eCuWWZppt3AcF8Nn9czUMtZP4fwbso/D4kGE5O X-Received: by 2002:a05:6402:14d0:: with SMTP id f16mr4673525edx.41.1570033172935; Wed, 02 Oct 2019 09:19:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570033172; cv=none; d=google.com; s=arc-20160816; b=Gz6lrMRzSvbs7AZvVNWsRMlGnD5ipmQoNIeajXPoIGtM9EspE+1HUCEyivY3Urp2i8 IFi6xlojhdopre3Sa+HhIWo5tMZMRiKKgSg/AHHPUQCbWhP4VXwxLsrzGsIHmkI5XWu9 VX1hvbtjbZDtaXnP3ZNsw4Hs8IBNpxq48bV2wcRbXkYADUGs8D2Yx6uWF6ajHtoDODep ssd4/byVsWRqXzLe5M1CHWAX8OSmIb3eQweUXZR4AcsFzjA0Xd+SG+NWW2eZwNyVHpd3 3Y6i+zYSqGlejECAVYrRejEal+xQOgQz1uWreE3u2EwG1SmN9rYHCZ9AvlcgiWfnUUgh 0ccw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:dkim-signature; bh=SPHZmX4C7Urp+H0LA2/AxH2ABa3WUPDKQf0vUvkJQ+0=; b=GlnDhOH0esJUq9O9nGmi4HKedvZc9Y+/DIjN7TCIYTmxWvzybgszypAwMOKjZymdJN xnWfGGfkUDPi906BNLa0chpAz3yntIDHhe0G13eLtwrqnlQYK0r9LcTw1yn6lxf9jgkY MRAZsQkXN66w1ABAXHv6Py6i9KpEykq1K1EuD1bM0xbPYvSm1HICI84XVwDWKdSk614F Or8lJURhUjwENNs0g59iHUSrLl+5YoUDSoTFDML1sINt7mwgvFeElDvnbFXBhpTvVxFu QiUBqpO+ROTx3EKZkF7crYmOvBcbmkta2Zx8fnv0ZanDB3V3L+PuO95DF+ruBS3hpQ9d N0aQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I6Tr4280; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t14si11014890ejx.372.2019.10.02.09.19.07; Wed, 02 Oct 2019 09:19:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=I6Tr4280; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726195AbfJBQJ5 (ORCPT + 99 others); Wed, 2 Oct 2019 12:09:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:37950 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725852AbfJBQJ5 (ORCPT ); Wed, 2 Oct 2019 12:09:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2640F21D81; Wed, 2 Oct 2019 16:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570032596; bh=qqbcqGXc5C/kil7EDQLVNG0WxVmn4bKkQ5z1qtVBH2Q=; h=Date:From:To:Subject:References:In-Reply-To:From; b=I6Tr4280cvka5hVIZcRHW0xfbBZqsZG1Qv4fWPzJErLIMSTdtN3sg09PYTobRNTpJ uG6Ux1/2OcAQhPgBjPo13j/m+qtZuksaJp3rF9M61F61UV7lLU5vAWPlIpDyH463+L X2AihfONiDEc+WCDM+0WeEW51joqoGyaHdZ39OJY= Date: Wed, 2 Oct 2019 18:09:54 +0200 From: Greg KH To: Sasha Levin , Jarkko Sakkinen , linux-stabley@vger.kernel.org, Vadim Sukhomlinov , stable@vger.kernel.org, Douglas Anderson , Peter Huewe , Jason Gunthorpe , "open list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations Message-ID: <20191002160954.GA1754224@kroah.com> References: <20191002131445.7793-1-jarkko.sakkinen@linux.intel.com> <20191002131445.7793-4-jarkko.sakkinen@linux.intel.com> <20191002135758.GA1738718@kroah.com> <20191002151751.GP17454@sasha-vm> <20191002153123.wcguist4okoxckis@cantor> <20191002154204.me4lzgx2l4r6zkpy@cantor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191002154204.me4lzgx2l4r6zkpy@cantor> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 02, 2019 at 08:42:04AM -0700, Jerry Snitselaar wrote: > On Wed Oct 02 19, Jerry Snitselaar wrote: > > On Wed Oct 02 19, Sasha Levin wrote: > > > On Wed, Oct 02, 2019 at 03:57:58PM +0200, Greg KH wrote: > > > > On Wed, Oct 02, 2019 at 04:14:44PM +0300, Jarkko Sakkinen wrote: > > > > > From: Vadim Sukhomlinov > > > > > > > > > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream > > > > > > > > > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling > > > > > future TPM operations. TPM 1.2 behavior was different, future TPM > > > > > operations weren't disabled, causing rare issues. This patch ensures > > > > > that future TPM operations are disabled. > > > > > > > > > > Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.") > > > > > Cc: stable@vger.kernel.org > > > > > Signed-off-by: Vadim Sukhomlinov > > > > > [dianders: resolved merge conflicts with mainline] > > > > > Signed-off-by: Douglas Anderson > > > > > Reviewed-by: Jarkko Sakkinen > > > > > Signed-off-by: Jarkko Sakkinen > > > > > --- > > > > > drivers/char/tpm/tpm-chip.c | 5 +++-- > > > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > > > > > What kernel version(s) is this for? > > > > > > It would go to 4.19, we've recently reverted an incorrect backport of > > > this patch. > > > > > > Jarkko, why is this patch 3/3? We haven't seen the first two on the > > > mailing list, do we need anything besides this patch? > > > > > > -- > > > Thanks, > > > Sasha > > > > It looks like there was a problem mailing the earlier patchset, and patches 1 and 2 > > weren't cc'd to stable, but patch 3 was. > > Is linux-stabley@vger.kernel.org a valid address? > Heh, no :)