Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190906184712.91980-1-john.stultz@linaro.org> <20190930032651.8264-1-hdanton@sina.com>
In-Reply-To: <20190930032651.8264-1-hdanton@sina.com>
From:   John Stultz <john.stultz@linaro.org>
Date:   Wed, 2 Oct 2019 09:14:42 -0700
Message-ID: <CALAqxLUXKYibt6e4ji=kpP4ROFkU_4YQZoAE-ciq2bnFJxM_PA@mail.gmail.com>
Subject: Re: [RESEND][PATCH v8 1/5] dma-buf: Add dma-buf heaps framework
To:     Hillf Danton <hdanton@sina.com>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        "Andrew F . Davis" <afd@ti.com>, Laura Abbott <labbott@redhat.com>,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Liam Mark <lmark@codeaurora.org>,
        Pratik Patel <pratikp@codeaurora.org>,
        Brian Starkey <Brian.Starkey@arm.com>,
        Vincent Donnefort <Vincent.Donnefort@arm.com>,
        Sudipto Paul <Sudipto.Paul@arm.com>,
        Christoph Hellwig <hch@infradead.org>,
        Chenbo Feng <fengc@google.com>,
        Alistair Strachan <astrachan@google.com>,
        Hridya Valsaraju <hridya@google.com>,
        dri-devel <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Sep 29, 2019 at 8:27 PM Hillf Danton <hdanton@sina.com> wrote:
> On Fri,  6 Sep 2019 18:47:08 +0000 John Stultz wrote:
> > +/**
> > + * dma_heap_get_data() - get per-heap driver data
> > + * @heap: DMA-Heap to retrieve private data for
> > + *
> > + * Returns:
> > + * The per-heap data for the heap.
> > + */
> > +void *dma_heap_get_data(struct dma_heap *heap);
> > +
>
> It will help readers more than thought understand this framework
> if s/get_data/get_drvdata/

Sounds good!

Thanks for the review and suggestion!
-john