Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751413AbWACV0F (ORCPT ); Tue, 3 Jan 2006 16:26:05 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964914AbWACVZL (ORCPT ); Tue, 3 Jan 2006 16:25:11 -0500 Received: from mx.pathscale.com ([64.160.42.68]:38597 "EHLO mx.pathscale.com") by vger.kernel.org with ESMTP id S1750909AbWACVZD (ORCPT ); Tue, 3 Jan 2006 16:25:03 -0500 Subject: Re: [PATCH 0 of 20] [RFC] ipath - PathScale InfiniPath driver From: "Bryan O'Sullivan" To: Arjan van de Ven Cc: Greg KH , linux-kernel@vger.kernel.org In-Reply-To: <1136321851.2869.18.camel@laptopd505.fenrus.org> References: <20051230080002.GA7438@kroah.com> <1135984304.13318.50.camel@serpentine.pathscale.com> <20051231001051.GB20314@kroah.com> <1135993250.13318.94.camel@serpentine.pathscale.com> <20060103172732.GA9170@kroah.com> <1136321691.10862.61.camel@localhost.localdomain> <1136321851.2869.18.camel@laptopd505.fenrus.org> Content-Type: text/plain Date: Tue, 03 Jan 2006 13:24:45 -0800 Message-Id: <1136323485.10862.74.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1053 Lines: 24 On Tue, 2006-01-03 at 21:57 +0100, Arjan van de Ven wrote: > that sounds like your driver should mimic the openIB userspace ABI for > this *exactly* so that you can use the same management tools for either > scenario... The OpenIB userspace ABI is huge and complex, and the OpenIB subnet management agent (OpenSM) is even more so. Our low-level subnet management agent has vastly simpler needs, so it really is better served with 300 lines of specialised code (I don't care what the ABI actually is) than 15,000 lines introduced for the sake of unneeded compatibility. Perhaps read/write on the character device file would be preferable to ioctls for sending and receiving these management packets? We don't implement those file methods at the moment, so it's not like we'd be displacing anything.