Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1031476ybn; Wed, 2 Oct 2019 09:49:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqw67PNKZGHawaTWotLVeTVwfI+2d2Ysm1WL9eT2jqTEM060tAoWDzWH6PVLDkdku65SEYh1 X-Received: by 2002:a05:6402:1585:: with SMTP id c5mr4862839edv.66.1570034946962; Wed, 02 Oct 2019 09:49:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570034946; cv=none; d=google.com; s=arc-20160816; b=pj38lwjyvGz8sKxtjS6kzyGhA8vrjXnuGYEkJH13N4Idkv+5Etnp9S4Q9gNKQezuNi yQIbv2wL0Jujq5PcSKoLrwF8nQ34mwJt9/8itkU4RGhR7JDDCG28vHaCb0aivdBZDpmA sg/O7pmoXk3e6bEWs/e191/qbKbRQhvAcG6yfFAUyL3cT5fO0EZbCpOeW1OpiLum6LEL 7acujI8nTvJfGRnYWY+gf217Rs0P4bpkJdwOpK1NQTio9Ki/zn5QZy7ePH5I8c1DNmus ktxLnyGTqwvJdaiARMRkki49VWoFF1rsXzLuKUb799FZb9adOFt6M27RhTlQsn60g/zK tfQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=CF4ahfKrLY6PGQkVCvedV/A9h1szeF7pHldbXDftUBw=; b=Bk2D8KDf+5VDBx5ndpphlHjpiWpCXpSYNlv/u0iammX3AxO3VzPlAqj1xTBoXCazp6 d2HqsSXdJ1klHBo8UlpXGCAbMM2vOfuFi+nlpI8LyW69yZwHhtt3G7FQr9RBCMruXYwh bH6HxCgrVoGC2E5EYXev2Dz5xLk0gLUIClyvLqrGtoJ4j5jMcg0i28+ml40WKNodBDFu jQkWULvAs2YNQ7cegcEYy6Y86sAUwGI/IiTor/ck4be7fLUDVZ9sXAvZ8smuLJNprKdo y84tT/JatQseXve8nKQuzwsPWLqkp6SLQ5rZB7msyYinTloD106RV2y2+edOUaO3D0je UM/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si10766968eju.351.2019.10.02.09.48.42; Wed, 02 Oct 2019 09:49:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727289AbfJBQqr (ORCPT + 99 others); Wed, 2 Oct 2019 12:46:47 -0400 Received: from mga11.intel.com ([192.55.52.93]:42926 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbfJBQqr (ORCPT ); Wed, 2 Oct 2019 12:46:47 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2019 09:46:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,249,1566889200"; d="scan'208";a="221461292" Received: from tassilo.jf.intel.com (HELO tassilo.localdomain) ([10.7.201.137]) by fmsmga002.fm.intel.com with ESMTP; 02 Oct 2019 09:46:46 -0700 Received: by tassilo.localdomain (Postfix, from userid 1000) id A12EA301A2F; Wed, 2 Oct 2019 09:46:46 -0700 (PDT) From: Andi Kleen To: acme@kernel.org Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: [PATCH] perf script: Allow --time with --reltime Date: Wed, 2 Oct 2019 09:46:42 -0700 Message-Id: <20191002164642.1719-1-andi@firstfloor.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen The original --reltime patch forbid --time with --reltime. But it turns out --time doesn't really care about --reltime, because the relative time is only used at final output, while the time filtering always works earlier on absolute time. So just remove the check and allow combining the two options. Fixes: 90b10f47c0ee ("perf script: Support relative time") Signed-off-by: Andi Kleen --- tools/perf/builtin-script.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index 32b17d51c982..7481003b2761 100644 --- a/tools/perf/builtin-script.c +++ b/tools/perf/builtin-script.c @@ -3601,11 +3601,6 @@ int cmd_script(int argc, const char **argv) } } - if (script.time_str && reltime) { - fprintf(stderr, "Don't combine --reltime with --time\n"); - return -1; - } - if (itrace_synth_opts.callchain && itrace_synth_opts.callchain_sz > scripting_max_stack) scripting_max_stack = itrace_synth_opts.callchain_sz; -- 2.21.0