Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1138592ybn; Wed, 2 Oct 2019 11:23:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqzkvHAmETkx7jIN/TEx+ocnd4afWe3Wjylrbmslu/OSCOgPFBfMna7el5we1V7LjlDBbmaA X-Received: by 2002:a05:6402:1e4:: with SMTP id i4mr5342742edy.31.1570040633286; Wed, 02 Oct 2019 11:23:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570040633; cv=none; d=google.com; s=arc-20160816; b=u3lA3KvR1LU2hUZfpGb/4qBL5dWXxpB+sCkZD1xdZc/5cAPkrKCSJiRhcrOiHpDOgz y7XDK0YY3JWFh0uCPYI6zw5J7df2zTS0nDhA9oXTxUL3RqVnCUwHPxj7BYPdwKy2IH9M JaJcA/7ZpZt6PpJD9h7ezEn3yhf2hKUokrLw844a65bcMq4iuv54jS8QNAdHad/27pZp PEj4dEXlyORkpOER+MTB8sbI8MP7Fjb6txRWVw7nzs3n0Rcjo60i+8uCfrZ/lNMSC1Q2 XTXWVb826JYxYGJ/gJX9lf1NEar1rxNAd/6Xtf3YVmvFP4RiBlVsHFmgTV9kMoc2JKt9 s5bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=Y3au3/M3arsalRuD87xJc7wx3ixOeoJtRJbxPI7LsKM=; b=bAGBg50BfqLqcErZIlopT152uI+1brRcC+2RERkduwsnvbMHt5jEuo+vfI6oWGNT+Z A9A22kHDG4dudisTMprFWTOEA3fTzEFchpwb581N6+m0UZlcW2UhbKMrwwHSE1E+Uhpw 7ebaVKlZjrqriYP7szFs04lqwHMa4mUss7z0OXfbMWJGijYKySwMCZjFwINt+XKxOvtX xUlEJvY6jhFN28uLM/R5eMzWjL+syja+YX8uIYDnQcgMvC0g6cSfi44Uzght1kc2Emcd a+h+6SzJ5Wq7p1Dp82a3Yge55cneX3mTsv7+Wi1J0/z0dp1MSKEqB+HOlagzoGMto3A+ zyZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BvOLufvi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h20si11489183edb.218.2019.10.02.11.23.28; Wed, 02 Oct 2019 11:23:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=BvOLufvi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728933AbfJBSXL (ORCPT + 99 others); Wed, 2 Oct 2019 14:23:11 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:42368 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728908AbfJBSXI (ORCPT ); Wed, 2 Oct 2019 14:23:08 -0400 Received: by mail-pl1-f196.google.com with SMTP id e5so107805pls.9 for ; Wed, 02 Oct 2019 11:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Y3au3/M3arsalRuD87xJc7wx3ixOeoJtRJbxPI7LsKM=; b=BvOLufviFdeIlP65HLzlQlaevk8Z1ynXm3PajSXkiB1ulLF02+Fc+gBYQ8U7N9N7d5 Xt6NCAGhITa1myv5drGkcSip8MfiyF7AzgmiLqd6skPUZ88O6IZCrSChuDmTZ2rVK/OV Dn17PWKmIQnZUlODf7/Xog8ueAaaVFk49UnQKodwVUY9DNeRSFUvMKsw4+ALMs5Dbxsp U4Wxtoa1TqkNa405h+Nzrc/NyakSvWwX7wjIzg6zm94KoIxFPTFIr6+cJRoC5MS5VZhk M3hUxXJq1MV18gkAB0GY/PhrckeTz0yJLnKGkZkaFsZb7tw0MaQoxYVtaONW9IqA1ZHR I5BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Y3au3/M3arsalRuD87xJc7wx3ixOeoJtRJbxPI7LsKM=; b=dNxUnBKHRSNH5/dNO2N8AaO8crNk4jcCjQkYMKw8cWdPym2ut40Cz81i9uskQiEMYR wZFnoIS7U4+zSRwWMWtRnsfgOJy3CMBbmcwqDoTcHGD3qm6lHWuMHG+DTOiz5ulr4SIP JpFo72tjEd7+Wzmt8UFnkSgmuNNAUPdFegna0DjAubik+h3Iw+8D9cGTX8znqibA3QIM AewHmJ+Ss6vfWcViVLntTAh/YPqoa5RHelDVtEd5ONMh+reXGvhZTxGX/tmQeuZ10GbQ acEMYj9tgUwiJQCnYTpqyan2vJGaqtun8CKPnGP0V2KCPFCA3H9Se+l0dcS1EtnMTLau P/RA== X-Gm-Message-State: APjAAAWtGfm1EE90hiKW5AirLr7AMYOTJDnlPk2WsTiX8jgttG9dEN2R QNdRuFXc8+Y0oN5+m9cMPupiEAd9lrs= X-Received: by 2002:a17:902:768a:: with SMTP id m10mr5272249pll.234.1570040587203; Wed, 02 Oct 2019 11:23:07 -0700 (PDT) Received: from localhost.localdomain ([2601:1c2:680:1319:692:26ff:feda:3a81]) by smtp.gmail.com with ESMTPSA id q132sm171102pfq.16.2019.10.02.11.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2019 11:23:06 -0700 (PDT) From: John Stultz To: lkml Cc: John Stultz , Laura Abbott , Benjamin Gaignard , Sumit Semwal , Liam Mark , Pratik Patel , Brian Starkey , Vincent Donnefort , Sudipto Paul , "Andrew F . Davis" , Christoph Hellwig , Chenbo Feng , Alistair Strachan , Hridya Valsaraju , Hillf Danton , dri-devel@lists.freedesktop.org Subject: [PATCH v9 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps Date: Wed, 2 Oct 2019 18:22:54 +0000 Message-Id: <20191002182255.21808-5-john.stultz@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191002182255.21808-1-john.stultz@linaro.org> References: <20191002182255.21808-1-john.stultz@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This adds a CMA heap, which allows userspace to allocate a dma-buf of contiguous memory out of a CMA region. This code is an evolution of the Android ION implementation, so thanks to its original author and maintainters: Benjamin Gaignard, Laura Abbott, and others! Cc: Laura Abbott Cc: Benjamin Gaignard Cc: Sumit Semwal Cc: Liam Mark Cc: Pratik Patel Cc: Brian Starkey Cc: Vincent Donnefort Cc: Sudipto Paul Cc: Andrew F. Davis Cc: Christoph Hellwig Cc: Chenbo Feng Cc: Alistair Strachan Cc: Hridya Valsaraju Cc: Hillf Danton Cc: dri-devel@lists.freedesktop.org Reviewed-by: Benjamin Gaignard Acked-by: Laura Abbott Tested-by: Ayan Kumar Halder Signed-off-by: John Stultz --- v2: * Switch allocate to return dmabuf fd * Simplify init code * Checkpatch fixups v3: * Switch to inline function for to_cma_heap() * Minor cleanups suggested by Brian * Fold in new registration style from Andrew * Folded in changes from Andrew to use simplified page list from the heap helpers v4: * Use the fd_flags when creating dmabuf fd (Suggested by Benjamin) * Use precalculated pagecount (Suggested by Andrew) v6: * Changed variable names to improve clarity, as suggested by Brian v7: * Use newly lower-cased init_heap_helper_buffer helper * Use new dmabuf export helper v8: * Make struct dma_heap_ops const (Suggested by Christoph) * Condense dma_heap_buffer and heap_helper_buffer (suggested by Christoph) * Checkpatch whitespace fixups v9: * Removing needless check noted by Brian Starkey * Rename dma_heap_get_data->dma_heap_get_drvdata suggested by Hilf Danton * Check signals after clearing memory pages to avoid doing needless work if the task is killed as suggested by Hilf --- drivers/dma-buf/heaps/Kconfig | 8 ++ drivers/dma-buf/heaps/Makefile | 1 + drivers/dma-buf/heaps/cma_heap.c | 169 +++++++++++++++++++++++++++++++ 3 files changed, 178 insertions(+) create mode 100644 drivers/dma-buf/heaps/cma_heap.c diff --git a/drivers/dma-buf/heaps/Kconfig b/drivers/dma-buf/heaps/Kconfig index 205052744169..a5eef06c4226 100644 --- a/drivers/dma-buf/heaps/Kconfig +++ b/drivers/dma-buf/heaps/Kconfig @@ -4,3 +4,11 @@ config DMABUF_HEAPS_SYSTEM help Choose this option to enable the system dmabuf heap. The system heap is backed by pages from the buddy allocator. If in doubt, say Y. + +config DMABUF_HEAPS_CMA + bool "DMA-BUF CMA Heap" + depends on DMABUF_HEAPS && DMA_CMA + help + Choose this option to enable dma-buf CMA heap. This heap is backed + by the Contiguous Memory Allocator (CMA). If your system has these + regions, you should say Y here. diff --git a/drivers/dma-buf/heaps/Makefile b/drivers/dma-buf/heaps/Makefile index d1808eca2581..6e54cdec3da0 100644 --- a/drivers/dma-buf/heaps/Makefile +++ b/drivers/dma-buf/heaps/Makefile @@ -1,3 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 obj-y += heap-helpers.o obj-$(CONFIG_DMABUF_HEAPS_SYSTEM) += system_heap.o +obj-$(CONFIG_DMABUF_HEAPS_CMA) += cma_heap.o diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c new file mode 100644 index 000000000000..3fdb00e937c8 --- /dev/null +++ b/drivers/dma-buf/heaps/cma_heap.c @@ -0,0 +1,169 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * DMABUF CMA heap exporter + * + * Copyright (C) 2012, 2019 Linaro Ltd. + * Author: for ST-Ericsson. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "heap-helpers.h" + +struct cma_heap { + struct dma_heap *heap; + struct cma *cma; +}; + +static void cma_heap_free(struct heap_helper_buffer *buffer) +{ + struct cma_heap *cma_heap = dma_heap_get_drvdata(buffer->heap); + unsigned long nr_pages = buffer->pagecount; + struct page *cma_pages = buffer->priv_virt; + + /* free page list */ + kfree(buffer->pages); + /* release memory */ + cma_release(cma_heap->cma, cma_pages, nr_pages); + kfree(buffer); +} + +/* dmabuf heap CMA operations functions */ +static int cma_heap_allocate(struct dma_heap *heap, + unsigned long len, + unsigned long fd_flags, + unsigned long heap_flags) +{ + struct cma_heap *cma_heap = dma_heap_get_drvdata(heap); + struct heap_helper_buffer *helper_buffer; + struct page *cma_pages; + size_t size = PAGE_ALIGN(len); + unsigned long nr_pages = size >> PAGE_SHIFT; + unsigned long align = get_order(size); + struct dma_buf *dmabuf; + int ret = -ENOMEM; + pgoff_t pg; + + if (align > CONFIG_CMA_ALIGNMENT) + align = CONFIG_CMA_ALIGNMENT; + + helper_buffer = kzalloc(sizeof(*helper_buffer), GFP_KERNEL); + if (!helper_buffer) + return -ENOMEM; + + init_heap_helper_buffer(helper_buffer, cma_heap_free); + helper_buffer->flags = heap_flags; + helper_buffer->heap = heap; + helper_buffer->size = len; + + cma_pages = cma_alloc(cma_heap->cma, nr_pages, align, false); + if (!cma_pages) + goto free_buf; + + if (PageHighMem(cma_pages)) { + unsigned long nr_clear_pages = nr_pages; + struct page *page = cma_pages; + + while (nr_clear_pages > 0) { + void *vaddr = kmap_atomic(page); + + memset(vaddr, 0, PAGE_SIZE); + kunmap_atomic(vaddr); + /* + * Avoid wasting time zeroing memory if the process + * has been killed by by SIGKILL + */ + if (fatal_signal_pending(current)) + goto free_cma; + + page++; + nr_clear_pages--; + } + } else { + memset(page_address(cma_pages), 0, size); + } + + helper_buffer->pagecount = nr_pages; + helper_buffer->pages = kmalloc_array(helper_buffer->pagecount, + sizeof(*helper_buffer->pages), + GFP_KERNEL); + if (!helper_buffer->pages) { + ret = -ENOMEM; + goto free_cma; + } + + for (pg = 0; pg < helper_buffer->pagecount; pg++) + helper_buffer->pages[pg] = &cma_pages[pg]; + + /* create the dmabuf */ + dmabuf = heap_helper_export_dmabuf(helper_buffer, fd_flags); + if (IS_ERR(dmabuf)) { + ret = PTR_ERR(dmabuf); + goto free_pages; + } + + helper_buffer->dmabuf = dmabuf; + helper_buffer->priv_virt = cma_pages; + + ret = dma_buf_fd(dmabuf, fd_flags); + if (ret < 0) { + dma_buf_put(dmabuf); + /* just return, as put will call release and that will free */ + return ret; + } + + return ret; + +free_pages: + kfree(helper_buffer->pages); +free_cma: + cma_release(cma_heap->cma, cma_pages, nr_pages); +free_buf: + kfree(helper_buffer); + return ret; +} + +static const struct dma_heap_ops cma_heap_ops = { + .allocate = cma_heap_allocate, +}; + +static int __add_cma_heap(struct cma *cma, void *data) +{ + struct cma_heap *cma_heap; + struct dma_heap_export_info exp_info; + + cma_heap = kzalloc(sizeof(*cma_heap), GFP_KERNEL); + if (!cma_heap) + return -ENOMEM; + cma_heap->cma = cma; + + exp_info.name = cma_get_name(cma); + exp_info.ops = &cma_heap_ops; + exp_info.priv = cma_heap; + + cma_heap->heap = dma_heap_add(&exp_info); + if (IS_ERR(cma_heap->heap)) { + int ret = PTR_ERR(cma_heap->heap); + + kfree(cma_heap); + return ret; + } + + return 0; +} + +static int add_cma_heaps(void) +{ + cma_for_each_area(__add_cma_heap, NULL); + return 0; +} +device_initcall(add_cma_heaps); -- 2.17.1