Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     Saiyam Doshi <saiyamdoshi.in@gmail.com>
Cc:     gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: exfat: use bdev_sync function directly where needed
In-Reply-To: <20191002151703.GA6594@SD>
References: <20191002151703.GA6594@SD>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1570043055_7127P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Wed, 02 Oct 2019 15:04:15 -0400
Message-ID: <9938.1570043055@turing-police>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--==_Exmh_1570043055_7127P
Content-Type: text/plain; charset=us-ascii

On Wed, 02 Oct 2019 20:47:03 +0530, Saiyam Doshi said:
> fs_sync() is wrapper to bdev_sync(). When fs_sync is called with
> non-zero argument, bdev_sync gets called.
>
> Most instances of fs_sync is called with false and very few with
> true. Refactor this and makes direct call to bdev_sync() where
> needed and removes fs_sync definition.

Did you do an actual analysis of where bdev_sync() *should*
be called?

The note in the TODO was intended to point out that many of the calls
are called with 'false' and probably should not be.

 #ifdef CONFIG_EXFAT_DELAYED_SYNC
-	fs_sync(sb, false);
 	fs_set_vol_flags(sb, VOL_CLEAN);
 #endif

Consider - with this patch, we are now setting the volume state to clean - but
we've not actually flushed the filesystem to disk, which means it's almost
guaranteed that the file system is *NOT* in fact clean.

Changing all the 'false' that happen before a VOL_CLEAN to 'true' is
probably more correct - but still totally wrong if DELAYED_SYNC isn't defined
because then we *aren't* syncing to disk at all.


--==_Exmh_1570043055_7127P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBXZT0rgdmEQWDXROgAQIBKg//X9lHdUpw66i/cHOTZ7lqpmV2mkPQ5/+p
fG58bja0kg2YSZrHSWHzvD93HZmV228K1vBOitP2kjsU1IUFJ0qicx5irJzZzjdk
qZ3G5e3o6on3BuyP7b5uF+rI/+v+4HMZ3xLwCSEH9rRk1u5vPwH8BT7AXGp3YXNw
zZI65DtJB6nNnqSITc5tIXluDeSo11AjJ6E9nINYJWyL053UcV3ScsABZUJdCUQE
RsaFDhNv7pM8FwMdYMXT8aapB8BG4aUT/RiSHboa3dQ9AcQSlmBKs8w9lTSt2I1Y
aPCfkY2+VrGvv9Hn6EiiZKsPf3dBnHbVa/jEthcB+sfQwUqvQMZXZ1ketqhC4Do3
QJ+n3Blj1tAoN/ibXAEBx/PLzbzMxVfw6dOXCetx34cpb1waQ79kGZtcte/sWEAD
zQWKQUJLbCtHJwder/DX5TjbESmX3U7twxgSTTFhxyl0IQ2gRB4ZUN9NcRWJFDQV
thldWb65CcJP1rHfC/lembJIvIB6TGaaI2GCFvEqAHjUmWBzgBGhNfpDakTDekwU
zLTljhXFyEh/VgTxh3Cv4JMB1gqiAZPzlEiJn/oolBok3OeAjhXzJIj3Pkvp7tVs
+Jv4NBNxl3B4xEpay5lDK7VhcQAa5/Gah5HhJIxG+9QMNGDFqD638XpIxoN6MN0I
OOGl4QJUGIE=
=eIW1
-----END PGP SIGNATURE-----

--==_Exmh_1570043055_7127P--