Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp1789103ybn; Wed, 2 Oct 2019 23:48:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqwHXeym/5gIEU6SNUU6sCcc1EwMIC3HME3/uBRCJoeCb5KKlNM9areNLAoAQZrM4JaPjgLw X-Received: by 2002:a17:906:4d58:: with SMTP id b24mr6409734ejv.263.1570085311643; Wed, 02 Oct 2019 23:48:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570085311; cv=none; d=google.com; s=arc-20160816; b=IL7qvRduGTnU6DfmUOVi9+X8eRNuymRvCIwi74aBTZp6eoOGrD0Pt+/mXN0XaDXM6Q rmfM5le2IvdTawbY+fYv0YEY+CGRcG0GciXykjWSgtS34T70LhbewP8FhXRCYeqEbCkD x38OHjxSbNu8QhR6fnV3wI3AXCi+9qSn4kaqBT6N7GgQsTw4ud5o/R00IpYLO9UWo8N/ yNITn0JlgApTJf6DTALYqEBdCOxrNf1N9scr1K6B73Zkhxv5Tps1OpbMaOG7xA8pnQYX iOZNk7clnccELd2cWBSKjAfF5lFcOQgfK9IQiVl1WWuKGLzg+BP5psLTAYuiBubc+A3n rPOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=w28l9Bay7xNtt5EXEnd1uzJ8iDtWAmssV5M28OxUAUw=; b=j037ByY4+9loGsalMnxqsWDZkW1IHOXNNPlM0GR2P66HylaGCmrUyWS1Y4srXI3OWU Ty3+vSLwCTKdGsIm+hiPL7q5XVMQiOgGbKPx7k2z9uzYnI3EBfYWbG2GzpD/XFx6EStN KXKfeBght7yhxuATYtImTKzwnFayvuZMKUHW21QrOeuIVsN7xyKe0v919iPCAKEVUGfI Y440WcxTEwgQr1dYZQVgEOEtoTbDcQCsbj6C5zsPLkQgiE+GDwv1ICZO7f/15hCK8tvt pOZwz/N0vNH03DQ0E++f/jZ9mHrghZ6a/jDq+ouEc1EzLrTpTYcBww0+Qylb8goAaaDA /wGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KQ2LkOEK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f15si890452edm.414.2019.10.02.23.48.07; Wed, 02 Oct 2019 23:48:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=KQ2LkOEK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728072AbfJCGqV (ORCPT + 99 others); Thu, 3 Oct 2019 02:46:21 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:38365 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727911AbfJCGqV (ORCPT ); Thu, 3 Oct 2019 02:46:21 -0400 Received: by mail-pg1-f195.google.com with SMTP id x10so1135530pgi.5 for ; Wed, 02 Oct 2019 23:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w28l9Bay7xNtt5EXEnd1uzJ8iDtWAmssV5M28OxUAUw=; b=KQ2LkOEKTiO6GSVyAcVCwmI6tIIYuy7DboEUKeXPS7BzMWxfmXMGK4XlY2+G43azj7 lbWDLABCj1KDR3VPgHd0Ok/LMU8p7VvOv86DtsxVtqDxwFP7arJNy173b+On2ikOKiuc bLXmZaGH5ckchLB7pXN2xEm6b/fYaac9AJj/o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w28l9Bay7xNtt5EXEnd1uzJ8iDtWAmssV5M28OxUAUw=; b=ipb6jyiPuDR3IouWZwu9FHd1X5+LBnCRMht5E4aXxxXOKkDSW3XpDo2rFj3FZvq6br mg0FWaA+pOuqbGOMfkg128z0AHxgcKXNX39tuV4m2+k1T7a+uD/ZlgmQBwph+B8VdH9n vwyVZf/gmdP1fO9EHmL84SUKfzSbDb81jL2f7Fb8ARzQUCs/av1I9pctkx60mqC6CTS1 m5TGo4CTLsaSPMpAFLGdEEKaf3bQzTEumTfq/ObP8ZMnRej3ZVoYmuLARnpEdhzsidQM TyIFiZYnjfZRXef2jOD3PYAJ2PanLumfYsr27Ao8NsdT0oquwIIfTLDSNW+OiDHlLM8z t40g== X-Gm-Message-State: APjAAAVU8LRitq+s/mGNRLKfsubZb7tG/IllWNh/3a9XvQ5xdYW6kRZ7 3d4Ggb6P0DCmCr3qSHMHrRPOcA== X-Received: by 2002:a17:90a:da05:: with SMTP id e5mr8479030pjv.141.1570085180342; Wed, 02 Oct 2019 23:46:20 -0700 (PDT) Received: from localhost.localdomain ([49.206.203.121]) by smtp.gmail.com with ESMTPSA id b18sm1423294pfi.157.2019.10.02.23.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Oct 2019 23:46:19 -0700 (PDT) From: Jagan Teki To: Maxime Ripard , Chen-Yu Tsai , David Airlie , Daniel Vetter Cc: michael@amarulasolutions.com, Icenowy Zheng , linux-sunxi , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Jagan Teki Subject: [PATCH v11 5/7] drm/sun4i: sun6i_mipi_dsi: Add VCC-DSI regulator support Date: Thu, 3 Oct 2019 12:15:25 +0530 Message-Id: <20191003064527.15128-6-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20191003064527.15128-1-jagan@amarulasolutions.com> References: <20191003064527.15128-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Allwinner MIPI DSI controllers are supplied with SoC DSI power rails via VCC-DSI pin. Add support for this supply pin by adding voltage regulator handling code to MIPI DSI driver. Tested-by: Merlijn Wajer Signed-off-by: Jagan Teki --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 14 ++++++++++++++ drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 2 ++ 2 files changed, 16 insertions(+) diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index 446dc56cc44b..fe9a3667f3a1 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -1110,6 +1110,12 @@ static int sun6i_dsi_probe(struct platform_device *pdev) return PTR_ERR(base); } + dsi->regulator = devm_regulator_get(dev, "vcc-dsi"); + if (IS_ERR(dsi->regulator)) { + dev_err(dev, "Couldn't get VCC-DSI supply\n"); + return PTR_ERR(dsi->regulator); + } + dsi->regs = devm_regmap_init_mmio_clk(dev, "bus", base, &sun6i_dsi_regmap_config); if (IS_ERR(dsi->regs)) { @@ -1183,6 +1189,13 @@ static int sun6i_dsi_remove(struct platform_device *pdev) static int __maybe_unused sun6i_dsi_runtime_resume(struct device *dev) { struct sun6i_dsi *dsi = dev_get_drvdata(dev); + int err; + + err = regulator_enable(dsi->regulator); + if (err) { + dev_err(dsi->dev, "failed to enable VCC-DSI supply: %d\n", err); + return err; + } reset_control_deassert(dsi->reset); clk_prepare_enable(dsi->mod_clk); @@ -1215,6 +1228,7 @@ static int __maybe_unused sun6i_dsi_runtime_suspend(struct device *dev) clk_disable_unprepare(dsi->mod_clk); reset_control_assert(dsi->reset); + regulator_disable(dsi->regulator); return 0; } diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h index 5c3ad5be0690..a01d44e9e461 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h @@ -12,6 +12,7 @@ #include #include #include +#include #define SUN6I_DSI_TCON_DIV 4 @@ -23,6 +24,7 @@ struct sun6i_dsi { struct clk *bus_clk; struct clk *mod_clk; struct regmap *regs; + struct regulator *regulator; struct reset_control *reset; struct phy *dphy; -- 2.18.0.321.gffc6fa0e3