Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp40870ybn; Thu, 3 Oct 2019 01:01:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqyXOSsDOUVU7izHwSeVw6MB/0R4AZQ+98Y8HJ5BfyT8BU+9mVv6rpeyskNa3QAV/yHGwcuL X-Received: by 2002:a50:cf8b:: with SMTP id h11mr7701195edk.236.1570089692292; Thu, 03 Oct 2019 01:01:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570089692; cv=none; d=google.com; s=arc-20160816; b=I9CYaXiD75xRgsIKIcaYhpUzEdDtvBOVw8YA68fhNw162zhM5QYD7gNEJpTFawYKIC uZbydQz0wc2Ls9xGqmg9a1sodWlXlklCFGJ89TWO6kHMEHg1X7vEIdu7LK+Rxri2z86h khR1SUu+pNKGpGCygt1yizesGMS+y26w4VgSjJ2SLfRzcYi+gMUqm+6m0897e9mSh4d3 muIh0iA3tXPPGHV/bLihBfzB2gZSL6krg9TD1LP579qvSPAER5QirPmxBjx/FAfVrm/e 3unMFW6pYpucaMXYzXEnBjEVTzcV1gJj86Tl4bnCMYA+iN2aU0/pjdiZt3TKRL6EXhv+ hQlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=120bNVWb/cAQsirkPrw5wuUPD0J6O7LG/eInWnc0GXM=; b=wDRgVDTMBm9QM3Rf9JQnJXDby1a5NbdUchqi53oVYD/tmCv/qUogiaTBurGarxPKUH ZZnBRI/QfExP4TJ9qEMj5hBVlMiPcKut81jiBKeBYnguMxJJX75HVJdftlBnYA9VoWz0 +Rlw9PZjusEuP9sEuqNoLwdlZIc/H3R6UwMpNTsoBGyYmVxY6duTq6I6sHyW501FZG7m pETlxQTd2XsbpgCKmfZ/WZik3igRNjAr1dh/ijxF2icCUImuA6Vpco0/xxnKnbH6JzCB FvsvuEhowz5XI9nGXVYtUF/4IYU5ot3n6Hmr48cYz5rk3meiCccljle9aIu7HNFTN/zp WlOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=sOufCbPQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v25si953243edy.392.2019.10.03.01.01.06; Thu, 03 Oct 2019 01:01:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=sOufCbPQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728610AbfJCH71 (ORCPT + 99 others); Thu, 3 Oct 2019 03:59:27 -0400 Received: from conuserg-11.nifty.com ([210.131.2.78]:59223 "EHLO conuserg-11.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728061AbfJCH7R (ORCPT ); Thu, 3 Oct 2019 03:59:17 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-11.nifty.com with ESMTP id x937wTkV007720; Thu, 3 Oct 2019 16:58:32 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com x937wTkV007720 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1570089512; bh=120bNVWb/cAQsirkPrw5wuUPD0J6O7LG/eInWnc0GXM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sOufCbPQwtH53jrQ4+SKNS8BTK/E+XQVV/fnQjxwjvk5EUSt/oSWZrt5XQgHu04Yz +dXnPmpBjOZeJgRpfqmsR4OdoiEUmMIzSq/kOO5SoiB1EdqX2XKB3WZxUMamBpaN9v xElB92NZS0pxrpkwlK0EEvIjRMlfaVrXOmATpd+ubKqJUVvc7QEp57uLYEJxzkOqt6 joTmKXLL6IL42K5T511rqnUtMhHiF/HUw/py6SqPqF6uLBzopMEzEEvq4EeKgrHLLn Lf6+lwHVFdpajOGOSHJmWcH+F6yYt5HZK41Ij7ZpZlJJaBSe7jMTKCXvBd9QjsNGU9 N9ehQ6o3sz3FA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Jessica Yu Cc: Matthias Maennich , Greg Kroah-Hartman , Shaun Ruffell , linux-kbuild@vger.kernel.org, Masahiro Yamada , Martijn Coenen , Will Deacon , linux-kernel@vger.kernel.org Subject: [PATCH v2 3/6] module: rename __kstrtab_ns_* to __kstrtabns_* to avoid symbol conflict Date: Thu, 3 Oct 2019 16:58:23 +0900 Message-Id: <20191003075826.7478-4-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191003075826.7478-1-yamada.masahiro@socionext.com> References: <20191003075826.7478-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The module namespace produces __strtab_ns_ symbols to store namespace strings, but it does not guarantee the name uniqueness. This is a potential problem because we have exported symbols starting with "ns_". For example, kernel/capability.c exports the following symbols: EXPORT_SYMBOL(ns_capable); EXPORT_SYMBOL(capable); Assume a situation where those are converted as follows: EXPORT_SYMBOL_NS(ns_capable, some_namespace); EXPORT_SYMBOL_NS(capable, some_namespace); The former expands to "__kstrtab_ns_capable" and "__kstrtab_ns_ns_capable", and the latter to "__kstrtab_capable" and "__kstrtab_ns_capable". Then, we have the duplicated "__kstrtab_ns_capable". To ensure the uniqueness, rename "__kstrtab_ns_*" to "__kstrtabns_*". Signed-off-by: Masahiro Yamada Reviewed-by: Matthias Maennich --- Changes in v2: None include/linux/export.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/linux/export.h b/include/linux/export.h index 0695d4e847d9..621158ecd2e2 100644 --- a/include/linux/export.h +++ b/include/linux/export.h @@ -55,7 +55,7 @@ extern struct module __this_module; "__ksymtab_" #ns NS_SEPARATOR #sym ": \n" \ " .long " #sym "- . \n" \ " .long __kstrtab_" #sym "- . \n" \ - " .long __kstrtab_ns_" #sym "- . \n" \ + " .long __kstrtabns_" #sym "- . \n" \ " .previous \n") #define __KSYMTAB_ENTRY(sym, sec) \ @@ -79,7 +79,7 @@ struct kernel_symbol { asm("__ksymtab_" #ns NS_SEPARATOR #sym) \ __attribute__((section("___ksymtab" sec "+" #sym), used)) \ __aligned(sizeof(void *)) \ - = { (unsigned long)&sym, __kstrtab_##sym, __kstrtab_ns_##sym } + = { (unsigned long)&sym, __kstrtab_##sym, __kstrtabns_##sym } #define __KSYMTAB_ENTRY(sym, sec) \ static const struct kernel_symbol __ksymtab_##sym \ @@ -112,7 +112,7 @@ struct kernel_symbol { /* For every exported symbol, place a struct in the __ksymtab section */ #define ___EXPORT_SYMBOL_NS(sym, sec, ns) \ ___export_symbol_common(sym, sec); \ - static const char __kstrtab_ns_##sym[] \ + static const char __kstrtabns_##sym[] \ __attribute__((section("__ksymtab_strings"), used, aligned(1))) \ = #ns; \ __KSYMTAB_ENTRY_NS(sym, sec, ns) -- 2.17.1