Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp60279ybn; Thu, 3 Oct 2019 01:23:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqxP5vva246lKBrTy5R/SM6UgzZo9tMazXWjvc78ai+1CG9Dxa9ykuCSzpWxkRAJqZVil60p X-Received: by 2002:a50:9512:: with SMTP id u18mr8061581eda.182.1570091009357; Thu, 03 Oct 2019 01:23:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570091009; cv=none; d=google.com; s=arc-20160816; b=di+4CLHC1y+SeF6rXdqwO9WrxNJmPZzLZ3nNyXAm2eWTksO4mjrBzQHea6j4OuzefV b8vA2s3TT7kLD3Pmv3lBa96sjayR/ph8qRv9oRrXUjJtYeSiWbIG8qWwddkEt+MwKn1A czKQFgDhKbVq/V1096OqRfRYzGGjTQXfzwtghW+NRe1hhh+8i+0RPYLCCvIKFq9zKItC Js5UFYW6xK+bEzj3LPrdbrlLWtNAm86TStgr9fNbr9BLHYVC/U9yJSeUESZ5D4lIvdzx yjmJqwS4w3Vyj/cgsaVD1gUwEcltUQsshH7bONhu2GiAL3RYl968D355Hz28aHwFeCn2 CE8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8zKQHIP4YwYhrAbiYz4qiYPJjMfVc95q9I2Ul3cItzU=; b=aDV0shDIDg1Mdis6UNXGOkZbXEk/cMYi4gwDOAQSziGMwc2FcLn5AoJjnW0nlY6fz+ L9o91xv8qNg+wDpZ6K1ZPbqIV+F5REezbF9tHZe861KQoLaEV1nHvFfPhcQebXb14pQ+ OflbP4u3sAacSunjqm2j1cSFSnU+xUPLn4PQdFFX8kLl88PcSbHWX6VS6HXIDBw5HAvU R8+DJfX1Ef1iF081cfIaHKDYFzHIabX9HGyenrQLvI/+NKVW6WXFY1T2c4PODKbL3svb r7Ob15Af7IRBJz+GCgwPssawtZw3ISzvmQOuw8yS/XIR9Ylu46KC1D1KtDEa65sYCLld 3b+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l54si1016719edb.206.2019.10.03.01.23.05; Thu, 03 Oct 2019 01:23:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728743AbfJCIV2 (ORCPT + 99 others); Thu, 3 Oct 2019 04:21:28 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:55799 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728328AbfJCIVY (ORCPT ); Thu, 3 Oct 2019 04:21:24 -0400 Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iFwMR-00031C-PP; Thu, 03 Oct 2019 10:21:19 +0200 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1iFwMO-0003f2-6w; Thu, 03 Oct 2019 10:21:16 +0200 From: Oleksij Rempel To: Andrew Lunn , Florian Fainelli , Heiner Kallweit Cc: Oleksij Rempel , Pengutronix Kernel Team , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] net: phy: at803x: remove probe and struct at803x_priv Date: Thu, 3 Oct 2019 10:21:13 +0200 Message-Id: <20191003082113.13993-3-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003082113.13993-1-o.rempel@pengutronix.de> References: <20191003082113.13993-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org struct at803x_priv is never used in this driver. So remove it and the probe function allocating it. Suggested-by: Heiner Kallweit Signed-off-by: Oleksij Rempel Reviewed-by: Heiner Kallweit --- drivers/net/phy/at803x.c | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c index 8fb7abdf10d0..463fc681dead 100644 --- a/drivers/net/phy/at803x.c +++ b/drivers/net/phy/at803x.c @@ -63,10 +63,6 @@ MODULE_DESCRIPTION("Atheros 803x PHY driver"); MODULE_AUTHOR("Matus Ujhelyi"); MODULE_LICENSE("GPL"); -struct at803x_priv { - bool phy_reset:1; -}; - struct at803x_context { u16 bmcr; u16 advertise; @@ -232,20 +228,6 @@ static int at803x_resume(struct phy_device *phydev) return phy_modify(phydev, MII_BMCR, BMCR_PDOWN | BMCR_ISOLATE, 0); } -static int at803x_probe(struct phy_device *phydev) -{ - struct device *dev = &phydev->mdio.dev; - struct at803x_priv *priv; - - priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); - if (!priv) - return -ENOMEM; - - phydev->priv = priv; - - return 0; -} - static int at803x_config_init(struct phy_device *phydev) { int ret; @@ -368,7 +350,6 @@ static struct phy_driver at803x_driver[] = { .phy_id = ATH8035_PHY_ID, .name = "Atheros 8035 ethernet", .phy_id_mask = AT803X_PHY_ID_MASK, - .probe = at803x_probe, .config_init = at803x_config_init, .set_wol = at803x_set_wol, .get_wol = at803x_get_wol, @@ -382,7 +363,6 @@ static struct phy_driver at803x_driver[] = { .phy_id = ATH8030_PHY_ID, .name = "Atheros 8030 ethernet", .phy_id_mask = AT803X_PHY_ID_MASK, - .probe = at803x_probe, .config_init = at803x_config_init, .link_change_notify = at803x_link_change_notify, .set_wol = at803x_set_wol, @@ -397,7 +377,6 @@ static struct phy_driver at803x_driver[] = { .phy_id = ATH8031_PHY_ID, .name = "Atheros 8031 ethernet", .phy_id_mask = AT803X_PHY_ID_MASK, - .probe = at803x_probe, .config_init = at803x_config_init, .set_wol = at803x_set_wol, .get_wol = at803x_get_wol, -- 2.23.0