Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190918180253.GA11702@SD>
In-Reply-To: <20190918180253.GA11702@SD>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Thu, 3 Oct 2019 12:01:43 +0200
Message-ID: <CAPDyKFo0ExfCcOjBF31NnPAQuj1eekCoZa0m9xKvqevBsWM1cQ@mail.gmail.com>
Subject: Re: [PATCH] mmc: host: bcm2835: use devm_platform_ioremap_resource wrapper
To:     Saiyam Doshi <saiyamdoshi.in@gmail.com>
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
        "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 18 Sep 2019 at 20:03, Saiyam Doshi <saiyamdoshi.in@gmail.com> wrote:
>
> Use devm_platform_ioremap_resource helper which wraps
> platform_get_resource() and devm_ioremap_resource() together.
>
> Generated by: scripts/coccinelle/api/devm_platform_ioremap_resource.cocci.
>
> More information about semantic patching is available at
> http://coccinelle.lip6.fr/
>
> Signed-off-by: Saiyam Doshi <saiyamdoshi.in@gmail.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/bcm2835.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
> index 148414d7f0c9..99f61fd2a658 100644
> --- a/drivers/mmc/host/bcm2835.c
> +++ b/drivers/mmc/host/bcm2835.c
> @@ -1357,7 +1357,6 @@ static int bcm2835_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
>         struct clk *clk;
> -       struct resource *iomem;
>         struct bcm2835_host *host;
>         struct mmc_host *mmc;
>         const __be32 *regaddr_p;
> @@ -1373,8 +1372,7 @@ static int bcm2835_probe(struct platform_device *pdev)
>         host->pdev = pdev;
>         spin_lock_init(&host->lock);
>
> -       iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       host->ioaddr = devm_ioremap_resource(dev, iomem);
> +       host->ioaddr = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(host->ioaddr)) {
>                 ret = PTR_ERR(host->ioaddr);
>                 goto err;
> --
> 2.20.1
>