Received: by 2002:a25:824b:0:0:0:0:0 with SMTP id d11csp255079ybn; Thu, 3 Oct 2019 04:44:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqyQxu9aO3ngOG+QZUORykQu6d6WanvW7V1HKk2ZwnYC2Jhl2Qnt26pKHb8+kAYwpFaCjDph X-Received: by 2002:a17:906:9604:: with SMTP id s4mr7417732ejx.38.1570103049243; Thu, 03 Oct 2019 04:44:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570103049; cv=none; d=google.com; s=arc-20160816; b=IPtnmIKnB5mYCQQPKNUlxu2sqis7UWzAT6h0GYncxGxSiz/EGdJhNPjlGVtDV8v6GH CoeKC4mIH5BCmIT1HzkHDD1C21LrRzP7NXHCPYEyOW9ZdDPMSbqysl9hYD41LNnVsGXq 794z8feq2+KTQ8d/dP0qTcBxdXD9d2GVPWABOi2pbOhyZXjDcDlUa5dW7/hDB134f3qz BgvOlCEkJKCHGI7ObflPnTT+AD31A8QK39n/PU/hfZOibgDgaCHclccshFWAv4IHxqWe O7RyAu/fqrYpLUISAcA1eC246a/B4R14QtEUw9lQsrcQFMJw1M3McOCQYEx7Wy9W0jDB eUtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=jT+9een9mM2KMQc2NI2nr4Y5VakV7H0J0wclQgkUils=; b=wIrgSeplO2DAz0gGPO56bBkNc3Mpn8kzdcGtTd8DV58u/QLprySdN0nbdY8a670Udl 8I8t257Amu+C/ETK47X2njNRYDeQI15iY1r2TGbnd7mlV7JMnNKQjaNRsalWdOzmhJhS BJ85niLgL23ki+Y1/m3tNv5M5s5jC39pwZurf5ZAKEZ0QjzhYPbFKM0JaM04t5dkdmn/ RBVMmRra2YynBmkXA7ePzUScQkC1sMA9i5OTSf/hYd64TcIe1tgpSQH5lXAb17H3BEVe 9yt35cWtil6Lfvxvz0n6XoefhgdA2xxJE2/iwqsu6WIMivHVszhzWOzaypCFdBI9ak6C lVsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fwQKUaUF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4si1173024edy.295.2019.10.03.04.43.44; Thu, 03 Oct 2019 04:44:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fwQKUaUF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730239AbfJCLms (ORCPT + 99 others); Thu, 3 Oct 2019 07:42:48 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34330 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730229AbfJCLms (ORCPT ); Thu, 3 Oct 2019 07:42:48 -0400 Received: by mail-wr1-f68.google.com with SMTP id a11so2604979wrx.1 for ; Thu, 03 Oct 2019 04:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=jT+9een9mM2KMQc2NI2nr4Y5VakV7H0J0wclQgkUils=; b=fwQKUaUFQ6a/78eZtJv4rTrh8NiDMuR7wU5XIhUa32e5TXH0+uEfqBrFFkdozLykq1 GQSrne3+R37jhPKfIGFJf311r73w02PYfez7FjwTcAvND4U6++vYOlaw9c7WX4E2oyY2 nikycED8a/vkMoQonBwpaQpGZVVqHZtSoxd6HWOawqobtNEPaBTphaIe8FghuMyKs8M7 Si1Ey/dynw5twF+TVb6+G/a0w5QVMtNTUe+ZkLXqRKR5eM/AqOW7nzpR5fVSezqZ8q7p 32T39Ez4eEhSJ4vkH30VuovExTH5yDqeqWSaWP4tiMu+75u2sBIPXVp+uzQum8/3hiUN VJwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=jT+9een9mM2KMQc2NI2nr4Y5VakV7H0J0wclQgkUils=; b=jzmHcgliOnRyepkFtF2ArO8KfZGE8/dH9SZNU5Zu81skCQF/SirMvl/6ZyN9sMVIwg s7dWa+k3YNY+/xqBECjrd1I9bOGO05Nw3F7AANyyzAjN/O8594bHaEJO1FxhrrfjPrBo QnzThCYJqUXFJNhQb98ZzmN/n3tI2fM3IhcF0OhISx9NhAP9SN0BdhMyWV/hAzewF9yl MX9MbCizGBD/KB4yGQ3eve604h9fpXcLUK/Z3mTKeATu2Ptvqi6HrZRyr+1M4//pY1LG spQUQw0IvM24JJCYHCqy9dakEbiHDfb671dfUuDqK9LHsxvwFhpgMar5OVM4pZqvC0MF oinw== X-Gm-Message-State: APjAAAXLhTsRINVXy9fU8yvY0MFAfbfVnVlMh+hVgWQ4chDjacNTTho0 FC15+/AKhsO77PsUMBHjIXoTLg== X-Received: by 2002:a5d:6704:: with SMTP id o4mr6839593wru.365.1570102966533; Thu, 03 Oct 2019 04:42:46 -0700 (PDT) Received: from dell ([2.27.167.122]) by smtp.gmail.com with ESMTPSA id 36sm3014735wrp.30.2019.10.03.04.42.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Oct 2019 04:42:46 -0700 (PDT) Date: Thu, 3 Oct 2019 12:42:42 +0100 From: Lee Jones To: Andreas Kemnade Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, jacek.anaszewski@gmail.com, pavel@ucw.cz, dmurphy@ti.com, robh+dt@kernel.org, mark.rutland@arm.com, b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v4 2/2] backlight: lm3630a: Add an enable gpio for the HWEN pin Message-ID: <20191003114242.GE21172@dell> References: <20190912213257.24147-1-andreas@kemnade.info> <20190912213257.24147-3-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190912213257.24147-3-andreas@kemnade.info> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Sep 2019, Andreas Kemnade wrote: > For now just enable it in the probe function to allow I2C > access. Disabling also means resetting the register values > to default and according to the datasheet does not give > power savings. > > Tested on Kobo Clara HD. > > Signed-off-by: Andreas Kemnade > Reviewed-by: Dan Murphy > Reviewed-by: Daniel Thompson > --- > changes in v2: > - simplification > - correct gpio direction initialisation > > changes in v3: > - removed legacy include > > drivers/video/backlight/lm3630a_bl.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Applied, thanks. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog