Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] cpupower : Handle set and info subcommands correctly
To:     Abhishek Goel <huntbag@linux.vnet.ibm.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     trenn@suse.com, ego@linux.vnet.ibm.com, shuah <shuah@kernel.org>
References: <20190913080712.26383-1-huntbag@linux.vnet.ibm.com>
From:   shuah <shuah@kernel.org>
Message-ID: <2614b112-5e19-96dc-179b-8d4e3b8c8858@kernel.org>
Date:   Thu, 3 Oct 2019 08:38:53 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20190913080712.26383-1-huntbag@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/13/19 2:07 AM, Abhishek Goel wrote:
> Cpupower tool has set and info options which are being used only by
> x86 machines. This patch removes support for these two subcommands
> from generic cpupower utility. Thus, these two subcommands will now be
> available only for intel.
> This removes the ambiguous error message while using set option in case
> of using non-intel systems.
> 
> Without this patch on a non-intel box:
> 
> root@ubuntu:~# cpupower info
> System does not support Intel's performance bias setting
> 
> root@ubuntu:~# cpupower set -b 10
> Error setting perf-bias value on CPU
> 
> With this patch on a non-intel box:
> 
> root@ubuntu:~# cpupower info
> Supported commands are:
>          frequency-info
>          frequency-set
>          idle-info
>          idle-set
>          monitor
>          help
> 
> Same result for set subcommand.
> 
> This patch does not affect results on a intel box.
> 
> Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
> Acked-by: Thomas Renninger <trenn@suse.de>
> ---
> 
> changes from v1:
> 	Instead of bailing out early in set and info commands, in V2, we
> 	are cutting out support for these two commands for non-intel
> 	systems.

thanks. I will get this in for 5.4-rc3 veru likely. Definitely in 5.4

-- Shuah