Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CAH2r5mv49T9gwwoJxKJfkgdi6xbf+hDALUiAJHghGikgUNParw@mail.gmail.com>
 <CAH2r5mtVW=3-2L+0QFJAqBG+uj2sYmF=dtzT_kqwK59cu94vGw@mail.gmail.com>
 <20191003104356.GA77584@google.com> <CAH2r5msF5DF2ac+-V0xRR-8RYeQdwpsS1iBLHM6iKTB+aEVc5Q@mail.gmail.com>
In-Reply-To: <CAH2r5msF5DF2ac+-V0xRR-8RYeQdwpsS1iBLHM6iKTB+aEVc5Q@mail.gmail.com>
From:   Masahiro Yamada <yamada.masahiro@socionext.com>
Date:   Fri, 4 Oct 2019 00:23:31 +0900
Message-ID: <CAK7LNARrdQad9=U1LknT9yRYtRagNVS8T5r_Ovv5Sa91QO3TsA@mail.gmail.com>
Subject: Re: nsdeps not working on modules in 5.4-rc1
To:     Steve French <smfrench@gmail.com>
Cc:     Matthias Maennich <maennich@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        CIFS <linux-cifs@vger.kernel.org>, Jessica Yu <jeyu@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Steve,

On Fri, Oct 4, 2019 at 12:15 AM Steve French <smfrench@gmail.com> wrote:
>
> On Thu, Oct 3, 2019 at 5:43 AM Matthias Maennich <maennich@google.com> wrote:
> >
> > Hi Steve!
> >
> > On Wed, Oct 02, 2019 at 06:54:26PM -0500, Steve French wrote:
> > >And running the build differently, from the root of the git tree
> > >(5.4-rc1) rather than using the Ubuntu 5.4-rc1 headers also fails
> > >
> > >e.g. "make  M=fs/cifs modules nsdeps"
> > >
> > >...
> > >  LD [M]  fs/cifs/cifs.o
> > >  Building modules, stage 2.
> > >  MODPOST 1 modules
> > >WARNING: module cifs uses symbol sigprocmask from namespace
> > >_fs/cifs/cache.o), but does not import it.
> > >...
> > >WARNING: module cifs uses symbol posix_test_lock from namespace
> > >cifs/cache.o), but does not import it.
> > >  CC [M]  fs/cifs/cifs.mod.o
> > >  LD [M]  fs/cifs/cifs.ko
> > >  Building modules, stage 2.
> > >  MODPOST 1 modules
> > >./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> > >make: *** [Makefile:1710: nsdeps] Error 2
> >
> > Thanks for reporting this. It appears to me you hit a bug that was
> > recently discovered: when building with `make M=some/subdirectory`,
> > modpost is misbehaving. Can you try whether this patch series solves
> > your problems:
> > https://lore.kernel.org/lkml/20191003075826.7478-1-yamada.masahiro@socionext.com/
> > In particular patch 2/6 out of the series.
> >
> > Cheers,
> > Matthias
>
>
> Applying just patch 2 and doing "make" from the root of the git tree
> (5.4-rc1), at the tail end of the build I got
>
> ...
> Kernel: arch/x86/boot/bzImage is ready  (#87)
>   Building modules, stage 2.
>   MODPOST 5340 modules
> free(): invalid pointer
> Aborted (core dumped)


Right.

Since 2/6 depends on 1/6,
applying only the second one does not work.


> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 134
> make: *** [Makefile:1303: modules] Error 2
>
> With patch 2 and doing make M=fs/cifs nsdeps from the root of the git tree I get
>
> $ make M=fs/cifs nsdeps
>   Building modules, stage 2.
>   MODPOST 1 modules
>   Building modules, stage 2.
>   MODPOST 1 modules
> ./scripts/nsdeps: 34: local: ./fs/cifs/cifsfs.c: bad variable name
> make: *** [Makefile:1710: nsdeps] Error 2
>
>
> --
> Thanks,
>
> Steve


-- 
Best Regards
Masahiro Yamada