Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp44950ybp; Thu, 3 Oct 2019 09:58:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqytz67gyuW+o+ekwYr/jBnQYJi2UXIw/AxauTE4MhwaevF5155NPJ9KB/sarQcQlbz26pph X-Received: by 2002:a17:906:3615:: with SMTP id q21mr8521281ejb.201.1570121925689; Thu, 03 Oct 2019 09:58:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570121925; cv=none; d=google.com; s=arc-20160816; b=k2rIyj3prkaC/YMkN5J+ZKVHfKrXfULKgVHJ1bdW7QjDcNpQFlHe32FmslDDjd+4KQ MUjxLJlRX4SgGJrR6SJeRdKf3c5vLJ26GQyuA+CXjCbUFMdGaUQnxfMF0veD97XDAl1E p2WKKKwdZAp6pV5khhN8m1Dblh/vY5YhL2X/9odsQCTAUlaBqyGDeYGe07aHtm2pVXf1 N/6zj8nAeIudl95nqQusMp9G1TkmO+uYR8Iu9Krob8KAgGDLG5ewFdbARsHszK1g/fvv 0iYNlmR3uDzlhwKRs0ERYeEoydAb3Ykth+NA5iUsv28gpnn9gX3nCnh3NW6Xx2AjLL89 heMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ugrakjKATdtEjJWn4tk6YlL3Okyto1CddfouAPmaV54=; b=TpbzqKcB3wz5y1SROJQmhjbKRNg+98LYpBrJFHp2mvkYlS48AlFaIgV5jJuuMLRbqp yQynEUQbG1+7YzEkiFqgpH7T0VHnK7nG+8gCHLHvd+Er0G6cqaMqkd0bLoxVBtEmly6O UruOofHMoPriz4/QGmBm4mNsUvao5uk0KY2PQIrl1vzc5c0v1xWi7gqob1jpbD/Q9gAR b2ukBzLFfK1iDPp1KWQf7YD2ojxw/HmIRQtJ83RizVutsaNMBoYTHae3AO947pVuf2FZ V4QUkcPcGjO4sIu2QwQO0b6yNYDegsANKZ1sgmGkefyZWnsLKNvd2JXUbtjf3Xxi3r/9 l7kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=oO2VLgtq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e14si1914265eda.104.2019.10.03.09.58.21; Thu, 03 Oct 2019 09:58:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=oO2VLgtq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405965AbfJCQup (ORCPT + 99 others); Thu, 3 Oct 2019 12:50:45 -0400 Received: from mail-qk1-f174.google.com ([209.85.222.174]:34985 "EHLO mail-qk1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404434AbfJCQug (ORCPT ); Thu, 3 Oct 2019 12:50:36 -0400 Received: by mail-qk1-f174.google.com with SMTP id w2so3060128qkf.2 for ; Thu, 03 Oct 2019 09:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ugrakjKATdtEjJWn4tk6YlL3Okyto1CddfouAPmaV54=; b=oO2VLgtqJ29OYQYQU1McnBMDLGkBdFgfD437kzpMWJzqazZ8fTH23PwceQ9Ho6hsd1 DVPKYd0YZBG2ATvRVNLH0nOYeUDMKDyDC17p91XWV4YmNCvXK3Rp4DcHvs8sRr1yLbhq HjJB0tmSD0r3AvOcvE/MVY8gFEocsV44G2But+/65voOg0m0CWg9qMg9MlpCQYzHs3zJ TRAz0GznLjDF2VuAGZyLZH4KTNp4Ckr1wr0vyaKniCT5lpe6HVbyRneyvnHgAKFh0XLh HSzuiRjXhqof6YHqVmxYgYuIhLWhou0DTVSczwgeeTLBlde247fvdqjZ2BnAEetj3Skh XAjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ugrakjKATdtEjJWn4tk6YlL3Okyto1CddfouAPmaV54=; b=UVvF4n/Vo8inVG5kZN+rsuWljEpyUOHrcD7i6z07G++0RbtWVST4vKcgGY6uyp2P0i 99NSCxWRq4FCJWZ6Pz79SauzfZnOWykgJXQsx6aMsgGtZkkpEgtri9gs9vcDj4vgmsXN FD8HuYVkNvecoeHJWlrTNWHIKpnUlbGkOc6muFfIcKDTtQWie0MWNCHU0DCKOd0RI9j0 w8pyj2LhtOi/sq5Vokz4sFtqZouogF+i9U+VUv4sN3F+qf2ud4Cazo+PXQ8D2cOhqdl+ x6BmfDuBnGeNfiv6nVypya4Shx4ylAerWHzdix5E7jWrz6TvJgDJP8Ebkuo0pf4F4oJo SwGw== X-Gm-Message-State: APjAAAXLIQjbvdfabBDJME30mYKRX6YYJqfIYv6wnpMJLgRQzBMMEcQY 1vAaRbnrBpuUyi4l0huJGQA= X-Received: by 2002:a37:4cc7:: with SMTP id z190mr5273064qka.458.1570121435276; Thu, 03 Oct 2019 09:50:35 -0700 (PDT) Received: from localhost ([2620:10d:c091:500::3:9f72]) by smtp.gmail.com with ESMTPSA id 207sm1891576qkh.33.2019.10.03.09.50.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Oct 2019 09:50:34 -0700 (PDT) Date: Thu, 3 Oct 2019 09:50:33 -0700 From: Tejun Heo To: Mika Westerberg Cc: "Rafael J. Wysocki" , AceLan Kao , Jens Axboe , Jan Kara , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: System hangs if NVMe/SSD is removed during suspend Message-ID: <20191003165033.GC3247445@devbig004.ftw2.facebook.com> References: <20191002122136.GD2819@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191002122136.GD2819@lahna.fi.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Mika. On Wed, Oct 02, 2019 at 03:21:36PM +0300, Mika Westerberg wrote: > but from that discussion I don't see more generic solution to be > implemented. > > Any ideas we should fix this properly? Yeah, the only fix I can think of is not using freezable wq. It's just not a good idea and not all that difficult to avoid using. Thanks. -- tejun