Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp64984ybp; Thu, 3 Oct 2019 10:13:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqxJEz/D6JYYVYeZVDA5J2KrHsAfl9vUW2/dfdbtQ6kiaCvh+hpEnq27dcmxViX9xcOzfvg5 X-Received: by 2002:a17:906:7d10:: with SMTP id u16mr8585843ejo.194.1570122839173; Thu, 03 Oct 2019 10:13:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570122839; cv=none; d=google.com; s=arc-20160816; b=uWRymTbGTJqgZ1mabeWPM9k3ROAI2eJKLbz2Lz/pSNgDMcPn1n4TmVlCe/yyxx6qA0 8KVAeDsN8x9bolHeyMLXe/jjsR5W5BX93gCPY1m47HX2L4wdHXtU9m6+0Pv3syDTMxmr CIjJxnRyPlyQSDCifounnVhTBH3GvVCX5lzgzp3PGtG/e0xeDCElL04DZwpP+2qTCWfa CcZKQ+8g1wn/4Jfv9ktCBN0NK5K9k4W7x1cQ6FwhoAJVLF2wsNycPQnTR1XNRf8q27iE 8VoNVc1ebr15Jyef9wQ9YcxkbAMKu/z7bRc4s5BtfiUaTRtjAuqNyLjdwXpMw6/k2b7e 4oHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DYP+VRvQlh5nLqtB5n7p+NxqSwJDzGB5vCCr+HdgsIA=; b=dWAihsvj3kUfIWJb97z26gM4ais+oqAObAiNgL3ws/+hsVzt0Yj8H+P4x34MX87BXE fnDj0NBKol0NxbsyHcjlcKHFrPISr89PmRBNy7HiPDi9ts23v1i/NgWgn4Ffx8e0IbYi 033VwvrLSsz/FmRb13CQ1ojmXcDIruueKBd9ANjF7RTiD9saUJJzv/ZIC72xf0NO0EuY l3SXWtQr1D2eZHjZoTjUPtWqC8+nPC+PXjylHYMeO+U9cJw0WcOzGKqRhkWNy7guJkdo 2yy9SbazbGYq32w8KYDpGjVz6z+kTIjSVrM3PyQpAyzhXR7BfYQC/g7yszyvX7qK1yHa ntOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Wrl4q/Kx"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1si1733055edn.93.2019.10.03.10.13.34; Thu, 03 Oct 2019 10:13:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Wrl4q/Kx"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404340AbfJCRMG (ORCPT + 99 others); Thu, 3 Oct 2019 13:12:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:37432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391811AbfJCQaz (ORCPT ); Thu, 3 Oct 2019 12:30:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 342C82054F; Thu, 3 Oct 2019 16:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570120254; bh=kjUYmaBo4PVq9u9yyQ+YpRHxns2z/f+WYQMw69UXDSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wrl4q/KxobXgpiGq4E6WNgEWTgWdhnaIN54XkDA2cVfFqTRNxHdxGAUMAW/NsLMBm QisFkNaKvn4ZnJQEZ5kkObjAirfcAiul8d69NGKLkQGbY/oEAqXFNkSkrlP1YD8zmD FAUQ1p1+XXf8i2LH+u/jQD/TnEFMzahcAo8ZSImw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Douglas RAILLARD , "Peter Zijlstra (Intel)" , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.2 153/313] sched/cpufreq: Align trace event behavior of fast switching Date: Thu, 3 Oct 2019 17:52:11 +0200 Message-Id: <20191003154547.990264509@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154533.590915454@linuxfoundation.org> References: <20191003154533.590915454@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Douglas RAILLARD [ Upstream commit 77c84dd1881d0f0176cb678d770bfbda26c54390 ] Fast switching path only emits an event for the CPU of interest, whereas the regular path emits an event for all the CPUs that had their frequency changed, i.e. all the CPUs sharing the same policy. With the current behavior, looking at cpu_frequency event for a given CPU that is using the fast switching path will not give the correct frequency signal. Signed-off-by: Douglas RAILLARD Acked-by: Peter Zijlstra (Intel) Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- kernel/sched/cpufreq_schedutil.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index ae3ec77bb92f6..e139b54716b4a 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -117,6 +117,7 @@ static void sugov_fast_switch(struct sugov_policy *sg_policy, u64 time, unsigned int next_freq) { struct cpufreq_policy *policy = sg_policy->policy; + int cpu; if (!sugov_update_next_freq(sg_policy, time, next_freq)) return; @@ -126,7 +127,11 @@ static void sugov_fast_switch(struct sugov_policy *sg_policy, u64 time, return; policy->cur = next_freq; - trace_cpu_frequency(next_freq, smp_processor_id()); + + if (trace_cpu_frequency_enabled()) { + for_each_cpu(cpu, policy->cpus) + trace_cpu_frequency(next_freq, cpu); + } } static void sugov_deferred_update(struct sugov_policy *sg_policy, u64 time, -- 2.20.1