Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp70073ybp; Thu, 3 Oct 2019 10:17:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqw26WwdfKgiInZoQd5FtciBhU5ZhzEpYJgr2DKANEPR817r0fXoO4Wj8SrnAi6noLhaUIxw X-Received: by 2002:a17:906:8258:: with SMTP id f24mr8743870ejx.234.1570123069377; Thu, 03 Oct 2019 10:17:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570123069; cv=none; d=google.com; s=arc-20160816; b=p2pZBbOpvna2wqtileCf8d1Al+FDdPGeFuzHp7ausDTRnyEGHSZbdqvCqsGb8QGpKU 76Ba8Vp7w03PnTWfUUKLRSDyVy1dU0Eg0WCi07OAC/fb/abNhQEG0TZd0/z5HlEAXPqD pg/1jUxXkViHRAHhoOhN8RIXv4A8Fjo8+v9LI53uZQjzmwJ8A9+DVLuWdg5I2uOWg8hx cRf6P0MzziYcrLxkECJbP5EsioCSuvbR6hiZyI5/+Q9Ca3hr/wLPp7JkvEyhNCXcohXW 9Tn5dC4HziXgbNHutAPl1huB5k2AdbpVBNJbZG7/5YOZIuXhfrcEBRj/7wqpliBfZPBh T+aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TDW7ObRuBYMmIZZ93mk5Q1DDrDfYbZrPp8HtFejcCIs=; b=qA4jj5VcxZ5Tfih1adNLGp3Zq5O1eNc9N2gLGcltyeUZ1CjQ1Lr5zfQ5GXhJQN82Yp k986BQpVMUkE/b3slToFPDOZ8yK9p7cFPuCy4Si9Z1oUBqyQMIQVL6rFqF+68lOTQke8 u7fsbdLVCKivp5a31+NmEMDX68Lh0UTaUmNGwiK6I4cC9269zYV9CMRamf6DcJSYLL/t cysthfvMVYmU6SvhJcszjNzlQeoL6b0ByP/S+eeOtSL4Xy3bABugoiDnJMBDG7YPHlNt ou2Qs3h/sgUzmwvoFf88y68cfxnHd9/l6Xex2Y95AyH29TLnzYWn6mdD894FsjRvCfM6 r9vw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HXoHQk+v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u27si1560361ejb.172.2019.10.03.10.17.24; Thu, 03 Oct 2019 10:17:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HXoHQk+v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391032AbfJCRQB (ORCPT + 99 others); Thu, 3 Oct 2019 13:16:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:55014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729193AbfJCQZC (ORCPT ); Thu, 3 Oct 2019 12:25:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 264552054F; Thu, 3 Oct 2019 16:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119901; bh=SGCl/7o3pIUVUon5GSr1I0zVFIJ8Ua8QgL4bkQYqCIs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HXoHQk+vP1RMK0LMKKJ5gpcS2ZFbtsgSBtxbp7HJyjFVEcLKRUs6qkCLA/AaQP5lq qJGdOhM41RNSgDeJOaKJ9zlzbzrL9v+3keRZmY2jDu6dGrT9konNA9lgh35c9zWvKT unSN1jXQrs5QOk5xQYFPxu8DgNkpQdW8iOZFS678= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Ahern , Patrick Ruddy , "David S. Miller" Subject: [PATCH 5.2 023/313] vrf: Do not attempt to create IPv6 mcast rule if IPv6 is disabled Date: Thu, 3 Oct 2019 17:50:01 +0200 Message-Id: <20191003154535.650544593@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154533.590915454@linuxfoundation.org> References: <20191003154533.590915454@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Ahern [ Upstream commit dac91170f8e9c73784af5fad6225e954b795601c ] A user reported that vrf create fails when IPv6 is disabled at boot using 'ipv6.disable=1': https://bugzilla.kernel.org/show_bug.cgi?id=204903 The failure is adding fib rules at create time. Add RTNL_FAMILY_IP6MR to the check in vrf_fib_rule if ipv6_mod_enabled is disabled. Fixes: e4a38c0c4b27 ("ipv6: add vrf table handling code for ipv6 mcast") Signed-off-by: David Ahern Cc: Patrick Ruddy Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/vrf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/net/vrf.c +++ b/drivers/net/vrf.c @@ -1153,7 +1153,8 @@ static int vrf_fib_rule(const struct net struct sk_buff *skb; int err; - if (family == AF_INET6 && !ipv6_mod_enabled()) + if ((family == AF_INET6 || family == RTNL_FAMILY_IP6MR) && + !ipv6_mod_enabled()) return 0; skb = nlmsg_new(vrf_fib_rule_nl_size(), GFP_KERNEL);