Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp99506ybp; Thu, 3 Oct 2019 10:44:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqy1eVl8LFB+TEYsRuQ2V7K+TfB5sfnAoIEEJ4DU2/L/reVo32pAZTHIWh6pPDGdJjZOXuuY X-Received: by 2002:aa7:d4c5:: with SMTP id t5mr10788658edr.154.1570124696258; Thu, 03 Oct 2019 10:44:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570124696; cv=none; d=google.com; s=arc-20160816; b=gy/2uZ+hqrueR2gRFj4+G0xFEx+efOSNs9emTrTnenWSBz6+nmTvARXDM9BTCEZ2JP 42SIa8qUqkXpGQKVP5PKtJsbFubft2aUOV5FTyrh80kYdsgIMnqQSHSFG0gwTJOfpK9o KuilmDv97Oxr71B85+EUgK//tnNsZ94GKRnJAu0Z7w3rWeMJNAUbcc0mo/2WjzB9cHyx ABUAwLIRqVEVxNonuvirvzAtLTc4w+r8XNCV+2RxjciJ5jUrobI+9srN69VDoWzeaP+B WTPF1biQxna2ifG9XTCd1uBSHMPvpZ9aZ5BpyH3mQGWzsrp4K+tP1u3H9Zyv4UxUmn4b +G2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fQP8AimhDYUeTRdEH9Pau5Q3c9xy61DdLW9i+EECBUs=; b=XPdLODevYMkT31vJlvoQvsL1stdVjLZ9Igtz/gqi7cWWQFqoIS4x0/En/JYCSSRP3A sdwc/VP0qTEiCfSQVjquC+a7N/+RxwfnGuybzgQLtD2KLchh3tu0EfORSz/0Ud6DZgQ9 GSV2O5O8M9Up1Q66e0QvMAEKiRKNdfRJzV0AEC3vXx9/zc/0KjIDD3ij83isoTWKnpWo pCGYCTyyiyrjvIwzEBghaOXrNGbFYqAKnmy8cJzXbiA4nj4ajHciS3TckGrhfEPVVkLZ +Qzqk1R8gC0KzYWwonbF+L3iw0ZuKC3n1Q0pUAveTD0NvngkwTg8iR1a3GIV27PfrLb4 fBOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iCY1m51w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e4si1784743edy.295.2019.10.03.10.44.31; Thu, 03 Oct 2019 10:44:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iCY1m51w; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731771AbfJCQPj (ORCPT + 99 others); Thu, 3 Oct 2019 12:15:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:39850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731470AbfJCQPg (ORCPT ); Thu, 3 Oct 2019 12:15:36 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5935D20700; Thu, 3 Oct 2019 16:15:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570119335; bh=CQg4llB20lc/ODXXWRGsZEH6sxP9m4w2YL2WQYMk5UM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iCY1m51wIMuYl4w2ikygrhzlso9ErUOCQTxJoM3BJq1jEGoHBuEaToiVP2GcSeozT LG751b6a/EbrzTcUr+EEZ2gslo1CSpEPjok0tjvSjMq/MDsuLUCklwWm8svB5ejnEv MX77n0PbjkJmEE9M2vOC/tZ/2GXDM7obErsaEjvU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oleksandr Suvorov , Marcel Ziswiler , Igor Opaniuk , Fabio Estevam , Mark Brown , Sasha Levin Subject: [PATCH 4.19 027/211] ASoC: sgtl5000: Fix of unmute outputs on probe Date: Thu, 3 Oct 2019 17:51:33 +0200 Message-Id: <20191003154453.387351130@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154447.010950442@linuxfoundation.org> References: <20191003154447.010950442@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oleksandr Suvorov [ Upstream commit 631bc8f0134ae9620d86a96b8c5f9445d91a2dca ] To enable "zero cross detect" for ADC/HP, change HP_ZCD_EN/ADC_ZCD_EN bits only instead of writing the whole CHIP_ANA_CTRL register. Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler Reviewed-by: Igor Opaniuk Reviewed-by: Fabio Estevam Link: https://lore.kernel.org/r/20190719100524.23300-6-oleksandr.suvorov@toradex.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/sgtl5000.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 60764f6201b19..f9817029bffbb 100644 --- a/sound/soc/codecs/sgtl5000.c +++ b/sound/soc/codecs/sgtl5000.c @@ -1280,6 +1280,7 @@ static int sgtl5000_probe(struct snd_soc_component *component) int ret; u16 reg; struct sgtl5000_priv *sgtl5000 = snd_soc_component_get_drvdata(component); + unsigned int zcd_mask = SGTL5000_HP_ZCD_EN | SGTL5000_ADC_ZCD_EN; /* power up sgtl5000 */ ret = sgtl5000_set_power_regs(component); @@ -1305,9 +1306,8 @@ static int sgtl5000_probe(struct snd_soc_component *component) reg = ((sgtl5000->lrclk_strength) << SGTL5000_PAD_I2S_LRCLK_SHIFT | 0x5f); snd_soc_component_write(component, SGTL5000_CHIP_PAD_STRENGTH, reg); - snd_soc_component_write(component, SGTL5000_CHIP_ANA_CTRL, - SGTL5000_HP_ZCD_EN | - SGTL5000_ADC_ZCD_EN); + snd_soc_component_update_bits(component, SGTL5000_CHIP_ANA_CTRL, + zcd_mask, zcd_mask); snd_soc_component_update_bits(component, SGTL5000_CHIP_MIC_CTRL, SGTL5000_BIAS_R_MASK, -- 2.20.1