Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp171685ybp; Thu, 3 Oct 2019 11:49:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqyFLq8geiM89Dlke5pmLlqGZKqAmzgj4aWt7PP/954VS/quWE0tp+UBRa3zem/iuJFly5ce X-Received: by 2002:a50:baab:: with SMTP id x40mr11268727ede.60.1570128548602; Thu, 03 Oct 2019 11:49:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570128548; cv=none; d=google.com; s=arc-20160816; b=JsSD7pDUrNFNLA1ximQYUi8LjXxnJgRPAHmjvAAukQoKYtWpYeTswAlr+OwHbitRk+ AEpL/ZPo/TBPdFPXwnQzRtJ99aVhBtX/38wjB8Uy/9hfXgjlKgSKxS92nzXw91x1BEW5 bfjkcU3AO3l4iXOgegQIYxibnBwk7GvSvUaxuEZnACQXRBJOAp3ao6xcIuFzcwZuA1dD Lvt7NjTlRS3t/R7StKr61b7zlxRvrMUBw0TCFHZBdgQ4dwXm0KfrzHwucOWOhQiHlgwo HmUGQIZ6GKqug/oDr4J7b1Vj7cVmELEM2H7cUWW//fI9bM2fLnjc7xGxGW/VZaM0Mp2p 61xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0U8Awkg0zNL5V4mIwsjps4IH+GA9FbgmfZEbWiDhdvw=; b=e9zcjo4GnF3tdVB6LVPcRoTuE8OcKG0ZyXs5AVg/UpQFRS7m+9gbKDdvmqvJ6CJ+GY Ea3tyJhHPqzyh/z0XuLnSfnBpei0LkPFEGl+lvPPU9WbehcqeO65mctsBd6eGAQ+ze/h 08VL3P4wr02LW2XrM6aPuVydz9nkUp9Ov3FFxMk/A2uc7BxjX19riPww74Hq10XKjDhg Dzo/uc3Pr1p4l94TsJ+6fDz4EL0wof7ZuKWYE/Dl1lPQ0Bxabg2lB7um7wYZqmrbNI8Q XmrHwkpGuTDOHggu/9CGrnEnVspj7JvMZADJD1gd0qfLWyN9kUD7L0mATIhaktMLsvCI 17GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KnmQfs6L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w10si1983624edv.21.2019.10.03.11.48.44; Thu, 03 Oct 2019 11:49:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KnmQfs6L; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731201AbfJCP6O (ORCPT + 99 others); Thu, 3 Oct 2019 11:58:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:40788 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731121AbfJCP6G (ORCPT ); Thu, 3 Oct 2019 11:58:06 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E4E3A207FF; Thu, 3 Oct 2019 15:58:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118286; bh=pZ1IASF9d/Y4XARYyRxy4jTltUQmOJQtiwj8C4rEhKs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KnmQfs6LSkO+IbVr6gJpcuYl5XZKlYQwgevL1Wc3bciwjvxipgoTwGQinv1XBRXDg mRkJ8dGNm38MOt6edn0tfbW1+3uG9sm7PzrWKzLyWd04dYozyn6DggSIfu66zCVoNO iXZSQ1Vvtdddz03eFKNoPs3s5pBpXWEVJp30Gi9Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , syzbot+79d18aac4bf1770dd050@syzkaller.appspotmail.com Subject: [PATCH 4.4 57/99] media: hdpvr: add terminating 0 at end of string Date: Thu, 3 Oct 2019 17:53:20 +0200 Message-Id: <20191003154323.661511488@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154252.297991283@linuxfoundation.org> References: <20191003154252.297991283@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil [ Upstream commit 8b8900b729e4f31f12ac1127bde137c775c327e6 ] dev->usbc_buf was passed as argument for %s, but it was not safeguarded by a terminating 0. This caused this syzbot issue: https://syzkaller.appspot.com/bug?extid=79d18aac4bf1770dd050 Reported-and-tested-by: syzbot+79d18aac4bf1770dd050@syzkaller.appspotmail.com Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/usb/hdpvr/hdpvr-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/hdpvr/hdpvr-core.c b/drivers/media/usb/hdpvr/hdpvr-core.c index 924517b09fc9f..7b5c493f02b0a 100644 --- a/drivers/media/usb/hdpvr/hdpvr-core.c +++ b/drivers/media/usb/hdpvr/hdpvr-core.c @@ -143,6 +143,7 @@ static int device_authorization(struct hdpvr_device *dev) dev->fw_ver = dev->usbc_buf[1]; + dev->usbc_buf[46] = '\0'; v4l2_info(&dev->v4l2_dev, "firmware version 0x%x dated %s\n", dev->fw_ver, &dev->usbc_buf[2]); -- 2.20.1