Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp172213ybp; Thu, 3 Oct 2019 11:49:39 -0700 (PDT) X-Google-Smtp-Source: APXvYqy1piLZpyYJwbb9xTub7xCIMSeSnUts8+QUVZ8DD3GJsOCu5SaaA5U5D1fJAcyAIs6QBy4E X-Received: by 2002:a50:a939:: with SMTP id l54mr11153122edc.214.1570128579771; Thu, 03 Oct 2019 11:49:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570128579; cv=none; d=google.com; s=arc-20160816; b=w9DspGZ8dspT+pxkt3aP43YF741abMoGiMLyKeLmYapzPZpK211HHIUY6jcCr5tbCl A9eUPmv6+q9P59BN9ZfIcox0Posa3F6ZjK2zvyo+sZ2mtRgISiwVM04w5ExuroqgFo5B iRFm7AtWVrLHA+YB5xB9UtuoBRqibf+i3Vta/1vQq4+hcow7HXGzV8aFGNSWr+i5HVSm wqNM4aXxQhZT3BvCaZi6nTfYIcwJxkNSK3PQ34FmfpxTGuZv5qKHgGKVV2WiC2kzuG9X pCDX15gh9/w6q989er53UFXykksidsRArmhUv5BCWP/yhIyynLxL2qHKzXX/5IthyHF6 o12A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ne39jbjgwB5nYTWWTK9G97B9nwmaRPx52S5/MWd4Bcg=; b=yJhhhLU1OHqktVNq9MIJjgz9RJUNPxMm46uIPbWubUwBqFD0JdRRdAFuVm1Nq/BAvr gdScyfRR6EQEAAHJBd71VeQYAukW96fkpE4H20nuLN61F8zt1XCMxXeHCcKe0omZWgsB lOCHyQxq+MKRcdzR88Uq+MP0vDDFpIzkxyxaUPYheLUfNMh3Kk0kUsMD0OXgV3qkjtTV olsfSeUBqp3wgO7EC9mTHjkUQbEkFHn9iOO61e+Yvy5gmvs0U1hLLzuqlXZ/lkTXTey7 1frNLgmZgWgK5HeDvEFgUge0bRXHRquCOV0+k9K0uAZ5thK1sTNOwjGSnRtsvkMqGnQ4 VqVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tA1D6d7l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y6si1667029ejj.113.2019.10.03.11.49.15; Thu, 03 Oct 2019 11:49:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tA1D6d7l; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390193AbfJCRlu (ORCPT + 99 others); Thu, 3 Oct 2019 13:41:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:40588 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731065AbfJCP56 (ORCPT ); Thu, 3 Oct 2019 11:57:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 824E821848; Thu, 3 Oct 2019 15:57:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570118277; bh=hitQ1mfnHXHFIbbLDqW+Nr4SjYwep00BuZcM0jTnrT4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tA1D6d7lERqhsvuanOKhM9u5kbrSQHpiGIVmOJLNAsJAaUX1XCHZNGtF2olBGVcuJ u1oCoTbkaDP0RX61ul8e4AW6nabVuZVmXVTC1YWfguVFDTBMVVyfnotagvfIm9luAp zQHreOsQUGdislqtRU/A8cW+avX8KwY6Of39ofYA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sakari Ailus , Laurent Pinchart , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.4 54/99] media: omap3isp: Dont set streaming state on random subdevs Date: Thu, 3 Oct 2019 17:53:17 +0200 Message-Id: <20191003154322.690737905@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191003154252.297991283@linuxfoundation.org> References: <20191003154252.297991283@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sakari Ailus [ Upstream commit 7ef57be07ac146e70535747797ef4aee0f06e9f9 ] The streaming state should be set to the first upstream sub-device only, not everywhere, for a sub-device driver itself knows how to best control the streaming state of its own upstream sub-devices. Signed-off-by: Sakari Ailus Reviewed-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/platform/omap3isp/isp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index 136ea1848701d..f41e0d08de93e 100644 --- a/drivers/media/platform/omap3isp/isp.c +++ b/drivers/media/platform/omap3isp/isp.c @@ -917,6 +917,10 @@ static int isp_pipeline_enable(struct isp_pipeline *pipe, s_stream, mode); pipe->do_propagation = true; } + + /* Stop at the first external sub-device. */ + if (subdev->dev != isp->dev) + break; } return 0; @@ -1031,6 +1035,10 @@ static int isp_pipeline_disable(struct isp_pipeline *pipe) isp->crashed |= 1U << subdev->entity.id; failure = -ETIMEDOUT; } + + /* Stop at the first external sub-device. */ + if (subdev->dev != isp->dev) + break; } return failure; -- 2.20.1