Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751646AbWADJw4 (ORCPT ); Wed, 4 Jan 2006 04:52:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751647AbWADJw4 (ORCPT ); Wed, 4 Jan 2006 04:52:56 -0500 Received: from sunrise.pg.gda.pl ([153.19.40.230]:64220 "EHLO sunrise.pg.gda.pl") by vger.kernel.org with ESMTP id S1751602AbWADJwz (ORCPT ); Wed, 4 Jan 2006 04:52:55 -0500 To: "Andrew Morton" , "Jiri Slaby" Cc: linux-kernel@vger.kernel.org, greg@kroah.com Subject: Re: [PATCH 1/4] media-radio: Pci probing for maestro radio References: <200500919343.923456789ble@anxur.fi.muni.cz> <20051231161634.422661E32EE@anxur.fi.muni.cz> <20060104014532.3909a51e.akpm@osdl.org> Message-ID: Date: Wed, 04 Jan 2006 10:51:57 +0100 From: =?iso-8859-2?B?QWRhbSBUbGGza2E=?= Organization: =?iso-8859-2?B?R2Rh8XNrIFVuaXZlcnNpdHkgb2YgVGVjaG5vbG9neQ==?= Content-Type: text/plain; format=flowed; delsp=yes; charset=iso-8859-2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In-Reply-To: <20060104014532.3909a51e.akpm@osdl.org> User-Agent: Opera M2/8.51 (Linux, build 1462) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1048 Lines: 31 Dnia 04-01-2006 o 10:45:32 Andrew Morton napisa?: > "Jiri Slaby" wrote: >> >> + retval = video_register_device(maestro_radio_inst, VFL_TYPE_RADIO, >> + radio_nr); >> + if (retval) { >> + printk(KERN_ERR "can't register video device!\n"); >> + goto errfr1; >> + } >> + >> + if (!radio_power_on(radio_unit)) { >> + retval = -EIO; > > Shouldn't we unregister the video device here? Current behaviour means that device is here but not functioning properly but we can unregister it of course because it is useless anyway ;-). Regards -- Adam Tla?ka mailto:atlka@pg.gda.pl ^v^ ^v^ ^v^ System & Network Administration Group ~~~~~~ Computer Center, Gda?sk University of Technology, Poland PGP public key: finger atlka@sunrise.pg.gda.pl - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/