Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp22460ybp; Thu, 3 Oct 2019 14:11:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqyrdVLPMhpYTPBHX+FRmj3CsgDRJDYuhzkPv4XXx4HZTGFzyKPOLMP/65idDspUaKmA0NVy X-Received: by 2002:a50:af26:: with SMTP id g35mr12069571edd.129.1570137070904; Thu, 03 Oct 2019 14:11:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570137070; cv=none; d=google.com; s=arc-20160816; b=SU4kTe8D93jrk8zeU/kUJC0tEH20F4fbpjqi7HBwRFfsfyVg+4d9Bf38HTfl+uQvf/ QnjW3NA8fSPWPSqMYSbZImMdUhQpgmFsl6RmiUOQCWmyhfcrt1g8ZOTR6kMokYUj+nGn DzIcY/JLIuroac2Ao2lkPlXyN8Xle34YytBbcRUYPlJIBgQ1UU7R/nDqvsb2gZMq99zg zAeSXBvKAZl5GJgS+ybwfUFI3pFuTSVtGinax2b1hQEm9x3C4hodDDSEjy0Nqm/8J0p7 N1RkEwuuQ7KlsCdAOFc7CvSORuQxaiGJCgQ/6a+R271Bq71xH1rPfh6JetPxLGwqikzr 8HpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=hzsRhAwi7rvC+ywX0qPy7ktz/B/4U4qXzErB5v5PB6Y=; b=NmTP977uhpXIJh9nR+fJHkxxVXCoNcqo/4J9ojdN+NSknfXLfBHde/nLd2R8omA0Aw 3FjLlaEkAwayZz/SlKBTI5a8HOfbcRMtaxVGa/eB6G0P4fk0GF545576yd/sabBDxOdn hoTilTzhxshBkIGzchhk6UHNvKSc5HLiqLQtO4VsOzp1bBXoGQnju3EeyxWFlE90pl/T Z+8aerruM+j1a0mEEdD2PllzjOA7SJouSsG08EjnxX/Ad3bZYMROGYKoghOfLgI4Y63f Bx6D+1zqdk32puQXK3HxXt0NiUABut1rvBEoO/ToiY2xPE7dIr8fa71WDAtI9vaU9EdH 1/iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oabMIHhn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c24si2266036edt.364.2019.10.03.14.10.43; Thu, 03 Oct 2019 14:11:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oabMIHhn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731148AbfJCVJr (ORCPT + 99 others); Thu, 3 Oct 2019 17:09:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:49296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727789AbfJCVJq (ORCPT ); Thu, 3 Oct 2019 17:09:46 -0400 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B331D20862; Thu, 3 Oct 2019 21:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570136986; bh=ebtTzy1JZkgeZmqVXSOzAKS+6uZXcSAohkg+1FReh1s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oabMIHhnfum50A1BjidbQuyquD+uFCBlGFB0Bab6JpNTL7F8MW0UTaES5FXOISuYm MjpdvPh2wknpvXwoPwDkI9Kvn7cBo6gvaE7SeXGmgATkUqgyZVfWSYbZWCTcLS4iY1 VqX3mxaeafXyjgU6Pzo7IaMLRrP2ZyAcV25Qslxc= Date: Thu, 3 Oct 2019 22:09:41 +0100 From: Will Deacon To: Douglas Anderson Cc: Catalin Marinas , Jason Wessel , Daniel Thompson , kgdb-bugreport@lists.sourceforge.net, Christophe Leroy , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] kdb: Fix "btc " crash if the CPU didn't round up Message-ID: <20191003210941.ulbnglhhx7nevsfm@willie-the-truck> References: <20190925200220.157670-1-dianders@chromium.org> <20190925125811.v3.3.Id33c06cbd1516b49820faccd80da01c7c4bf15c7@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190925125811.v3.3.Id33c06cbd1516b49820faccd80da01c7c4bf15c7@changeid> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 25, 2019 at 01:02:19PM -0700, Douglas Anderson wrote: > I noticed that when I did "btc " and the CPU I passed in hadn't > rounded up that I'd crash. I was going to copy the same fix from > commit 162bc7f5afd7 ("kdb: Don't back trace on a cpu that didn't round > up") into the "not all the CPUs" case, but decided it'd be better to > clean things up a little bit. > > This consolidates the two code paths. It is _slightly_ wasteful in in nit: in in Will