Received: by 2002:a17:90a:37e8:0:0:0:0 with SMTP id v95csp353485pjb; Fri, 4 Oct 2019 00:16:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqy0iuHCeiHgLRLbvaybO3hICxh3qI+e1Jeh2akyZ5Psfs9v9vl9tVuBFQD/Nfta4q1Gu/NG X-Received: by 2002:aa7:cf11:: with SMTP id a17mr13704981edy.153.1570173419426; Fri, 04 Oct 2019 00:16:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570173419; cv=none; d=google.com; s=arc-20160816; b=XJoj/F63YmOl4yfUeFg23YECpQcYBUB4fOW4EE9Myf1miPIauQFGJFiPrbS183a3gU Hf0s5Hdh3FDMtDXsE3De8WotIgp5RHT5i8w1YtiI4vfw0SjNtTkx4gVBxDyNJpLv0Tyd RoOHHdjHHrMKUY6cnlWtR6BCenZ/3NHYDgeu6sosmIYDXlemfEKcKgpYSKeMnd5MFuWE r/aU408xKpeu82kOa/O+IS5Dk53v87niLJomrrl4U2ht6aLmjQfy1XG8XcABZ7AvjOtF R8GjVNLvTNnBaPTGDCgA+WriNFofkIXJa5VwBNQFJMuu46euIczX0uzvoN1jWwrpKiav i8WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=reUwaIPrJ2en8kQXO+Z1gUpXyGSeQK7ida1UUgnALpo=; b=XZROY9KLx6jc+8Vw5XHlNG5KGvuDrlEJmkCOaS3y8o1XJ/tkpvfaF0G+Dv/zO4Nrvt SvMwy0kC0WqkpjYOIplDscarZVCJyBPu3kAzZEikiYRsYZHza0mdkaHfz9qgA4YcBLtn u/oMGFz4XaP8nLlv4wjqE0/yJsxlHUoGlXohzk+rwP92sy5VQ1HVtHZiEZDgMZn17wNs EyJlsFGribdJLu/LjJ5qFakYzJymRUcgAGgUKABuQG0kFL6XtwU6u8QqYX+b4ju8fC0j 796OLIxf8YRgHDfW/WSyy5gvqkzsF6Q/gXFG5oFIz2jk3h4JKpmwxKKa6VZRxvkdc+uw b0Wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e1si2893713ede.268.2019.10.04.00.16.34; Fri, 04 Oct 2019 00:16:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729951AbfJCWFa (ORCPT + 99 others); Thu, 3 Oct 2019 18:05:30 -0400 Received: from mga03.intel.com ([134.134.136.65]:41466 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726002AbfJCWFa (ORCPT ); Thu, 3 Oct 2019 18:05:30 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Oct 2019 15:05:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,253,1566889200"; d="scan'208";a="191396927" Received: from okiselev-mobl1.ccr.corp.intel.com (HELO localhost) ([10.251.93.117]) by fmsmga008.fm.intel.com with ESMTP; 03 Oct 2019 15:05:23 -0700 Date: Fri, 4 Oct 2019 01:05:22 +0300 From: Jarkko Sakkinen To: ivan.lazeev@gmail.com Cc: Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6] tpm_crb: fix fTPM on AMD Zen+ CPUs Message-ID: <20191003220522.GC30511@linux.intel.com> References: <20191002201212.32395-1-ivan.lazeev@gmail.com> <20191003120302.GB10038@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191003120302.GB10038@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 03, 2019 at 03:03:02PM +0300, Jarkko Sakkinen wrote: > You could get away without iores_range by having an extra > terminator entry in the iores_array. > > Overally this starts to look good. I'd also advice you to memset it with zeros so that you don't need to have a variable for number of entries. /Jarkko