Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5d9682d5.1c69fb81.4efda.d786@mx.google.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1570061174-4918-1-git-send-email-mnalajal@codeaurora.org>
References: <1570061174-4918-1-git-send-email-mnalajal@codeaurora.org>
From:   Stephen Boyd <swboyd@chromium.org>
To:     Murali Nalajala <mnalajal@codeaurora.org>,
        gregkh@linuxfoundation.org, rafael@kernel.org
Cc:     mnalajal@codeaurora.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH] base: soc: Handle custom soc information sysfs entries
User-Agent: alot/0.8.1
Date:   Thu, 03 Oct 2019 16:22:59 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Murali Nalajala (2019-10-02 17:06:14)
> @@ -121,6 +118,7 @@ static void soc_release(struct device *dev)
>  struct soc_device *soc_device_register(struct soc_device_attribute *soc_=
dev_attr)
>  {
>         struct soc_device *soc_dev;
> +       const struct attribute_group **soc_attr_groups =3D NULL;

Don't initialize this to NULL because it is only tested after it's been
unconditionally assigned to the result of the allocation.

>         int ret;
> =20
>         if (!soc_bus_type.p) {
> @@ -136,10 +134,20 @@ struct soc_device *soc_device_register(struct soc_d=
evice_attribute *soc_dev_attr
>                 goto out1;
>         }
> =20
> +       soc_attr_groups =3D kzalloc(sizeof(*soc_attr_groups) *

Please use kcalloc() instead and drop the define for NUM_ATTR_GROUPS
because it's used once.

> +                                               NUM_ATTR_GROUPS, GFP_KERN=
EL);
> +       if (!soc_attr_groups) {
> +               ret =3D -ENOMEM;
> +               goto out2;
> +       }
> +       soc_attr_groups[0] =3D &soc_attr_group;
> +       soc_attr_groups[1] =3D soc_dev_attr->custom_attr_group;
> +       soc_attr_groups[2] =3D NULL;

Drop this assignment to NULL because kzalloc() and kcalloc() zero out
the memory anyway.