Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 03 Oct 2019 16:44:01 -0700
From:   mnalajal@codeaurora.org
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     gregkh@linuxfoundation.org, rafael@kernel.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        bjorn.andersson@linaro.org
Subject: Re: [PATCH] base: soc: Handle custom soc information sysfs entries
In-Reply-To: <5d9682d5.1c69fb81.4efda.d786@mx.google.com>
References: <1570061174-4918-1-git-send-email-mnalajal@codeaurora.org>
 <5d9682d5.1c69fb81.4efda.d786@mx.google.com>
Message-ID: <ce2f11601c3d2203069487b7bc2364d8@codeaurora.org>
User-Agent: Roundcube Webmail/1.2.5
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019-10-03 16:22, Stephen Boyd wrote:
> Quoting Murali Nalajala (2019-10-02 17:06:14)
>> @@ -121,6 +118,7 @@ static void soc_release(struct device *dev)
>>  struct soc_device *soc_device_register(struct soc_device_attribute 
>> *soc_dev_attr)
>>  {
>>         struct soc_device *soc_dev;
>> +       const struct attribute_group **soc_attr_groups = NULL;
> 
> Don't initialize this to NULL because it is only tested after it's been
> unconditionally assigned to the result of the allocation.
Done
> 
>>         int ret;
>> 
>>         if (!soc_bus_type.p) {
>> @@ -136,10 +134,20 @@ struct soc_device *soc_device_register(struct 
>> soc_device_attribute *soc_dev_attr
>>                 goto out1;
>>         }
>> 
>> +       soc_attr_groups = kzalloc(sizeof(*soc_attr_groups) *
> 
> Please use kcalloc() instead and drop the define for NUM_ATTR_GROUPS
> because it's used once.
> 
done
>> +                                               NUM_ATTR_GROUPS, 
>> GFP_KERNEL);
>> +       if (!soc_attr_groups) {
>> +               ret = -ENOMEM;
>> +               goto out2;
>> +       }
>> +       soc_attr_groups[0] = &soc_attr_group;
>> +       soc_attr_groups[1] = soc_dev_attr->custom_attr_group;
>> +       soc_attr_groups[2] = NULL;
> 
> Drop this assignment to NULL because kzalloc() and kcalloc() zero out
> the memory anyway.
done