Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 4 Oct 2019 10:35:37 +0800
From:   Changbin Du <changbin.du@gmail.com>
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Changbin Du <changbin.du@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] perf: add support for logging debug messages to
 file
Message-ID: <20191004023535.3ddpkym64xb2cvvl@mail.google.com>
References: <20190922023823.12543-1-changbin.du@gmail.com>
 <20190929073951.GA15099@krava.homenet.telecomitalia.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190929073951.GA15099@krava.homenet.telecomitalia.it>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Sep 29, 2019 at 09:44:07AM +0200, Jiri Olsa wrote:
> On Sun, Sep 22, 2019 at 10:38:21AM +0800, Changbin Du wrote:
> > When in TUI mode, it is impossible to show all the debug messages to
> > console. This make it hard to debug perf issues using debug messages.
> > This patch adds support for logging debug messages to file to resolve
> > this problem.
> > 
> > v2:
> >   o specific all debug options one time.
> > 
> > Changbin Du (2):
> >   perf: support multiple debug options separated by ','
> >   perf: add support for logging debug messages to file
> 
> hi,
> getting segfault with:
> 
> [jolsa@krava perf]$ ./perf --debug verbose=2,file report
> build id event received for [kernel.kallsyms]: bf6ca14c03795fd67b4d88113681ba4af2b8c18a
> Segmentation fault (core dumped)
>
Hmm, this because the va_list variable cannot be used twice. I resolve this by
making stderr and file options exclusive.

> jirka
> 
> > 
> >  tools/perf/Documentation/perf.txt |  14 ++--
> >  tools/perf/util/debug.c           | 106 ++++++++++++++++++------------
> >  2 files changed, 73 insertions(+), 47 deletions(-)
> > 
> > -- 
> > 2.20.1
> > 

-- 
Cheers,
Changbin Du