Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: XBkX8ZpdaAc023avrluDnUXMaT3Y20EYmNWGXbT50+lIC0136jzREmaNl4c1yFd5OOH4ZIYdut
 RNT12D/xLa1uVSauCEZsPYcK/pDghLN9HOL41F4qE0SLTCfdVh3+vfpC16jGOl6fhbMjW1eUd/
 YI7WyP7CoCvhYmOIughyD+khC1XTCmuoVQLFtn3FsdnjdCEbF8ssQY8L0eTmtiYPFcON65vSYc
 S6rJAyH+SsIruPl72EZKJEXvKjFWiC9xQeH4I3JciMX/qkx9QeBZJrnK0x6l+hd4D1SNcu4Acv
 eHQ=
IronPort-PHdr: =?us-ascii?q?9a23=3AAmwN6hVmr76lcwfPn8D8vzCLZGHV8LGtZVwlr6?=
 =?us-ascii?q?E/grcLSJyIuqrYbB2Ft8tkgFKBZ4jH8fUM07OQ7/m7HzFYqs/c+Fk5M7V0Hy?=
 =?us-ascii?q?cfjssXmwFySOWkMmbcaMDQUiohAc5ZX0Vk9XzoeWJcGcL5ekGA6ibqtW1aFR?=
 =?us-ascii?q?rwLxd6KfroEYDOkcu3y/qy+5rOaAlUmTaxe7x/IAi4oAnLtsQanYRuJrsxxx?=
 =?us-ascii?q?DUvnZGZuNayH9yK1mOhRj8/MCw/JBi8yRUpf0s8tNLXLv5caolU7FWFSwqPG?=
 =?us-ascii?q?8p6sLlsxnDVhaP6WAHUmoKiBpIAhPK4w/8U5zsryb1rOt92C2dPc3rUbA5XC?=
 =?us-ascii?q?mp4ql3RBP0jioMKiU0+3/LhMNukK1boQqhpx1hzI7SfIGVL+d1cqfEcd8HWW?=
 =?us-ascii?q?ZNQsNdWipcCY2+coQPFfIMMulYoYfzpFUAsAWwChW3CePz1jNFnGP60bEm3+?=
 =?us-ascii?q?kjFwzNwQwuH8gJsHTRtNj6NqYSUOG1zKnVyjXIcvBZ2Tfn54jJbxsspvGNXL?=
 =?us-ascii?q?NwccXLyEkjCx/Jg1uLpIz4IzyVzP4BvHaG4Op9TO+ijXMspQJpojW32Msglo?=
 =?us-ascii?q?3EipgWx13E7yl13Yc4KN+iREN6ZdOpFoZbuTuAOItsWMwiRnlluCM9yrIbp5?=
 =?us-ascii?q?G2ZDMKyJE7xx7HbPyHbpSI7grjVOmPJTd4g2poeLeliBaz9Uis0+n8Vsep3F?=
 =?us-ascii?q?pToCpIk93BumoC1xzU7ciHRf998Vm71TmT0ADT7/lIIUEylaXFN54s2qA8mo?=
 =?us-ascii?q?YXvEjZHSL7mF/6gLKXe0gm4OSl6uDqbq3jppCGNo90jg/+Mr4pmsy6Gek5Mg?=
 =?us-ascii?q?kPX2iB9uS9yLHv4UP0Ta5XjvIqiKnVqo7VKtkGpqKhGQ9azp4j6wqjDzehyN?=
 =?us-ascii?q?kYmXgHLFRYeBOIloTpOE/BIOr+Dfihh1Shiylrx//YMb37GJnNLWbMkK3nfb?=
 =?us-ascii?q?lj705Q0g0zzcpQ58EcNrZUG//5U1TttdXeRiU0Mge0zuKvXM5n26sdVHiJD6?=
 =?us-ascii?q?vfN7nd5xvA4uMpPvnJfIo9pjnwMb4m6uTogHt/nkUSOeGt3J0KeDW7E+5gLk?=
 =?us-ascii?q?Gxf3XhmJECHH0Msw54S/blzBWwUT9CenD6ZqM14HlvGoKnHJrFX6imm/qc1z?=
 =?us-ascii?q?39E5FLMCQOIVCBF3j5as2/XPEDIHaZOchnnRQPTv68QJVn2B2z4lzU0b1ie9?=
 =?us-ascii?q?vV6C0FstrR1NF0r7nChxE79GQsVOyA2HvLQm1pyDBbDwQq1bxy9BQugmyI1r?=
 =?us-ascii?q?J11rkBTYRe?=
MIME-Version: 1.0
From:   Yizhuo Zhai <yzhai003@ucr.edu>
Date:   Thu, 3 Oct 2019 21:21:44 -0700
Message-ID: <CABvMjLTicqk-ncY18j=UCZhCCugTVkPWKjkWZj9yEccUp3m8XQ@mail.gmail.com>
Subject: Potential uninitialized variables in power: supply: rt5033_battery:
To:     Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Zhiyun Qian <zhiyunq@cs.ucr.edu>,
        Chengyu Song <csong@cs.ucr.edu>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi:

drivers/power/supply/rt5033_battery.c:

In function rt5033_battery_get_present(), variable "val" could be
uninitialized if regmap_read() returns -EINVAL. However, "val" is
used to decide the return value, which is potentially unsafe.

Also, we cannot simply return -EINVAL in rt5033_battery_get_present()
because it's not an acceptable return value.

Thanks for your time to check this case.

-- 
Kind Regards,

Yizhuo Zhai

Computer Science, Graduate Student
University of California, Riverside