Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp903562ybp; Fri, 4 Oct 2019 06:49:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqyDaW4Fw3a6aOQlgprjJkg1EjKu/TDdjoJuE4CG6h/srd++pLt8nkE0e0H3tuhA7uTjQGMh X-Received: by 2002:a05:6402:1212:: with SMTP id c18mr15383388edw.259.1570196955257; Fri, 04 Oct 2019 06:49:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570196955; cv=none; d=google.com; s=arc-20160816; b=qrXZG6rPIbVYPteUip4dlyZl5TfghhmMFxCCl5VFknLVY5TN+Bnp7uwmhssRtuexn+ ZtrZQR20Ml6Oo0yfctzG8JUKmQAJ12gYCu4ZeNw/xUbthssYovIzSepv9Z+zfd3rJWWJ Ws1Sl8pG4gu/GNpmpq9wrWBk5bG3p6eyrWiR0AVquEJsmZhXLSQh3uyNOWNgqDoKMz3N 7NLLpRF3Ht2L49cw5lYiLd8fYJdYhw5tuLkP1shNI3JFOB42KanyC90m2uXo2Q1e+BRR lHJm5/RjOPuE4jRu4kAhS3+NleGR66XQWe3q4ozOE2mGRnCuK1o7Ev8BNNXGV9eCuufW IUhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=BfJTUrzzAEhOexwav88IVAacGmfy2NnGX8d35CxOIMo=; b=vun2L1vtE5eOHkcxEsxhlVGVU7OixH5EsM9K4NqvNgBBQ3FntjUW9F3DJJHOU4DEDq Y6QC+hLROWFNBAqCn/4/Et4xvbNuLWFyjq3iRx4H5os7Ty4SVwwcS8eO9Z9eoNA8FtAr u9Z6IQ6W0x/D6roq06e+rdBf7zgVCu1N8WHZNdkkcOIeeDcDwS5z+LjWIZNYBBZ+udOj VznY/EJCz042IBF2b78AwoeEpgtd3Xu9rFNn8oJII13pKSr1TtRbAmLbP/YB0jDvxcz/ p0DOM++7ckMW9X0TRtd7/JiPjCl4x8Xu+I90A7eh+EwRA5MTtOeCdmLsRpusGb/3R1e5 ysCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=jNOBjg77; dkim=pass header.i=@codeaurora.org header.s=default header.b=ESd3wgaB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id op27si2922162ejb.253.2019.10.04.06.48.50; Fri, 04 Oct 2019 06:49:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=jNOBjg77; dkim=pass header.i=@codeaurora.org header.s=default header.b=ESd3wgaB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388880AbfJDNrh (ORCPT + 99 others); Fri, 4 Oct 2019 09:47:37 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51540 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388438AbfJDNrh (ORCPT ); Fri, 4 Oct 2019 09:47:37 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2D517619F4; Fri, 4 Oct 2019 13:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570196856; bh=YTbkcIOSoT6sfkliDWftlO8oLXWgzNqKOEziTUyn0HU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=jNOBjg77Md9jO1ArgJgRIulK23TEMZaqZ/JV6WLuLYPcAFqvLwYV/wrUhKsdbZa4+ w5LGElS3knZUK4dg6HW4O6t6a/0zSuO2ftehftqW3qQTHvWkSwaLXZ9pn86g47c82J HQLKAoo1QS7TwMt4KXNd4OicHVBiI7ipjxfJor+Q= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 28C4A6081C; Fri, 4 Oct 2019 13:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1570196855; bh=YTbkcIOSoT6sfkliDWftlO8oLXWgzNqKOEziTUyn0HU=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=ESd3wgaBuhMt7Vw0LAcQG80pZLg82sIGccWfnpkFvmJvHKErgvVz/Gwg7OXZMo5M+ 2QkIUoWqLvWjT5dvTYuD+71vcJusxAhvcD6cEp3WP/XQEpGC9Nr0KI1Jot1RNOuFy3 7JvVAlt3hoq+UDbGBByU5Qq4YWhuDrZol0TMOWzM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 28C4A6081C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rsi: fix potential null dereference in rsi_probe() From: Kalle Valo In-Reply-To: <20191002171811.23993-1-efremov@linux.com> References: <20191002171811.23993-1-efremov@linux.com> To: Denis Efremov Cc: linux-wireless@vger.kernel.org, Denis Efremov , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Amitkumar Karwar , Siva Rebbagondla User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191004134736.2D517619F4@smtp.codeaurora.org> Date: Fri, 4 Oct 2019 13:47:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Denis Efremov wrote: > The id pointer can be NULL in rsi_probe(). It is checked everywhere except > for the else branch in the idProduct condition. The patch adds NULL check > before the id dereference in the rsi_dbg() call. > > Fixes: 54fdb318c111 ("rsi: add new device model for 9116") > Cc: Amitkumar Karwar > Cc: Siva Rebbagondla > Cc: Kalle Valo > Signed-off-by: Denis Efremov Patch applied to wireless-drivers-next.git, thanks. f170d44bc4ec rsi: fix potential null dereference in rsi_probe() -- https://patchwork.kernel.org/patch/11171695/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches