Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp924800ybp; Fri, 4 Oct 2019 07:07:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqzLyWD6o8IWIiGqzCKVt6MEi25aHFxQlHWQZJFFlCTFgDkLwqggGcHsodUo9TWry9i8WYo7 X-Received: by 2002:a17:906:57ce:: with SMTP id u14mr12590544ejr.184.1570198040100; Fri, 04 Oct 2019 07:07:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570198040; cv=none; d=google.com; s=arc-20160816; b=DGPRQUQFAmgdu3JH7GS0FkXqh/Xc1pI5TCXnFAb1FZ2s91kb/X6tKpiiEf+bxve/dk XE/rFyEj9dzZ3UD1rpPolHBlUGl6A8Bys6UaGKELac1fkWx8o5BeuCw5qdRdmN0WdEgy RgcwiEltJX9QOG7TKWDi/aL5Hl/BaUPeBOwKFQRT7pLAvE0IByKpHTUeBWOvIQVM/GWk rI+CGKc5ZciTlJurYUpT9a0hoT7vtHoD+e8DlAVxAuKshoVwyneumh99stkzyMvvYkuD 9+S4qs41snDk5B59QvHDdQr+Aq+YBTi51OthwqytWFwFXT7SyG8dTHxugTgoc49+8iED GWKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=tJ+enjiw0qTMNSwdUMz2YW7UWK/wRJo2/Axq1O5DXYk=; b=xqpseX/U/bu5lmIpL3xSaRJ6HcxyO+O5t5g7ugXHhHSffe3DrB1KN9gs1M/WM1myy9 6hxljvA5qz832jMvY5K4aX82L91EXMX56rALASASDmUEJP0hnF6sS2QM9COnEISIbG3f +VklaWg/5y2mRmeXfGupOzYRKjeEcFNfgwwHdh4REU5KAqnmOr1cP39tISxyigTcb1QF qd8pupIsSQ53jus5matAyj4dYK2KQ/ZbmWb1z+wqjez8uxsuya6yTI8NWhwQ/tKJyr7e az+tsRpz0m+AwflVLyoYgt7LAZeGR0VR3e/akk3yPH27wFjFtS2lHxs1jvLf7XuPGdty shpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=xiJSchKd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v2si3713541edm.80.2019.10.04.07.06.53; Fri, 04 Oct 2019 07:07:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=xiJSchKd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388923AbfJDOEa (ORCPT + 99 others); Fri, 4 Oct 2019 10:04:30 -0400 Received: from mail-io1-f42.google.com ([209.85.166.42]:43456 "EHLO mail-io1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388270AbfJDOEa (ORCPT ); Fri, 4 Oct 2019 10:04:30 -0400 Received: by mail-io1-f42.google.com with SMTP id v2so13709441iob.10 for ; Fri, 04 Oct 2019 07:04:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=tJ+enjiw0qTMNSwdUMz2YW7UWK/wRJo2/Axq1O5DXYk=; b=xiJSchKdeSoi94+f/1x5VooggmYSkgd+2JeynPOaNao1uuFPY3STxV/NIyLQdAGXLL 7s0SjqBiNn2MkWL4Y4SsnGjvLlTibEZQb9VIFPDdKX9M/qtzMZ1G2yt/WWtKXpm2gvP1 52jEsBKRune2it9b64BpiPD5vhmwwXhjY0fvfOmoSTzjnLBMXow8aaC4WsbNOUGCGsaX C8JM/8Wi3kT2JwmFOUGD7Pi0OhnI/CsjBDETi7sT77RbbgxtOgM8r6fNlpiP1y/YRxFc lWlfBwJizFEmCNm3U76Czx1MmAZ5WxoDzNzdikTgvdUa/FmDXeV9YRPm6nOY9qegB6Az KTpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tJ+enjiw0qTMNSwdUMz2YW7UWK/wRJo2/Axq1O5DXYk=; b=oALopg0lg8/Kv7AGYtqOJrA8jyKtLgjYLuLqGtbPbjQ9LDavsxmoBf+fj7xgx21O49 Z51gOCnFLUl8Tv+zZkjKICxTae8ypdHLtvAuT088MQmEYgzcTw35rlfG+ddKdwygA+KJ RyxKd0E535J3ZLt/f7IXjtZE3Iw/G2orSiUQvIHFuIn5G49cKVLQ63eAkZJzZc015XUu VA0yxZddhPGT4xoq1Bdx+tUdA/FW0Ysm0Bhvj36WvS0rW/nMN9lBHdgOLcdm0JAsbRaO bk+ZSPVjFBBlUqtAPzJkejZVeSKeWDwBYN3sDq/Na+FsctL8+x9cO2jeBIDVCOmnw8q/ BTmA== X-Gm-Message-State: APjAAAUCNuO4HXUgi59etFzirjHtcnGBeiGXv91o6qwkJ2WpuW7hD0Nx DZTKAau8YDmz+s8uGCshHdwTiw== X-Received: by 2002:a92:d78c:: with SMTP id d12mr14803126iln.96.1570197869100; Fri, 04 Oct 2019 07:04:29 -0700 (PDT) Received: from [192.168.1.50] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id o8sm3101385ild.55.2019.10.04.07.04.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Oct 2019 07:04:28 -0700 (PDT) Subject: Re: [PATCH v3] io_uring: Fix reversed nonblock flag To: "Pavel Begunkov (Silence)" , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kbuild test robot References: <9752f33f509287c77801d5e807213cff9195197a.1570197234.git.asml.silence@gmail.com> From: Jens Axboe Message-ID: <063ca0ba-96ad-3552-50d3-7eb9f48499b6@kernel.dk> Date: Fri, 4 Oct 2019 08:04:27 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <9752f33f509287c77801d5e807213cff9195197a.1570197234.git.asml.silence@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/4/19 8:01 AM, Pavel Begunkov (Silence) wrote: > From: Pavel Begunkov > > io_queue_link_head() accepts @force_nonblock flag, but io_ring_submit() > passes something opposite. > > v2: build error from test robot: Rebase to block-tree > v3: simplify with Jens suggestion Thanks, looks good to me. Two minor notes that I fixed up: 1) The revision history should go below the --- line 2) I've added a Fixes tag -- Jens Axboe