Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1050197ybp; Fri, 4 Oct 2019 08:50:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqyyRltqfFc6Cn8M1Ng9MFAR5zqot4kJE9FFHPBF7iUIK/fdU84vrhRDw0ISuo4UXw8wWvdQ X-Received: by 2002:a50:eb8b:: with SMTP id y11mr15633957edr.200.1570204249629; Fri, 04 Oct 2019 08:50:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570204249; cv=none; d=google.com; s=arc-20160816; b=v/Zc62ycucYYbkwjNGOhGBFWK13AqF24A56vGdMm9NW9lf/7MnO96P73Xtt0jwaPNZ pyOcZjbno9xUxTzDboQoAztMUooUWds+ylB+yNEtZHLZKQCSV4jcwze/lVB5Mfy1Ziy2 pHE51jy6GsGtngkv86qr46e2fTPZKQF6U6TP35hamRgZQICfjItChYMw+aG1ulOOVwNi yGFzzMPko/+AkOCOcLwsQy9vEnIfWBmv653yLtrmg9mdy1fJ5iQaho4EOS/cnq4H/suH OckrhP5d5ivpSRUhrARY2xWTwxhkR1NxQgAzWkKXkkiDqLbfDd7HQ+nHBz8yBjGvYmKP 843w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=TWUc8iPBE5U2DRNaiiF8AJIn2O/nPjxk7jdF67P5Tsw=; b=0jDmrcUR2PEc0KcJOlZumgwkfYyq7AlaJ5VthEuE5zV3qIHF3BvxptWeF8KeKpeJS6 FS2h5PqwNYgli9xBTv/9su5VrfOgtLGotGb463VPDZpPvTECAd7p89kHZFkpyojgStuN bzMce3T3cN206b//n//NpvXiVdJQ/WexIDUBHhjEyhiNOZad2uhnNuqI5pfZd1E4Cxxi Uyt2pQb6gDpl8/i6aRbz/tnDZG/Y+pV3NB2SdU4bo4cQPCUyNx0tLqaG+Z8NvLgad4dS dok4ActMJkee92mADegOqcNgLEGNo9j4DFHRhagvrM4yxWBdKMsCRAjPxSPVGEqaeXHO cvIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l23si3260676ejr.296.2019.10.04.08.50.25; Fri, 04 Oct 2019 08:50:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389894AbfJDPtP (ORCPT + 99 others); Fri, 4 Oct 2019 11:49:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39612 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389773AbfJDPtP (ORCPT ); Fri, 4 Oct 2019 11:49:15 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C1412306085E; Fri, 4 Oct 2019 15:49:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B611460BF7; Fri, 4 Oct 2019 15:49:14 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A99C84E58A; Fri, 4 Oct 2019 15:49:14 +0000 (UTC) Date: Fri, 4 Oct 2019 11:49:14 -0400 (EDT) From: Bob Peterson To: aliasgar surti500 Cc: agruenba@redhat.com, cluster-devel@redhat.com, linux-kernel@vger.kernel.org Message-ID: <1944905967.4863703.1570204154537.JavaMail.zimbra@redhat.com> In-Reply-To: <20191002174631.15919-1-aliasgar.surti500@gmail.com> References: <20191002174631.15919-1-aliasgar.surti500@gmail.com> Subject: Re: [PATCH] gfs2: removed unnecessary semicolon MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.3.116.219, 10.4.195.28] Thread-Topic: gfs2: removed unnecessary semicolon Thread-Index: 5pT+PabUEhpG6HUEs4rjxCBeLgtPVw== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Fri, 04 Oct 2019 15:49:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > From: Aliasgar Surti > > There is use of unnecessary semicolon after switch case. > Removed the semicolon. > > Signed-off-by: Aliasgar Surti > --- > fs/gfs2/recovery.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c > index c529f8749a89..f4aa8551277b 100644 > --- a/fs/gfs2/recovery.c > +++ b/fs/gfs2/recovery.c > @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work) > > default: > goto fail; > - }; > + } > > error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED, > LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh); > -- > 2.17.1 Hi, Thanks for the patch. I did a quick search and found two more: glops.c- break; glops.c: }; inode.c- goto out_gunlock; inode.c: }; Do you want to include those in your patch and re-submit it or should I cook up a second patch? Regards, Bob Peterson Red Hat File Systems