Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1104424ybp; Fri, 4 Oct 2019 09:33:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqy6S3IUe533ZEFnPQG65C35UV26TKRN5t4bUm65zW+b+FcRtXjLVC6yHXicGXuGDIqKCjIS X-Received: by 2002:a17:906:5c0c:: with SMTP id e12mr5494911ejq.317.1570206801525; Fri, 04 Oct 2019 09:33:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570206801; cv=none; d=google.com; s=arc-20160816; b=XlQ+LMfUO9dvIA/dRwQac6tq0SN5OdTjy1zkI8hdztYFq1m+0CBlr2I5dfCchDlBgY 56GUVpAs03osSjclobZW/USNwfV0m5kM4wrSqUz28O0ChnrzswuecNPOAEDSC0fROuDj nGLiWOqd4pCibAso4TbzxUt1u1U0LWHMH/6sg7zK8RCPignE3dGY0ZFK/kLsF+jUO6c0 2HxAKVOc7XIqVsp5yy7KCxQ/n6mhyHY8hYItLUu6t9e8di8VOz3XFjAv81ShbBzBYRP4 HQ4mPIoFaia9AkDp3+fkIOr7fvBVqWMsaRBh9pkR5YZFQPZnuvA4py1kcsJ3BxE4mgzV /6mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Sse6Uy73madflKuWbNgCrD9bMqGehh0wa0re3aMKclY=; b=SI0HgF8Lh6cTaV+Sv86IanTZKBDRj7IKpE212zDZ4iZlPbxZ1BMSOD31LVqIS+8oKb tecjxl9jYXfi8TSErvuGv6ThODOvMltDJd96zWNDZz9A+lxLKivzzvbij2qiM8NM4ZfQ tfyHzPdEKhubP+iJq6l7UcwqZwrLWRaJlirOGlcU51g6caWmfexKjYZG1WhNUxv71mHR 9UZGrhK5Cd2JhkJ7Zv82cZH9EHl9Vd6XOuOu58XfEucS9mluIBtfqjGDdqFX5ylQ5SVK hNmAnl4uAnsUrgTkWv1/QRqbarNw6ZW15c9rXWLJ6d922Gq6Jy7VfFruFnSUr728E2c+ DiVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si3048200ejp.287.2019.10.04.09.32.52; Fri, 04 Oct 2019 09:33:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390289AbfJDQWA (ORCPT + 99 others); Fri, 4 Oct 2019 12:22:00 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:53603 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390164AbfJDQV7 (ORCPT ); Fri, 4 Oct 2019 12:21:59 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iGQL7-0007LQ-13; Fri, 04 Oct 2019 16:21:57 +0000 From: Colin King To: James Wang , Liviu Dudau , Brian Starkey , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done Date: Fri, 4 Oct 2019 17:21:56 +0100 Message-Id: <20191004162156.325-1-colin.king@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King The pointer disable_done is being initialized with a value that is never read and is being re-assigned a little later on. The assignment is redundant and hence can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c index 75263d8cd0bd..9beeda04818b 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c @@ -296,7 +296,7 @@ komeda_crtc_atomic_disable(struct drm_crtc *crtc, struct komeda_crtc_state *old_st = to_kcrtc_st(old); struct komeda_pipeline *master = kcrtc->master; struct komeda_pipeline *slave = kcrtc->slave; - struct completion *disable_done = &crtc->state->commit->flip_done; + struct completion *disable_done; bool needs_phase2 = false; DRM_DEBUG_ATOMIC("CRTC%d_DISABLE: active_pipes: 0x%x, affected: 0x%x\n", -- 2.20.1