Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1159685ybp; Fri, 4 Oct 2019 10:21:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqy/786VCi83nCqthEJTmDfvfSs59mh46+gN4RkpJ/PB3cXLuLkCTZ+NMof/9Ru1yx1qdSmT X-Received: by 2002:a17:906:3298:: with SMTP id 24mr13506011ejw.136.1570209671422; Fri, 04 Oct 2019 10:21:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570209671; cv=none; d=google.com; s=arc-20160816; b=yG5LJceiHYYWFIyy4SHTGdRVjRjMOnRjDp57x+qUGzUFUQShR5CAZb+o408I6oSFAn rZEKmW5meuBsJJfJDelwF18G6hhLhMKaMi3bVYNoPpBEDE59j1w76PXFtd2gPr9oPRrE +dg8qAWSmNVA6aY+iIz2wH33JtxSIEG1Fqa1z5Kq1xFhH169aZy08fm5pxyJw/c20VH4 sKP1R+jlT9NbzldcMpChuH/KpC0aChNoYo2tmm7PseocmR+E9zOupSb3lBCzJzCbdnYr aq0zzemn8ilALR2/fCvzdjbz6K8FNcDOkGztbgAk/v+MDZDlOfRLpB5n+zbIGKfiKoRc g3KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=cPgtDiuPSeOGpMEFddRELvHgc6ZjOmL7Lu2VYK9nvAU=; b=o4VLhr/4MWaS/NIbf84VZH8pdFkayl0rWSV+bssOyOYP1VMM4NIzUGv9sI5srwz+KT 9AQfGv5lwp5OoN6Lit/tc8GmIjCOyrbLFBE+m0PJ++zm0KVtXsuEW5D5MYos20AsYEXb n2TrC75K34WAVZC4x2cR8mgKbklTV3g7eont3SriNhAec1oMs5f4obo/zZmn+ago7kZb MIi6GamCqThXbtIy8hUQfTkS4Un3fHeOa9+/J65nIeCiee+D8AB9jPx6SxlW4Ty6ykbO 8ej3+pvIZHqaoe07PS1qO7py2TzY4ylHu21SqhmnDjo9CPYTxAwZJrA+F59OpuEkJoV8 39IQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s17si3203544ejz.148.2019.10.04.10.20.46; Fri, 04 Oct 2019 10:21:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729921AbfJDRUY (ORCPT + 99 others); Fri, 4 Oct 2019 13:20:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39044 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729291AbfJDRUX (ORCPT ); Fri, 4 Oct 2019 13:20:23 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C1CAD1801758; Fri, 4 Oct 2019 17:20:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 630929F7A; Fri, 4 Oct 2019 17:20:23 +0000 (UTC) Received: from zmail21.collab.prod.int.phx2.redhat.com (zmail21.collab.prod.int.phx2.redhat.com [10.5.83.24]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 492E21808876; Fri, 4 Oct 2019 17:20:23 +0000 (UTC) Date: Fri, 4 Oct 2019 13:20:23 -0400 (EDT) From: Bob Peterson To: Andrew Price Cc: cluster-devel@redhat.com, syzbot+c2fdfd2b783754878fb6@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org Message-ID: <824921067.4882112.1570209623167.JavaMail.zimbra@redhat.com> In-Reply-To: <20191003153552.2015-1-anprice@redhat.com> References: <000000000000afc1b40593f68888@google.com> <20191003153552.2015-1-anprice@redhat.com> Subject: Re: [Cluster-devel] [PATCH] gfs2: Fix memory leak when gfs2meta's fs_context is freed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.3.116.219, 10.4.195.10] Thread-Topic: gfs2: Fix memory leak when gfs2meta's fs_context is freed Thread-Index: Ei86TZNaiDR88EYSEPqE/xTVbulYpQ== X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Fri, 04 Oct 2019 17:20:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Original Message ----- > gfs2 and gfs2meta share an ->init_fs_context function which allocates an > args structure stored in fc->fs_private. gfs2 registers a ->free > function to free this memory when the fs_context is cleaned up, but > there was not one registered for gfs2meta, causing a leak. > > Register a ->free function for gfs2meta. The existing gfs2_fc_free > function does what we need. > > Reported-by: syzbot+c2fdfd2b783754878fb6@syzkaller.appspotmail.com > Signed-off-by: Andrew Price > --- Thanks. Now pushed to for-next. Bob Peterson