Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1234689ybp; Fri, 4 Oct 2019 11:27:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwBSvTrNzRL19AF+mv8VJ3Yspv2tXU/9pypxUxooZGtu4wcCR8qZxEu20ylJq+QMyUBpGwh X-Received: by 2002:a17:906:fad6:: with SMTP id lu22mr13322854ejb.98.1570213672923; Fri, 04 Oct 2019 11:27:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570213672; cv=none; d=google.com; s=arc-20160816; b=Lzh548lXJGnDYcWo7xNXeh+d+pW467QuzSa9KMAuQXOn2ryMi9Q5umN++IdOtbRL9z HTYXw3uOVUarXXlOvS6DTaO4bG7UivWBdvRW/qAEsjSKqWfLGC5TZe9e8xn3f4mZIM+N cz92Pa3KtjUEgYXsGOEg5sJnxwrXJ6hKpLjDzy1jxGf6NZ5/Qrui5GBQmQuH6KtlQIuo fd71j7gdzVzFPYRUFhoHywJMlWyziPeoVeok8Fhmu5/REgmITJ9ub5HHfhxT5iBFNDi4 MhdK9mibF0AivWu540Efxq9W4I+WsD85JJknYOSj+h30RLX6Gxu+QtUtlHqbThXEzhub 7cpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=zZ6KISfo14kOEL5Ieq+NQ6dxv0EXjT7PvLg26kcxeKI=; b=w6+MawEaS4Wrk1ZjjVa6qA5LLm5Aa3zKVVNnj5MRIFyMWNbK1Bo+wsb8FG3AqGcwE6 bY8C7N1hlCQ0lR4O5wSIqc7VnKX6Q+zYKt1GT5A42tqiivN7Ru3sLZwJKQPXumxm02z0 gqCXANVJU/qbjVcG7JhTuIZkHi+jCz5eipeg/6PtA7yGm9prRHhOxG3hCTm/wOXVBjc/ +zlyys0jwEfB+3HkzasDSk8FuaSCwb+2omV8lsYXxXeec+VMOwX5R5vzXc4030KvzNum JlX/vLFrFznAwNzNwjU/aqx1XB+J0W99cXGcDJNJ2YJCBk9cVFQMOStmfARthBLR0sb9 oH9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=NbrR9cDX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o22si3271424eju.25.2019.10.04.11.27.28; Fri, 04 Oct 2019 11:27:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=NbrR9cDX; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730131AbfJDS0S (ORCPT + 99 others); Fri, 4 Oct 2019 14:26:18 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:42262 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbfJDS0R (ORCPT ); Fri, 4 Oct 2019 14:26:17 -0400 Received: by mail-io1-f65.google.com with SMTP id n197so15539296iod.9 for ; Fri, 04 Oct 2019 11:26:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=zZ6KISfo14kOEL5Ieq+NQ6dxv0EXjT7PvLg26kcxeKI=; b=NbrR9cDXdXXj8NLCbdZebA/XHymI2ZV8JNrZi82vyS6yNX64HDkBmL3dHU2O9pMZXd 3LLoGfU/NkijXnsJuEROqNWsrS/DXjNbrPh0ZxItTdN7JNiCTJIdvi6yQJWxD7lgKLga 3cIEYvmCSebCu1xfIcZiWmgbyh3AEYy58zrQyurM5PTA1ZLsgMRD6tp7BY9nKy0RLb3g kBLxjv8BEFrmpOqqIkoLo+D/2i3QRiYMtiUQQt1z0baBpLuXXgSGHnr4ZH9wX88BzFiV fRME8q8VKZRI8oi8yZ2MvvHHV6itWhxAVqUh5+bqWGjxTx1xeOvNVUKF1eSv2otoL4LS G2xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=zZ6KISfo14kOEL5Ieq+NQ6dxv0EXjT7PvLg26kcxeKI=; b=uMurLV5FXwIf5fX3ayz5YFQIbmYuYyFZzzO8XLH6pjCgpfxjqCKpOzftwvPprAtAc8 L94uFV7DdLY0Zez3VFGoQu4XyBXjqpYaKkRthfetgHdcNBZA1pVeH5ybPRwg6FTXl8zf Fl8qUOSiKN+LNdYm1dWPYr78E8LWaaDcOsMQO1al8JL5LvM67fTExYlak8CUpBC0otF4 mrdqKwdu+quaRKsoC4VgAGeokd8krcK4xh07VZy95qFa3P14IpGw0+48iBEvpZFoYIge WDd6WzBqm4yH0wsHja30KCLsHWBdHCyzFvTNYUUctwjzmkfKMIkdVSTFHlxpM0nNSSzf /IVw== X-Gm-Message-State: APjAAAU604LIM7whTmdo+Ge9yHGICsx3AMR7Qegfzax25d+0hZXVtIZN OcEx9V1Z8VY+MxLz/ji+4aqLLA== X-Received: by 2002:a02:93e5:: with SMTP id z92mr16325106jah.8.1570213576916; Fri, 04 Oct 2019 11:26:16 -0700 (PDT) Received: from localhost (67-0-10-3.albq.qwest.net. [67.0.10.3]) by smtp.gmail.com with ESMTPSA id i18sm3602473ilc.34.2019.10.04.11.26.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Oct 2019 11:26:16 -0700 (PDT) Date: Fri, 4 Oct 2019 11:26:15 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Vincent Chen cc: linux-riscv@lists.infradead.org, palmer@sifive.com, aou@eecs.berkeley.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] riscv: avoid kernel hangs when trapped in BUG() In-Reply-To: <1569199517-5884-2-git-send-email-vincent.chen@sifive.com> Message-ID: References: <1569199517-5884-1-git-send-email-vincent.chen@sifive.com> <1569199517-5884-2-git-send-email-vincent.chen@sifive.com> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 23 Sep 2019, Vincent Chen wrote: > When the CONFIG_GENERIC_BUG is disabled by disabling CONFIG_BUG, if a > kernel thread is trapped by BUG(), the whole system will be in the > loop that infinitely handles the ebreak exception instead of entering the > die function. To fix this problem, the do_trap_break() will always call > the die() to deal with the break exception as the type of break is > BUG_TRAP_TYPE_BUG. > > Signed-off-by: Vincent Chen Thanks, queued for v5.4-rc. - Paul