Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 5 Oct 2019 05:07:13 +1000
From:   Aleksa Sarai <cyphar@cyphar.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Christian Brauner <christian.brauner@ubuntu.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] usercopy structs for v5.4-rc2
Message-ID: <20191004190713.hdfv5h3dppwmz6bs@yavin.dot.cyphar.com>
References: <20191004104116.20418-1-christian.brauner@ubuntu.com>
 <CAHk-=whxf5HVdaXqL6RgHCLzb2LNn3U2n_x4GWQZroCC+evRoA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ybqdhfvvxmbcd65c"
Content-Disposition: inline
In-Reply-To: <CAHk-=whxf5HVdaXqL6RgHCLzb2LNn3U2n_x4GWQZroCC+evRoA@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ybqdhfvvxmbcd65c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2019-10-04, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Fri, Oct 4, 2019 at 3:42 AM Christian Brauner
> <christian.brauner@ubuntu.com> wrote:
> >
> >            The only separate fix we we had to apply
> > was for a warning by clang when building the tests for using the result=
 of
> > an assignment as a condition without parantheses.
>=20
> Hmm. That code is ugly, both before and after the fix.
>=20
> This just doesn't make sense for so many reasons:
>=20
>         if ((ret |=3D test(umem_src =3D=3D NULL, "kmalloc failed")))
>=20
> where the insanity comes from
>=20
>  - why "|=3D" when you know that "ret" was zero before (and it had to
> be, for the test to make sense)
>=20
>  - why do this as a single line anyway?
>=20
>  - don't do the stupid "double parenthesis" to hide a warning. Make it
> use an actual comparison if you add a layer of parentheses.

You're quite right -- I was mindlessly copying the "ret |=3D" logic the
rest of test_user_copy.c does without thinking about it. I'll include a
cleanup for it in the openat2(2) series.

--=20
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
<https://www.cyphar.com/>

--ybqdhfvvxmbcd65c
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSxZm6dtfE8gxLLfYqdlLljIbnQEgUCXZeYXQAKCRCdlLljIbnQ
EgXGAPwLt+yoG/AS/EPKRhamvIpGZEPcAdAFQfAtdZ1RgIK4IwEAsk6taEl1FsU8
WixwP71Fw/Vosc97yiFLGAUdqXLmtQo=
=o6hD
-----END PGP SIGNATURE-----

--ybqdhfvvxmbcd65c--