Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1330109ybp; Fri, 4 Oct 2019 13:03:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqyRxDHnnzRLTUkOK1/sfxsyF5AkTZdPwNcub2opY1MdjTq1VvCpXp7mGuiIR7addVaz/1wH X-Received: by 2002:aa7:c343:: with SMTP id j3mr17377650edr.187.1570219383231; Fri, 04 Oct 2019 13:03:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570219383; cv=none; d=google.com; s=arc-20160816; b=uZfkWfG7YfGqizgpTjc9a+TW39Iu8LwbypIwXxkXS/43v3K+CPfIPqQI5Dp5Dh8LVD sI2Bv46k3NRAvJjNnZzNc9OiOW1sbVBl93scZSBsttadcP+1OhH7HTFzTisgI6WBJINy 9w3wfRZ6M3qikgOTTrue7d6+o3a+eqHo9cA8VOxuh7OX1wT8OUelxmnVTgHm4isuijN8 IWGdC2CmlvuMxIYMOh9eQiedWDOTAO6NTC4zTsCvrp+brkHnl3GDmS/Upxw/Vcemkn6U dN5UAMHN3gOpL1c7a41N9AeqWxwD5fmw75X+LL6hUI3Q+awkXGNKiFEl6A6MEGSj/RlD MJXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=rQHFRC3FYJO2movQwm+PWbFJqSdNDEspWaoRTcJaPZY=; b=wO/P2xMoLT27oGyjzSt/GXQ+1abjKNMV3E/8X1hG4Bw0DouGHL9KCup1sJr8hqbAMo tcCwdeHnE+l88Np2XOal6ohRYMtC/M4mPWar0aoenuKzXYAIOD3s5L7DrONzWZy8NXOZ kqbLR4lhEeoIIYTFKYbvMiaZjAj49ZjLuGEYdcFAQLsEVDvIyeknGpuk4MW0/h1Da0r0 ozreAde1MxGms/lW6wv//71iV+6xFerblS/HMJHzPuL8vfQ+Iuzr9T+Qw6bYEgPFm8bz 9hVAlMffzbN9Jrk1Rk98UkcOQRDbDpuEmgkfhbBFHH4gAMv+I02a84GR3yDy0G+YQ94O pO3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e31si4435259ede.199.2019.10.04.13.02.39; Fri, 04 Oct 2019 13:03:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730993AbfJDT7v (ORCPT + 99 others); Fri, 4 Oct 2019 15:59:51 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:57104 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729198AbfJDT7v (ORCPT ); Fri, 4 Oct 2019 15:59:51 -0400 Received: from [213.220.153.21] (helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iGTjx-0005cl-Le; Fri, 04 Oct 2019 19:59:49 +0000 Date: Fri, 4 Oct 2019 21:59:48 +0200 From: Christian Brauner To: Linus Torvalds Cc: Linux Kernel Mailing List Subject: Re: [GIT PULL] usercopy structs for v5.4-rc2 Message-ID: <20191004195947.lkq5lkyj5zvlyxaw@wittgenstein> References: <20191004104116.20418-1-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 04, 2019 at 10:53:41AM -0700, Linus Torvalds wrote: > On Fri, Oct 4, 2019 at 3:42 AM Christian Brauner > wrote: > > > > The only separate fix we we had to apply > > was for a warning by clang when building the tests for using the result of > > an assignment as a condition without parantheses. > > I've pulled this, since it's not in core kernel code anyway, but I > wish I had never had to see that ugly construct. I admit that I'm _less_ anal about other people's code in _tests_ as for example in this case. For core kernel code I obviously would not have taken this into the tree. Honestly, my main concern currently is to get people to add tests at all - at least if they want to go through my tree - and if they adhere to that request I'm more lenient. Christian