Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1432013ybp; Fri, 4 Oct 2019 14:54:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqzuLV719STXx2AeV9wokT6EWA06vXeGrdk5lGUpFGc6LR7uooreNO1R8qtxk49hU+DZqbqz X-Received: by 2002:a50:ac0a:: with SMTP id v10mr17552720edc.83.1570226088084; Fri, 04 Oct 2019 14:54:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570226088; cv=none; d=google.com; s=arc-20160816; b=iZTKrdV3bUA8/DfZbnA3v5NVG+TAKm+LmdoDRkHPq0YpZA8vLHr3UrkeV91cDlTXfh 9jGab8vXVr2o+2EwGQouhkwwet66RJbUAmqHm1Rns1ppxfA/mvJgkWarHPSPk2QLkWWW +cWx3vulTvStNYOONkUsiacRt5/jRDGxPwU8S2Yt6uKCTtKgsPHI7CZlQcRQHBeEnEhI W5IIPpMHJh+SNfIzCJ6hAQ/FhP9PZ7lljvf8kyVe9spsGEZfe789iKj9w7pi9aAHhxjB z7n7OQQ423wOdf0QU2IXRu/QPh6y/JyeShOnww34j+FcEgsWXsKHCJBt19PFp83n5nc2 ISVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=aFxUCStGAKzi7k6MZDv4ay+mSvXf65w62wzfXy9C+dQ=; b=HYs5LQOwb22gHDS4sYUOfn0ElaDVUd4e0CdTVmA3gJUfZVZ/hQUPfzHHZgl2PC5aVw 14fXRcYRJe3Ju7lrWaGzf7zUN8Xibg2PoUQBXItHGo6gyMBiOQj9NNr5nYYhmjaJ2Fj4 o1LgKDkKNhbwI8foYh6QnupwsGwc0IhGw2bK13LtF91UuLfHZRLzBEcdlr9ZXgmfpQD1 c/o4Q91HkbqyZFRoJjsdko/hwNimZruaG803L1JA3xbvbxwoCqNkAAyFcyEGwZPz4dZc ZkIv/zZr7WzwMRFs7x4P6LSfUjgIW+Xginl1hfHA0w67XGD9/MIr7Y58K52PEQeBRtqI l4QA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3si4135290edr.20.2019.10.04.14.54.24; Fri, 04 Oct 2019 14:54:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731179AbfJDVxr (ORCPT + 99 others); Fri, 4 Oct 2019 17:53:47 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:58981 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728841AbfJDVxr (ORCPT ); Fri, 4 Oct 2019 17:53:47 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212]) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iGVWC-0003gb-Fy; Fri, 04 Oct 2019 21:53:44 +0000 Subject: Re: [PATCH][next] drm/komeda: remove redundant assignment to pointer disable_done To: Liviu Dudau Cc: James Wang , Brian Starkey , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191004162156.325-1-colin.king@canonical.com> <20191004192720.7eiqdvsm2yv62svg@e110455-lin.cambridge.arm.com> From: Colin Ian King Autocrypt: addr=colin.king@canonical.com; prefer-encrypt=mutual; keydata= mQINBE6TJCgBEACo6nMNvy06zNKj5tiwDsXXS+LhT+LwtEsy9EnraKYXAf2xwazcICSjX06e fanlyhB0figzQO0n/tP7BcfMVNG7n1+DC71mSyRK1ZERcG1523ajvdZOxbBCTvTitYOy3bjs +LXKqeVMhK3mRvdTjjmVpWnWqJ1LL+Hn12ysDVVfkbtuIm2NoaSEC8Ae8LSSyCMecd22d9Pn LR4UeFgrWEkQsqROq6ZDJT9pBLGe1ZS0pVGhkRyBP9GP65oPev39SmfAx9R92SYJygCy0pPv BMWKvEZS/7bpetPNx6l2xu9UvwoeEbpzUvH26PHO3DDAv0ynJugPCoxlGPVf3zcfGQxy3oty dNTWkP6Wh3Q85m+AlifgKZudjZLrO6c+fAw/jFu1UMjNuyhgShtFU7NvEzL3RqzFf9O1qM2m uj83IeFQ1FZ65QAiCdTa3npz1vHc7N4uEQBUxyXgXfCI+A5yDnjHwzU0Y3RYS52TA3nfa08y LGPLTf5wyAREkFYou20vh5vRvPASoXx6auVf1MuxokDShVhxLpryBnlKCobs4voxN54BUO7m zuERXN8kadsxGFzItAyfKYzEiJrpUB1yhm78AecDyiPlMjl99xXk0zs9lcKriaByVUv/NsyJ FQj/kmdxox3XHi9K29kopFszm1tFiDwCFr/xumbZcMY17Yi2bQARAQABtCVDb2xpbiBLaW5n IDxjb2xpbi5raW5nQGNhbm9uaWNhbC5jb20+iQI2BBMBCAAhBQJOkyQoAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEGjCh9/GqAImsBcP9i6C/qLewfi7iVcOwqF9avfGzOPf7CVr n8CayQnlWQPchmGKk6W2qgnWI2YLIkADh53TS0VeSQ7Tetj8f1gV75eP0Sr/oT/9ovn38QZ2 vN8hpZp0GxOUrzkvvPjpH+zdmKSaUsHGp8idfPpZX7XeBO0yojAs669+3BrnBcU5wW45SjSV nfmVj1ZZj3/yBunb+hgNH1QRcm8ZPICpjvSsGFClTdB4xu2AR28eMiL/TTg9k8Gt72mOvhf0 fS0/BUwcP8qp1TdgOFyiYpI8CGyzbfwwuGANPSupGaqtIRVf+/KaOdYUM3dx/wFozZb93Kws gXR4z6tyvYCkEg3x0Xl9BoUUyn9Jp5e6FOph2t7TgUvv9dgQOsZ+V9jFJplMhN1HPhuSnkvP 5/PrX8hNOIYuT/o1AC7K5KXQmr6hkkxasjx16PnCPLpbCF5pFwcXc907eQ4+b/42k+7E3fDA Erm9blEPINtt2yG2UeqEkL+qoebjFJxY9d4r8PFbEUWMT+t3+dmhr/62NfZxrB0nTHxDVIia u8xM+23iDRsymnI1w0R78yaa0Eea3+f79QsoRW27Kvu191cU7QdW1eZm05wO8QUvdFagVVdW Zg2DE63Fiin1AkGpaeZG9Dw8HL3pJAJiDe0KOpuq9lndHoGHs3MSa3iyQqpQKzxM6sBXWGfk EkK5Ag0ETpMkKAEQAMX6HP5zSoXRHnwPCIzwz8+inMW7mJ60GmXSNTOCVoqExkopbuUCvinN 4Tg+AnhnBB3R1KTHreFGoz3rcV7fmJeut6CWnBnGBtsaW5Emmh6gZbO5SlcTpl7QDacgIUuT v1pgewVHCcrKiX0zQDJkcK8FeLUcB2PXuJd6sJg39kgsPlI7R0OJCXnvT/VGnd3XPSXXoO4K cr5fcjsZPxn0HdYCvooJGI/Qau+imPHCSPhnX3WY/9q5/WqlY9cQA8tUC+7mgzt2VMjFft1h rp/CVybW6htm+a1d4MS4cndORsWBEetnC6HnQYwuC4bVCOEg9eXMTv88FCzOHnMbE+PxxHzW 3Gzor/QYZGcis+EIiU6hNTwv4F6fFkXfW6611JwfDUQCAHoCxF3B13xr0BH5d2EcbNB6XyQb IGngwDvnTyKHQv34wE+4KtKxxyPBX36Z+xOzOttmiwiFWkFp4c2tQymHAV70dsZTBB5Lq06v 6nJs601Qd6InlpTc2mjd5mRZUZ48/Y7i+vyuNVDXFkwhYDXzFRotO9VJqtXv8iqMtvS4xPPo 2DtJx6qOyDE7gnfmk84IbyDLzlOZ3k0p7jorXEaw0bbPN9dDpw2Sh9TJAUZVssK119DJZXv5 2BSc6c+GtMqkV8nmWdakunN7Qt/JbTcKlbH3HjIyXBy8gXDaEto5ABEBAAGJAh8EGAEIAAkF Ak6TJCgCGwwACgkQaMKH38aoAiZ4lg/+N2mkx5vsBmcsZVd3ys3sIsG18w6RcJZo5SGMxEBj t1UgyIXWI9lzpKCKIxKx0bskmEyMy4tPEDSRfZno/T7p1mU7hsM4owi/ic0aGBKP025Iok9G LKJcooP/A2c9dUV0FmygecRcbIAUaeJ27gotQkiJKbi0cl2gyTRlolKbC3R23K24LUhYfx4h pWj8CHoXEJrOdHO8Y0XH7059xzv5oxnXl2SD1dqA66INnX+vpW4TD2i+eQNPgfkECzKzGj+r KRfhdDZFBJj8/e131Y0t5cu+3Vok1FzBwgQqBnkA7dhBsQm3V0R8JTtMAqJGmyOcL+JCJAca 3Yi81yLyhmYzcRASLvJmoPTsDp2kZOdGr05Dt8aGPRJL33Jm+igfd8EgcDYtG6+F8MCBOult TTAu+QAijRPZv1KhEJXwUSke9HZvzo1tNTlY3h6plBsBufELu0mnqQvHZmfa5Ay99dF+dL1H WNp62+mTeHsX6v9EACH4S+Cw9Q1qJElFEu9/1vFNBmGY2vDv14gU2xEiS2eIvKiYl/b5Y85Q QLOHWV8up73KK5Qq/6bm4BqVd1rKGI9un8kezUQNGBKre2KKs6wquH8oynDP/baoYxEGMXBg GF/qjOC6OY+U7kNUW3N/A7J3M2VdOTLu3hVTzJMZdlMmmsg74azvZDV75dUigqXcwjE= Message-ID: <35232014-f65a-f7a1-99db-8ed91f610a77@canonical.com> Date: Fri, 4 Oct 2019 22:53:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191004192720.7eiqdvsm2yv62svg@e110455-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/2019 20:27, Liviu Dudau wrote: > On Fri, Oct 04, 2019 at 05:21:56PM +0100, Colin King wrote: >> From: Colin Ian King >> >> The pointer disable_done is being initialized with a value that >> is never read and is being re-assigned a little later on. The >> assignment is redundant and hence can be removed. > > Not really true, isn't it? The re-assignment is done under the condition that > crtc->state->active is true. disable_done will be used regardless after the if > block, so we can't skip this initialisation. > > Not sure why Coverity flags this, but I would NAK this patch. I'm patching against the driver from linux-next so I believe this is OK for that. I believe your statement is true against linux which does not have commit: d6cb013579e743bc7bc5590ca35a1943f2b8f3c8 Author: Lowry Li (Arm Technology China) Date: Fri Sep 6 07:18:06 2019 +0000 Colin. > > Best regards, > Liviu > >> >> Addresses-Coverity: ("Unused value") >> Signed-off-by: Colin Ian King >> --- >> drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c >> index 75263d8cd0bd..9beeda04818b 100644 >> --- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c >> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c >> @@ -296,7 +296,7 @@ komeda_crtc_atomic_disable(struct drm_crtc *crtc, >> struct komeda_crtc_state *old_st = to_kcrtc_st(old); >> struct komeda_pipeline *master = kcrtc->master; >> struct komeda_pipeline *slave = kcrtc->slave; >> - struct completion *disable_done = &crtc->state->commit->flip_done; >> + struct completion *disable_done; >> bool needs_phase2 = false; >> >> DRM_DEBUG_ATOMIC("CRTC%d_DISABLE: active_pipes: 0x%x, affected: 0x%x\n", >> -- >> 2.20.1 >> >