Received: by 2002:a5b:505:0:0:0:0:0 with SMTP id o5csp1567506ybp;
        Fri, 4 Oct 2019 17:32:08 -0700 (PDT)
X-Google-Smtp-Source: APXvYqzWFXFoWIii1Q0grlkDUGqG/h9OS5RI01XT8FpCLIrg6BlTNNsflgM1A8qN80i2lgYJeKG1
X-Received: by 2002:a50:d98a:: with SMTP id w10mr18142322edj.276.1570235528054;
        Fri, 04 Oct 2019 17:32:08 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1570235528; cv=none;
        d=google.com; s=arc-20160816;
        b=n/cbLckxXEF8pz/UcXG8vVKDGXOcEWRRcrHYC0dMNbkkKQ+kO8XD2lyNNOKZwRojbN
         ebd3Q1XwmS2Hp/KuFMDCR5VMBRHkPDEhR1vULOMp9OnF2BvEwcm5tUWMVDm6ZH4mStGA
         +CkziSvkXLBqDI6NPXcB6SbF2Ig0Skl11PUL0WWYoCbsvSVoXVsXEkJtPYa6AAAmZE6M
         5Di16Ns8wmz4nEH+AvaFel7DABjkUzdFjXGeJryG93QEIWs/YYl6lEy/ybQU5odi5QSr
         DoojOo67R7retVNaaug6grk6XzwBdQTXoAd6RdkImFSexni0PPi5kiYW+Foo5lo5d2JE
         oGtQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=jg6uiRkKCUOIvdm0kXc9VPaNPihBE9sVGcFgR+czWfk=;
        b=Rq5Fc/uRMauyseuGkneBCbKu6SFVyLktbGjMYXGJSQ2wCc3bEj3bU4HKu5ceDAcysJ
         kR0X6B2isSo0Gf0hgRrTw7NuY1tDKr94fiWcQVpd4kNNFoYBcaEMdsXPtvzMrE7i4GCZ
         5U+P8Y1QEMyA/4WNFPxYJIH+kK+5cBYtcr+Jc1lOzT1TpA8/eWDR1Agjj1lHrkLv7oOB
         x7IhJqCGCt+ISfMYMHEEPqLNH8JZ1KR9dNpvr2uf1QBPLags4NOePwSjLMnhvFR1Glgf
         OLwELH5cy+WqEwOdS98+xgQuiOhrs9Hxt+C6tclzoKjTiDLUyQoSkE5FusD5MZdznVhw
         lmsA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id b30si4491623eda.200.2019.10.04.17.31.44;
        Fri, 04 Oct 2019 17:32:08 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730769AbfJEA2A (ORCPT <rfc822;ablacktshirt@gmail.com>
        + 99 others); Fri, 4 Oct 2019 20:28:00 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:60396 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725730AbfJEA2A (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 4 Oct 2019 20:28:00 -0400
Received: from localhost (unknown [IPv6:2601:601:9f00:1e2::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id AFE1E14F2D926;
        Fri,  4 Oct 2019 17:27:59 -0700 (PDT)
Date:   Fri, 04 Oct 2019 17:27:59 -0700 (PDT)
Message-Id: <20191004.172759.987507160837677462.davem@davemloft.net>
To:     kai.heng.feng@canonical.com
Cc:     hayeswang@realtek.com, mario.limonciello@dell.com,
        linux-usb@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] r8152: Set macpassthru in reset_resume callback
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20191004125104.13202-1-kai.heng.feng@canonical.com>
References: <20191004125104.13202-1-kai.heng.feng@canonical.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 04 Oct 2019 17:27:59 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Kai-Heng Feng <kai.heng.feng@canonical.com>
Date: Fri,  4 Oct 2019 20:51:04 +0800

> r8152 may fail to establish network connection after resume from system
> suspend.
> 
> If the USB port connects to r8152 lost its power during system suspend,
> the MAC address was written before is lost. The reason is that The MAC
> address doesn't get written again in its reset_resume callback.
> 
> So let's set MAC address again in reset_resume callback. Also remove
> unnecessary lock as no other locking attempt will happen during
> reset_resume.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>

Applied.